Received-SPF: pass (google.com: domain of linux-kernel+bounces-173681-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <18a6a31f-bccb-4d96-8503-1d80b5eb32e2@intel.com>
Date: Wed, 8 May 2024 10:58:37 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel: Use *-y
 instead of *-objs in Makefile
To: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>, "Lobakin,
 Aleksander" <aleksander.lobakin@intel.com>, Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>
CC: Alexei Starovoitov <ast@kernel.org>, Jesper Dangaard Brouer
	<hawk@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, Richard Cochran
	<richardcochran@gmail.com>, John Fastabend <john.fastabend@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Eric Dumazet
	<edumazet@google.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, Jakub Kicinski <kuba@kernel.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>, "bpf@vger.kernel.org"
	<bpf@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>, "David S. Miller"
	<davem@davemloft.net>
References: <20240508132315.1121086-1-andriy.shevchenko@linux.intel.com>
 <6ac025de-9264-4510-ba7f-f9a56c564a80@intel.com>
 <ZjuLW8jA3MuT0oih@smile.fi.intel.com>
 <5ab7ae5c-79d2-494e-8986-d18d4a8e74bb@intel.com>
 <4038b9d4-6618-46cc-bed8-a0ccd1c92cd2@intel.com>
 <SJ0PR11MB5866F14FA9B7D02BC97942F5E5E52@SJ0PR11MB5866.namprd11.prod.outlook.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <SJ0PR11MB5866F14FA9B7D02BC97942F5E5E52@SJ0PR11MB5866.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW1IQXNVTjloMXQ0Rlk3UFNVRHZ0VHVmdVpGaTdQMFY5RE5FaUJQYlpIOFd6?=
 =?utf-8?B?SjhzYnU3TFBqTWczWEFPTnFEYzFXcWs1K0hHaXlkTmcrT0ZqcGI3YmhsdCtJ?=
 =?utf-8?B?WkRhRlNwS1VGNWRjekwvMEJIY09CeFdNUGJBaU5DMzdmQkYya2N5UVJYSkQ4?=
 =?utf-8?B?dlZVK05zaDNBdjBnOFpNcmc3TGxPdVE3VlVxeTN6Sk9uYUx4M0RHQ3N3c2U5?=
 =?utf-8?B?YnQ1UHFkVGdIS0FFRms4SWx0VW1DanNqNlo4K1hNM3NjMjZyaWJiOXo3bDF3?=
 =?utf-8?B?dDVub2M3Y3ltMkJWcnEyWCtIZ3pIL3dtMFVUVndQVXE3aE1pcVNFUXZFaEhY?=
 =?utf-8?B?S1RMZTE3UkxUcXZUcTBxcWoyTHJRcndHOVhBMzF3RVErWHpBWUdwNkdkYVJy?=
 =?utf-8?B?aVdOV3B6dnVVUjB0QUtrOHlpeVg4dDF6QVA2Q1VEYUdJYlE5eXdrRXY0ZzRF?=
 =?utf-8?B?c0p5dG90aVIxVDB3RjhReEkrQ2FmRnJzbEJnRlUydU1lYlM5MVhCQXlzYllt?=
 =?utf-8?B?SWJUSWh3SUkySTJmUm9vTHhVOEZid1JWM0htZW85VnRwM0hQeldaeHk1YUNK?=
 =?utf-8?B?L3luWGJ1K1ZmY2hkeU5pR1pMc3RMczhCME1ZbnBmcHlwVWdUSlhjZzlCK1l0?=
 =?utf-8?B?WitxUTNKMUI3TlRvMzk1SFF3TXZuS25NUjRZc3FEclpaZHpEdDAzSDlQS2ly?=
 =?utf-8?B?V3VVMHJKeVo4TVN4WVIranVzRFBHczd1OXJSVTY2Tk9JR1FCdnhXRTNWT3BU?=
 =?utf-8?B?THJaUllLMXkzaVR0aTJDekRJU2tqcW1yRWtCTjU4NmZ4WjJuSHl1Nkd4dldF?=
 =?utf-8?B?azhyRXlUOEowR0xNRCtuSDBGZytRRk1SdHBoSm5ZZXdkdGpENmQ3QWZCODNY?=
 =?utf-8?B?eTNYTFhqaGZMcUhhRnhkNWlwM0p5ZGNzdGlkK0NNYU1sMU8wQkNxdUg4UERo?=
 =?utf-8?B?bWJrVm1SM1N0am1uQTQxenMwcnB0cTBOV2xHTVUxQXZGWTZLRW5XdWJtK3Uw?=
 =?utf-8?B?ZzFsNnAxeFBBZ1drdVZIdEE4anZDQXQ1eXVuRUFmSU0rZ09zMHB0Y0tyYjJQ?=
 =?utf-8?B?d1dLWGRJOVlTeUtDR2lldk5GbkFDZkhPWEQ1ckRJZzNjVzJMUDJlTmdob3Zh?=
 =?utf-8?B?U0ZIV3o1VmE1VTB1TlNvUnFRSFBIaXlNMlFxaXRtT21JTUxncWZyMCtwQ1FW?=
 =?utf-8?B?ODNWYTI1YVhIRW9JRHZjaGFYR0tFVS9DVm9BSHF5UEY0Vys1WVljWlFMT1V5?=
 =?utf-8?B?NXVhRUFsMGRsa25XYnVhSEVuSzRRclVxb3lsZnRBLzJCZkhXVmV1VUZ5Nlo3?=
 =?utf-8?B?VGN0ZXNNNTBlNHpWWFF3WG1WZ0p1SU9IV25WN2U4RDc2aUppYWRXdDM5TTFU?=
 =?utf-8?B?cEpOYkI5U0FpWUJ1MXNZZE4vOGIrNlowVzF2WXY5VkYrVEhVS2JNdnNVOTl3?=
 =?utf-8?B?QWYrR3RxT3U1LysvY2lYdTdKTXdqQzc4S0R4cTVkRkN4NlprVkg3eUhSM3k5?=
 =?utf-8?B?VXlxU2VNWFIzWVlERzNXaERDbXR1VXVqZGYvbTMxcjNKYmFGek52eWxjZU02?=
 =?utf-8?B?b2hudnlCTDVQbVo0Y0Z5dTMrZ3hHSWdLUkU0ZTZpK2dmcmdFSlIrd1N4QzFN?=
 =?utf-8?B?Y3RJUkVzWkx0MmRVR0wvOGZ0VzN0M0ZsbGxvMVByNDU2VElvd0tJWDN4cVly?=
 =?utf-8?B?ZEZoQVM4V0Q2QmdPRitadnRCaFVRSkdWMDV4QWlkdVlRUHg3STZaMm1YcG9o?=
 =?utf-8?B?UFY3bGNyQk05TkdEb1FadkZqbnF5Qit0YUt1RHVKWGxFL2NXYmpOMHQrYmd5?=
 =?utf-8?B?NDU2NnlJNkNRZkF5T0lFT2dGWnlsaTNSSi9oTlp4dXhFZFh6MHBqTnFuWGlo?=
 =?utf-8?B?ZkFERVpiS01uZkZZSDVmYk90djY0M3ppR3B0L1ZzdThVRG5NZ0hIK2J6SUpO?=
 =?utf-8?B?cGhhLzh4cWZsVXFxekZURVVxNFg2UjJlNW5yZUx1OE1zUXdWWHhPc0gxUW9D?=
 =?utf-8?B?N2wzdVB5aGJOR1lNMFFOUkVKMEh0eFo5bnd6aElHQ2NjMldXOWV6ZWxmRzdW?=
 =?utf-8?B?NmlENjgxb0Y0ZzVOckc0UnE0M0lTSktsZ2hsbS9ZaDVYOXppbUFBcGxNYkZY?=
 =?utf-8?B?U2NUdndlekZOK0IxS3psY0V2SHM4QnRLaDlqb0lWUUJTaGRleEFCNmo5YlU3?=
 =?utf-8?B?c2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 71538b11-b920-4921-10b4-08dc6f887d81
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 17:58:39.2602
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9ioVaU9nLNYpI2KjL+AGRuu9DwKvuir6pwiT7Wv2aqVXgLsKNZzg2ItS3pSWm4oRhDo0LpQZz6O4o631lMNnJX2Btsb7hWKqHwhnsSiSMo0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8504
X-OriginatorOrg: intel.com


On 5/8/2024 7:42 AM, Loktionov, Aleksandr wrote:
> 
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On
>> Behalf Of Alexander Lobakin
>> Sent: Wednesday, May 8, 2024 4:40 PM
>> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Alexei Starovoitov <ast@kernel.org>; Jesper Dangaard Brouer
>> <hawk@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>;
>> netdev@vger.kernel.org; Richard Cochran <richardcochran@gmail.com>;
>> John Fastabend <john.fastabend@gmail.com>; linux-
>> kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; intel-
>> wired-lan@lists.osuosl.org; Jakub Kicinski <kuba@kernel.org>;
>> Keller, Jacob E <jacob.e.keller@intel.com>; Nguyen, Anthony L
>> <anthony.l.nguyen@intel.com>; bpf@vger.kernel.org; Paolo Abeni
>> <pabeni@redhat.com>; David S. Miller <davem@davemloft.net>
>> Subject: Re: [Intel-wired-lan] [PATCH net-next v1 1/1] net: intel:
>> Use *-y instead of *-objs in Makefile
>>
>> From: Alexander Lobakin <aleksander.lobakin@intel.com>
>> Date: Wed, 8 May 2024 16:39:21 +0200
>>
>>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>> Date: Wed, 8 May 2024 17:25:31 +0300
>>>
>>>> On Wed, May 08, 2024 at 03:35:26PM +0200, Alexander Lobakin
>> wrote:
>>>>>> *-objs suffix is reserved rather for (user-space) host
>> programs
>>>>>> while usually *-y suffix is used for kernel drivers (although
>>>>>> *-objs works for that purpose for now).
>>>>>>
>>>>>> Let's correct the old usages of *-objs in Makefiles.
>>>>>
>>>>> Wait, I was sure I've seen somewhere that -objs is more new and
>>>>> preferred over -y.
>>>>
>>>> Then you are mistaken.
>>>>
>>>>> See recent dimlib comment where Florian changed -y to -objs for
>>>>> example.
>>>>
>>>> So does he :-)
>>>>
>>>>> Any documentation reference that -objs is for userspace and we
>>>>> should clearly use -y?
>>>>
>>>> Sure. Luckily it's documented in
>> Documentation/kbuild/makefiles.rst
>>>> "Composite Host Programs" (mind the meaning of the word
>> "host"!).
>>>
>>> Oh okay, I see. `-objs` is indeed only mentioned in the host
>> chapter.
>>
>> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>>
>> Thanks,
>> Olek
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>

Yea, reading the makefiles.rst again, it does seem that -objs only is
intended for host programs. The fact that it works now is an accident.
Further use of -y is necessary as we also use module-$(CONFIG_SYMBOL) to
resolve cases where we only include the files if the configuration is set.

Makes sense to clean this up.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>