Received-SPF: pass (google.com: domain of linux-kernel+bounces-173694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <1f2eb3d5-649d-4723-af89-ca625070877d@intel.com>
Date: Wed, 8 May 2024 11:23:39 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 1/1] net: intel: Use *-y instead of *-objs in
 Makefile
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
CC: Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen
	<anthony.l.nguyen@intel.com>, "David S. Miller" <davem@davemloft.net>, "Eric
 Dumazet" <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Lobakin <aleksander.lobakin@intel.com>,
	Richard Cochran <richardcochran@gmail.com>, Alexei Starovoitov
	<ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "Jesper Dangaard
 Brouer" <hawk@kernel.org>, John Fastabend <john.fastabend@gmail.com>,
	Aleksandr Loktionov <aleksandr.loktionov@intel.com>
References: <20240508180057.1947637-1-andriy.shevchenko@linux.intel.com>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240508180057.1947637-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkRSK1EyMUtySGhCNnZ2aFVrcU9TN1RQUXlVcENKTEc5SkE5ZUhoL2xDWU9G?=
 =?utf-8?B?c3RvYW5UOHUyN0d0b3A4NTNrODFSYnhNdjBnY2dhVnhCMlFoV2lodzBvT09E?=
 =?utf-8?B?QnpUdDNKVjlSVGcwbDhnSWZEUko4c1BZOWRQSkpaaFVwVks1ay9jNFVXOE9M?=
 =?utf-8?B?bmNWYlBzcWlKNk5YS2k0TTltWTg1MWZUdEd6Y2xjYlA2TU5uQ3FSUDRPeVlO?=
 =?utf-8?B?SFZUei8xVVFkejRWeHF5eklmek5PWTUyNnVWbnhsa1dsUU01WGZveGl3WFY2?=
 =?utf-8?B?V0JJVE8yN1M1UC9iNjQ2ZDFzTmFsMi9WYWY4c2pMdWtiNUdnL0Yya09CNjJ1?=
 =?utf-8?B?aGs1N2hVVjNqUDY3US92WEdOSCtjN1ZTWUpkN21PaEFuL1FaM3lQUVIxNFJp?=
 =?utf-8?B?OTZNY05KYzdQVFl4V3luOFQ1TGFLRnFUN0dEWXpCK3FGWXNjUkNPQVFJTkJj?=
 =?utf-8?B?TjBJVkYxMXdTS2QzRVFSdDVNaDgxd2J0bjZHeGhobm56Njh0em9wQ2pJUHl6?=
 =?utf-8?B?dkkrQ05xOTRldmFOQWs4N1BjN0k4QXFscmZtbFUrZXJqYkNFa2VDMDZpTGlR?=
 =?utf-8?B?UER6eUFzd1pFVnU5RkM4RkZyYmN2c1BGd292QnoxVWI5MktONVVaRUNhOERM?=
 =?utf-8?B?a2tyTEpIQms5aWhrbmtraWR1K253VHV6aFFsUnVHeXF3ZFVwN0cxVUtMZnRn?=
 =?utf-8?B?QVB4am1qOTI2ZnkzZmhHWFBwcDJvZG5keHFud0IvOXJoUWJRV2hzTlR1SUkw?=
 =?utf-8?B?L2EzMm84M1M0d1puVVFueVhBM01oUmo2VWlHcnk3dlpITkVOVlJRWnljNFph?=
 =?utf-8?B?WU5EZG5VcHh4RXhiTlpFMWtJU1JkQ3RWVUFxRXFHTGl0Z1MrMytuRS9WdDJo?=
 =?utf-8?B?dERWVTNzQmdTN0cwQkUyNHpOdmZwNms4djVrRitoYVpnbTBnR3NpY0VhaFFl?=
 =?utf-8?B?Q0NJQTRVNG9FOElUanJQSGxaU3BBRnZOcm5tVjQ3cTc3Z3o4MVdsaFRWK3lV?=
 =?utf-8?B?em1UejA0bDllcU9qcHpmaDBFRDlRb2VEakxKaWJNS0IyOE53dXluYm1wY01s?=
 =?utf-8?B?S3R1TDBVczVQK0ZnL2J5NUFMMlRNWDhOOW12b09MNzZveUZpZllEZGZhSTJ2?=
 =?utf-8?B?azhJeDlIT2M3ZVl5Mzl1SC82N0NFMVh0V1JZVDY1b3hidFpHM2tLUjI3M2tF?=
 =?utf-8?B?RkJpQmdpZFRvQ1Y2Q1pSVUE0ZE1mNXlmWDdRRXI1K1oraUtFK1pPL0RUc3NU?=
 =?utf-8?B?M3VBSEREQVJlZmpXclJiRXVublZCWlIrcEtGS0MrUGJKTk5iNERVajRFY0Vx?=
 =?utf-8?B?b0xaWkg0SmRaZXB2YnJQWXFLZmNpcDFpLzlDajErMUl5N29veVZNc1oxSE1K?=
 =?utf-8?B?aXN0clRQSjJucjBtc1lWVldBb0dCaXJqNktiMjdQWkQ5Y2IrL05mcUxwbE9o?=
 =?utf-8?B?emZkYnVNYjNES1BpN3IwT1VQZ1JnK3VyWm9xanBkcm9JdTVDZFN0SmE5VTBk?=
 =?utf-8?B?WG1ZR3UwVHJBeUYxQ1lTbmxOc2haWWVBT2xFeDRjcmNLci93d3M3WTkrdWNR?=
 =?utf-8?B?M3hvcHNQbEdQWjV6R3ZKN25xWVBtTVNBTUhQVFVjaVhjWkVNelhOaENXTHBR?=
 =?utf-8?B?aDE5Y0FsV2xXaSt5WS9BSGJhZjl5NTA5RGV2VEdEWGphaHlMWW1mM09BanI0?=
 =?utf-8?B?T215aThxUmhXemJubFAxbmEzZHhDMXk3TUx5Q20rR1NxRWVvUVJGYUNZbWcv?=
 =?utf-8?B?aVE2Y0d1bTJtcUdTVVEycUdPSGV4SVVKeXBLZlhiTTJPQ3dFTXNNYmVJZW0r?=
 =?utf-8?B?azZoWkdxeG1XTFhKdnIrVzlKc1BHKzd2NEFkcEwzd2Yvdm1KNnc0TW04bmQz?=
 =?utf-8?B?SE5CQnZmaU9lUW5hcFY1MEVnVTB1UnZyOHd1cElaYTRreFJ2NS9WbnFYbWN5?=
 =?utf-8?B?MG5xWm1UNExDMW0xT1NmMU5PYjh1V3FUNzVremk5WjdDcmpnMVpIYmg2a20x?=
 =?utf-8?B?VElmY0RzTHJCeE5NWXlneVpKQ1pFOFltL1E0UUtORzVBVnZ5Zndsa0RnN3pI?=
 =?utf-8?B?dWd4NC9Da2l0ZnRTSGtHWGdjaVNPWTM1MWI5aUoxdkdKSUU0enJGWTBkWnk1?=
 =?utf-8?B?MjlaMk43ZjVTZmEvSk9TSkhXN2JtS2hadXNmTENIcG5WK1VvSmRzalkrMExC?=
 =?utf-8?B?VkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5b94b992-1481-4264-de13-08dc6f8bfd43
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 18:23:42.1444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N2PLTcsTkqw3e6QB0VrVrE11ONb0rUrAx8u/fX3+2AMDQC4RggMw8ApoqX7nNx2PKhpJS5XmGqPLLH1ez9CcQ21qBCN5K++rSq7bKW5zAPs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7765
X-OriginatorOrg: intel.com


On 5/8/2024 11:00 AM, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

FWIW I applied v1 and v2, and got only the following range-diff:

> $ git range-diff net-next/main use-module-y-v1 use-module-y-v2
> 1:  0e5c43eb8e36 ! 1:  2cf60c46b7a8 net: intel: Use *-y instead of *-objs in Makefile
>     @@ Commit message
> 
>          Let's correct the old usages of *-objs in Makefiles.
> 
>     -    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>     -    Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>          Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
>     -    Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>     +    Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
>     +    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
>       ## drivers/net/ethernet/intel/e1000/Makefile ##
>      @@
>     @@ drivers/net/ethernet/intel/igbvf/Makefile
> 
>       ## drivers/net/ethernet/intel/igc/Makefile ##
>      @@
>     + #
>     +
>       obj-$(CONFIG_IGC) += igc.o
>     - igc-$(CONFIG_IGC_LEDS) += igc_leds.o
>     +-igc-$(CONFIG_IGC_LEDS) += igc_leds.o
> 
>      -igc-objs := igc_main.o igc_mac.o igc_i225.o igc_base.o igc_nvm.o igc_phy.o \
>      -igc_diag.o igc_ethtool.o igc_ptp.o igc_dump.o igc_tsn.o igc_xdp.o
>      +igc-y := igc_main.o igc_mac.o igc_i225.o igc_base.o igc_nvm.o igc_phy.o \
>      +   igc_diag.o igc_ethtool.o igc_ptp.o igc_dump.o igc_tsn.o igc_xdp.o
>     ++igc-$(CONFIG_IGC_LEDS) += igc_leds.o
> 
>       ## drivers/net/ethernet/intel/ixgbe/Makefile ##
>      @@
> 

This matches the changes described w.r.t ordering, and everything built
properly when I tested it on my test kernel tree.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>