Received-SPF: pass (google.com: domain of linux-kernel+bounces-173700-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 8 May 2024 21:28:58 +0300
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] eeprom: 93xx46: drop unneeded MODULE_ALIAS
Message-ID: <ZjvEam5paLD0Iv6V@smile.fi.intel.com>
References: <20240414154957.127113-1-krzk@kernel.org>
 <20240414154957.127113-3-krzk@kernel.org>
 <Zju8HpBCiOjjIZ1j@smile.fi.intel.com>
 <6599e2a3-3b04-4ea2-aa5c-a916b66c8009@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6599e2a3-3b04-4ea2-aa5c-a916b66c8009@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Wed, May 08, 2024 at 08:15:00PM +0200, Krzysztof Kozlowski wrote:
> On 08/05/2024 19:53, Andy Shevchenko wrote:
> > On Sun, Apr 14, 2024 at 05:49:57PM +0200, Krzysztof Kozlowski wrote:
> >> The ID table already has respective entry and MODULE_DEVICE_TABLE and
> >> creates proper alias for SPI driver.  Having another MODULE_ALIAS causes
> >> the alias to be duplicated.

..

> >>  MODULE_ALIAS("spi:93xx46");
> > 
> > I was stumbled over this (leftover?).
> > Commit message doesn't elaborate this bit.
> > Any comments?
> 
> It is not present in ID table and commit msg removes only duplicated
> aliases. That alias has meaning - someone might be actually relying on it.

It seems no users for it. The only user of platform data of this EEPROM uses
board files which AFAIU bypasses modalias matching.

-- 
With Best Regards,
Andy Shevchenko