Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp725025lqo; Wed, 8 May 2024 12:50:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbqi/n5GAv9lKMRE3d1ZaalTOZjII34ZI7sT5vhlxhL7fwO2hHB5V1+bvlM+LgOBRwSsncAKUjeaBzdjRHcQ3mRXnITKCEb8CbYX7kFg== X-Google-Smtp-Source: AGHT+IF9j4xwmmvQPLuzfDrgjXnBFDJASJPcpAhL1sZZjVzrMZV8tQPfX9ctyHOx16wKP5d69ohx X-Received: by 2002:a17:90b:4f8d:b0:2a2:fec9:1bbd with SMTP id 98e67ed59e1d1-2b65fe214c7mr892430a91.17.1715197810149; Wed, 08 May 2024 12:50:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715197810; cv=pass; d=google.com; s=arc-20160816; b=tzqif0rPP9GL0Vv4FweP1GwBj2is785BwbLrP/6vt7XHQ9svAGHsIOx8yjjBGbuNfP q6/7t9G6XbmJoIUditsVjOmIk1Fjp0gZH/iKsYQY1/vXolO/yurqJYNydOKvXI2Myhb9 7kQqiUvwbsMwbPSLQlYHyM07GEmvo4bUP5ELmcehLceCUUrYOv4B5LZ0NuBj58C1n3k7 j1sBJbUYrODM81B8KNxgaM91QY2nDNbpM9Fj3J2FscGDNqHM2Dm+SiHQLlpmrYv/Wp5y 0UL2H8Nkq23t2PaXqcAOrYAMOf+LYAxIckpmPmtX3ZlqWcOXVpqak3L9IIDG7C4MwAgQ ugVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=subject:cc:to:from:date:references:in-reply-to:message-id :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:feedback-id:dkim-signature:dkim-signature; bh=AevYpQYMyjfculEN7d2NxE46rgJdGyUNF04I9cx6jJU=; fh=LSri1thb4ABurunHbePLL74URK0UjK2Z0PoTMzqBH14=; b=ehnoEbsKiX4n5ZGUc6zy1PkuxuR9KQETUaeCmRYGYBSE4WZ4sPRYsTh8fzld+OgKYa EYmcZV7Db8xjVYU3TB7CLUi04mj+ZGfeGTJAnGHNM0b6rnHvCjCrbTHtGt1BBvpBY7NX J7oaAvq7esu5syt5SvfbGVD7xPioRv9MCDoiFa8vK2AuQPlykZ2e8wJyCt1ngkmnNC1W 6FO0E93f5xrWxAWhV96515tdRkulcghXb+EtSeJpE9kfTr9coJSYsAw5FUzihIo6Y6yG 3SM/LpgpUl0dtY6BR5U8iun4Vn9zo2zXNQDVDgwLH/zYl/yhBNmT1kOnejCKWDeE3b2V 0zBg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=OYwM5J3E; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Rl6UJmHi; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-173769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b628fc627csi1879519a91.151.2024.05.08.12.50.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 12:50:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-173769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=OYwM5J3E; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Rl6UJmHi; arc=pass (i=1 spf=pass spfdomain=arndb.de dkim=pass dkdomain=arndb.de dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=arndb.de); spf=pass (google.com: domain of linux-kernel+bounces-173769-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-173769-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=arndb.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B2516B221CF for ; Wed, 8 May 2024 19:36:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EACA130A5D; Wed, 8 May 2024 19:36:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="OYwM5J3E"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Rl6UJmHi" Received: from fout5-smtp.messagingengine.com (fout5-smtp.messagingengine.com [103.168.172.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED281A2C30; Wed, 8 May 2024 19:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715196961; cv=none; b=tCXXG5Fw9kZ07D99743I57tonsNGm3jXRd0QWVdURlZsqkUdXMcV0H2Vx18xoh/HEzDKeD7AWVgPuR5/8MBpM37OhjRA7CrAu7L6BDfSYdXHzV1p2fbMwgaXHky/6hQOh5OqW03BbqcsSnW+7ReBZDX70pWSqB0jPQP8QGpOLUw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715196961; c=relaxed/simple; bh=ioyYkn49aMsyL/o435ZP9K0GIVXUpTCKj5mXWnKZXts=; h=MIME-Version:Message-Id:In-Reply-To:References:Date:From:To:Cc: Subject:Content-Type; b=g70sfWKk3+kR4GTOK9f4mDaQMDzMAozB+sxCLGzqZqxlijTr2ZXT7mXfHe3UR972b7SB96kB2MMSn5nHkhR70zDYaMoCqezK6WU7WRzkJ2hgatCY6fPxLU8Tz6GHZPd4ldNCojwY6t5fUaV/22nLbrbeC1mXYBGIC8UNV/6494c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=OYwM5J3E; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Rl6UJmHi; arc=none smtp.client-ip=103.168.172.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 4BA3A13803A7; Wed, 8 May 2024 15:35:59 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 08 May 2024 15:35:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1715196959; x=1715283359; bh=AevYpQYMyj fculEN7d2NxE46rgJdGyUNF04I9cx6jJU=; b=OYwM5J3E85P/baYNl5kaaW9gYy W2cF6VebnaYT5UpwedMHWEN0hIfvDvJRfxadvKuDRrhVpp2aBbDPjh5kZwxtV1xB V01PtLcN+lfUoXQcJwku04UyIpjZtd9v7+FMpPE86qxuW0sgvZwo5OVTNmbqOqaj r9VfZ49kDlyfDvl8nztctA/GcKHfx8oselfW4heWExkcR9RG+32rQIMJNtZE3ozF maO75RTV1IpmLtdW678rWqnWlpmpVMJGTLrND0heBUVs1NF0VH+dtvDN3CFGNB11 PO98nLD9QZcNPstuZxhGza2ohowwxKWz+8N/tN6Z4nJt+KAgcw4IhAqhd3Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1715196959; x=1715283359; bh=AevYpQYMyjfculEN7d2NxE46rgJd GyUNF04I9cx6jJU=; b=Rl6UJmHiYwZWSuTBSiLwXwJxQoYtxfdhatsPv9WHvm29 Xq1UaYnuehGwlpSDfrQwu7i/96vcJ2Dyzk+VAgcd8Ycv2kxWxQYm3MW89nyijclv 9c0hARfFaY03G5KEVcbWnNy4ygVcunRnqlfQiY29YK2VnFM4Rp3QLUbHikE7Koeg TQycPYk4N5sam2krKY6xQChYInqdBF67CoHat9cIegs9d0SYEGJm8iu0GFpAyxb3 FCSmEwqtSPGhQEVMvauxZ9j7tqx/UWv7ICfvbmF8IG6s+EhH08FXwcKZW/iBahKm 7mYFNoSUOvbpQSW9hMTaF3HsMt2KUNGtT6d3//eDYQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeftddgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E1B40B6008D; Wed, 8 May 2024 15:35:58 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-443-g0dc955c2a-fm-20240507.001-g0dc955c2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <41639d6b-a429-43f4-8568-12fcd1671cff@app.fastmail.com> In-Reply-To: References: <20240503192858.103640-1-florian.fainelli@broadcom.com> <8e1867fc-34da-457c-b95a-2d51ea97336a@app.fastmail.com> <05a5e893-12f7-49fd-9a9a-abd387571f9b@broadcom.com> <47c63c4c-c657-4210-b476-c91c4f192483@app.fastmail.com> <41191296-0aa0-4010-b70f-efa80b9200d4@app.fastmail.com> Date: Wed, 08 May 2024 21:35:38 +0200 From: "Arnd Bergmann" To: "Florian Fainelli" , "Daniel Vetter" Cc: linux-kernel@vger.kernel.org, "Helge Deller" , "Thomas Zimmermann" , "Javier Martinez Canillas" , "Sam Ravnborg" , "open list:FRAMEBUFFER LAYER" , "open list:FRAMEBUFFER LAYER" Subject: Re: [PATCH] fbdev: Have CONFIG_FB_NOTIFY be tristate Content-Type: text/plain On Wed, May 8, 2024, at 20:37, Florian Fainelli wrote: > On 5/7/24 04:44, Arnd Bergmann wrote: >> On Tue, May 7, 2024, at 13:10, Daniel Vetter wrote: >>> On Mon, May 06, 2024 at 04:53:47PM +0200, Arnd Bergmann wrote: >> Right, let's wait for Florian to reply. From what he said earlier >> though, the only reason that the notifiers are getting in the >> way is the link error you get from trying to load a separately >> built fb.ko module on a kernel that was built with FB=n / FB_CORE=n, >> so I don't think he even cares about notifiers, only about >> allowing the recovery application to mmap() the framebuffer. > > Right, we do not really care about notifiers AFAICT. Based upon this > discussion there has been an action on our side to stop making use of > the FB subsystem for recovery and use the full blow DRM driver instead. Ok, sounds good. > While we get there, though I still see some value into this patch (or a > v2, that is). I have a v2 ready if you think there is some value in > pursuing that route, if not, we can stop there. I think if you want to do a new version, that is likely to run into new problems, given that this part of fbdev is particularly fragile and partly wrong. On the other hand, it would be nice to have a patch to limit the use of the notifiers to the smallest set of kernel configs that actually need it, and leave it turned off for everything else. These are the ones I could find: - CONFIG_GUMSTIX_AM200EPD (FB_EVENT_FB_REGISTERED) - CONFIG_LCD_CORGI, CONFIG_LCD_TDO24M (FB_EVENT_MODE_CHANGE) - CONFIG_LEDS_TRIGGER_BACKLIGHT (FB_EVENT_BLANK) - CONFIG_FB_OLPC_DCON (FB_EVENT_BLANK/BL_CORE_FBBLANK) - CONFIG_FB_SH_MOBILE_LCDC, CONFIG_BACKLIGHT_PCF50633, CONFIG_BACKLIGHT_PANDORA, CONFIG_BACKLIGHT_LP855X (BL_CORE_FBBLANK) - CONFIG_FB_CLPS711X, CONFIG_FB_IMX, CONFIG_MACH_AMS_DELTA (lcd BL_CORE_FBBLANK) - CONFIG_LCD_AMS369FG06, CONFIG_LCD_CORGI, CONFIG_LCD_HX8357, CONFIG_LCD_ILI922X, CONFIG_LCD_ILI9320, CONFIG_LCD_HP700, CONFIG_LCD_L4F00242T03, CONFIG_LCD_LMS283GF05, CONFIG_LCD_LMS501KF03 CONFIG_LCD_LTV350QV, CONFIG_LCD_OTM3225A, CONFIG_LCD_PLATFORM, CONFIG_LCD_TDO24M (lcd BL_CORE_FBBLANK) Almost all of these are exclusive to ancient ARMv5 boards or similar, so if we make the notifiers depend on the whole list, this would leave it disabled even for most configurations that enable CONFIG_FB=y. This could be done with a 'select', but I'd prefer the 'default y; depends on LCD_FOO || LCD_BAR || ...' variant because that makes it easier to spot if someone tries to add another one. Arnd