Message-ID: <47A05CBA.2030903@grupopie.com>
Date: Wed, 30 Jan 2008 11:17:14 +0000
From: Paulo Marques <pmarques@grupopie.com>
Organization: Grupo PIE
User-Agent: Thunderbird 1.5.0.12 (X11/20070509)
MIME-Version: 1.0
To: Bryan Wu <bryan.wu@analog.com>
CC: linux-kernel@vger.kernel.org, Robin Getz <robin.getz@analog.com>
Subject: Re: [PATCH 1/1] [Kallsyms] Blackfin: Allow kernel symbols in L1 to
 be found
References: <1201688453-1763-1-git-send-email-bryan.wu@analog.com>
In-Reply-To: <1201688453-1763-1-git-send-email-bryan.wu@analog.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 30

Bryan Wu wrote:
> From: Robin Getz <robin.getz@analog.com>
> [...]
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -12,6 +12,8 @@
>   * (25/Aug/2004) Paulo Marques <pmarques@grupopie.com>
>   *      Changed the compression method from stem compression to "table lookup"
>   *      compression
> + * (10/Jul/2006) Robin Getz <rgetz@blackfin.uclinux.org>
> + *      Add _stext_l1, _etext_l1 for the L1 memory section in Blackfin.

When I wrote this initially, it was a mistake to add a Changelog in the 
first place, but I didn't know better at the time.

If you're going to make changes to this file, please remove all the 
Changelog, instead of adding more entries to it. The "Changelog" should 
be kept by the version control system, and not the source code itself.

The rest of the patch looks ok, though.

-- 
Paulo Marques - www.grupopie.com

"Very funny Scotty. Now beam up my clothes."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/