Received-SPF: pass (google.com: domain of linux-kernel+bounces-173787-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7e92200e-d68c-4dc4-85c3-7192a23f8cbc@amd.com>
Date: Wed, 8 May 2024 15:07:16 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
To: Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
 fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, yanjiewtw@gmail.com,
 kim.phillips@amd.com, lukas.bulwahn@gmail.com, seanjc@google.com,
 jmattson@google.com, leitao@debian.org, jpoimboe@kernel.org,
 rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
 jithu.joseph@intel.com, kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, peternewman@google.com,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <48b595cc-5ffe-4507-bffd-335a60fdaab9@intel.com>
 <2016b830-64c7-43bd-8116-bdfd239221e3@amd.com>
 <ea75801f-e56a-486d-85a4-85c57bce0c81@intel.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <ea75801f-e56a-486d-85a4-85c57bce0c81@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MFZwcDRlRTNKZEhBUXpncTdtSUdHMXlaSjZZNzZqSUZXTURjOHdtb3hiR29O?=
 =?utf-8?B?Wm9UMGhuWWl6N1gvNHh3QXBsZGFFUnBSM0gvdlBqUnJwRUpqNE1qQUFGeTQz?=
 =?utf-8?B?dnEzbU11NE94MEpZYVpISnl2L092WlRDMzVDckhuTlRpZ1I4NHpWNWduUzho?=
 =?utf-8?B?aDdyU2dhd0huT3pMY0ZpaTg2TUJmbG5xRU1BM3daN3BPVW9Ob0o3aDcwa0k3?=
 =?utf-8?B?aFlqMXE5SUhOZ2NtU0JPWllSclVTSlZ1elB3UGVQTEtKYTBoenJpclpqZE1N?=
 =?utf-8?B?ayt6eGZ0SkFJUUpEZFplUGJ3UUU3VDFucEZPS1czQTJFbjhaYjJMcUN1eEtp?=
 =?utf-8?B?amppM29wN0pxY1hHOS9ab3VPK25sTjVVQlZEUnFCMGh5RklyVTc2VHdUcnFK?=
 =?utf-8?B?TFhMRm1sR3h2NVJ5aGwxTlFVV3ZZZXpCWEo0ZGhia2hCV01CV2w4b3ZlT1Vq?=
 =?utf-8?B?U01naldwMGl6MlM3MkRBUjZPdUljbG10RzBhZEpZKzJTMEw1Mm1NWmVMelp4?=
 =?utf-8?B?a1Jhek9pTkJaRUZhTG9wMEZ3cmd0WXhjT0d3aDVJS0t2bWxnbzZYaER2MEZ2?=
 =?utf-8?B?cFk5bWgxVm5vVUtkN1NvYmRCOVYyK0M4UE5INTlMTjFxOFdVd0EveW9HUkJV?=
 =?utf-8?B?M1hWTUxzM0lDOFpFQmJYQ3JjK0FzUnk0T0dQTm5ObVFWWWhyMURCeVdZUHV1?=
 =?utf-8?B?Zk5LMXpaVUNDbDV3MFpvSDZGZ2svUEhVbjk0VnNiV1JMOEN4UHFwV2RIT0F5?=
 =?utf-8?B?TFdWL2dUUGlVc1BHU2hpazJKZ3JIRXR3ZTNpVGpJUmVwak5UQWpEcGp4a3RC?=
 =?utf-8?B?cTR6Zlh2NU9NY2VFTTJWL3F6TGhRSUViMW9RblVZZnRiQ2oreTE1eUdhNzU3?=
 =?utf-8?B?aldxWGtNbmNpZGtNOE1EL0JiRzJSMlc0NXJGcC80bU9nUjhLK3RWYUg4YXJE?=
 =?utf-8?B?OUpidGVtK1ozWmtJa2gvMitxK2hpSnpqMUsvbWxRREUweFZjVDlDazBFbGNZ?=
 =?utf-8?B?cHVwNTZPdGpVb0hRZGxjbm4wZXcvUzdrVkNsMmloa0cxSmNtRkdxTEd4UzND?=
 =?utf-8?B?YVd4YUZlWDEybnN3R3JYUDU1d01qNEFDVE42RFEyQkFVenlGanlENDhWbmNP?=
 =?utf-8?B?SU84Qk13bytUUWRRaEVaZzhFL1dzeW9qbGhmcndDZ3FnSUtmaWZNL01KQzJG?=
 =?utf-8?B?ZFpvbE9qWUpDTTdpeUs1aTZETHRaZ2FPemZzSDcyR3hleTdLWVkwd0J4MHNv?=
 =?utf-8?B?UVVoSVZmWWlQandKL0psN2x0a0J0VkpyNkdFbVNMOWRQQTBjR2xWeHI1QnRw?=
 =?utf-8?B?YVI1MjI0ZlkrNk9PTi9GYis5Z2ZVQU92UWJzSDRiNzZKeXZ4eHB0VEpwNTRr?=
 =?utf-8?B?OWpQRFFHQ29URTYzaXZhTVV4YWxCK3FWUG9TRXB0Z3RMTTJCUGEwZzNDSkZz?=
 =?utf-8?B?eGhNNTYydUJYeUd6ZEF0ZnQ0clVObG9nb2pWaTdxalZvTU9RdDV3L1Y5czhp?=
 =?utf-8?B?eW41NVZXQ05ENnZCWEJBdVBKaXc2cUhtL1JsaTB2NTFtR3lmWGZIZi9UV3Ux?=
 =?utf-8?B?SGRrdW5Ub0grQ2FQdDN2MW5UUWRwU3ZHK3JmZmV2SVkvUHgrc3ZtbEhxMXda?=
 =?utf-8?B?RVA4b3g5dC81WFYxdG81VlYvdWttTzZocFdOUmFQYzNOM0ZEbUNyWThyZGs2?=
 =?utf-8?B?YzN1SmcxM3MyVWwyZGVXYjMyaVE3d29nZ3pvbC80OTlyV2R4RDlJd3dMUzRK?=
 =?utf-8?B?T002TUFXeWRuKyt6WmZzSStla3dQT0EwdUozZ05Edi8zR0hsSkVCcG5jMHpE?=
 =?utf-8?B?VS9CallxelZhQmd4T2ZVVVRYSTlSSWl5aU55K2VNdUlUb3hVNGcyMjJrS3Aw?=
 =?utf-8?B?U0c5RGYwbVgvbVZ1eHB3U2FMM2g5dFBWTldtdENzd3IvN05Ta0NNTnh4eHQ4?=
 =?utf-8?B?d0kwVmtyR0s5M21ySjNFQTl1cm9SZXcxbzR6blkxNXFWbDVWSHVqdm9kNy9Y?=
 =?utf-8?B?NnU0MkVKd0tYL3pkc0U0T08yNXZtUnJjUlN4SXRnVWEwU251YTdyZmpnRjAz?=
 =?utf-8?B?MVVpY0xCRmRDRm96ODF6d1J0NC82WHVHM2lZN0h0bTMrNDVuQmNKWmFpUXZY?=
 =?utf-8?Q?89xw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1745cacd-d044-4fbf-246b-08dc6f9a77ce
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 20:07:20.7404
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b7uglqbI/iq/ro82msbJ6M/IkNBsUBt69MJqNQgFYehmAote2ipQbTQ6S9lIQBHU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4337

Hi Reinette,

On 5/7/24 15:26, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/6/2024 10:18 AM, Moger, Babu wrote:
>> On 5/3/24 18:24, Reinette Chatre wrote:
>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>
>>>> a. Check if ABMC support is available
>>>> 	#mount -t resctrl resctrl /sys/fs/resctrl/
>>>>
>>>> 	#cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>>>> 	[abmc] 
>>>> 	legacy_mbm
>>>>
>>>> 	Linux kernel detected ABMC feature and it is enabled.
>>>
>>> Please note that this adds the "abmc" feature to the resctrl
>>> *filesystem* that supports more architectures than just AMD. Calling the
>>> resctrl filesystem feature "abmc" means that (a) AMD needs to be ok with
>>> other architectures calling their features that are
>>> similar-but-maybe-not-identical-to-AMD-ABMC "abmc", or (b) this needs
>>> a new generic name.
>>
>> It should not a problem if other architecture calling abmc for similar
>> feature. But generic name is always better if there is a suggestion.
> 
> "should not a problem" does not instill confidence that AMD is
> actually ok with this.

The feature "ABMC" has been used in the public document already to refer
this feature.
https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24594.pdf

If there comes a conflict then we can change it to amd_abmc. Didn't see
any conflict at this pint.
-- 
Thanks
Babu Moger