Received-SPF: pass (google.com: domain of linux-kernel+bounces-173810-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <ZjssGrj+abyC6mYP@gmail.com>
In-Reply-To: <ZjssGrj+abyC6mYP@gmail.com>
From: Ian Rogers <irogers@google.com>
Date: Wed, 8 May 2024 13:44:52 -0700
Message-ID: <CAP-5=fUvLiCDVDFFfJ78ng4T1FZ8j2N9Yt1sGTeGsupkbFEEug@mail.gmail.com>
Subject: Re: Makefile.perf:1149: *** Missing bpftool input for generating
 vmlinux.h. Stop.
To: Ingo Molnar <mingo@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>, Adrian Hunter <adrian.hunter@intel.com>, 
	Jiri Olsa <jolsa@kernel.org>, Kan Liang <kan.liang@linux.intel.com>, 
	Namhyung Kim <namhyung@kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 8, 2024 at 12:39=E2=80=AFAM Ingo Molnar <mingo@kernel.org> wrot=
e:
>
>
> So I've been getting this perf build failure for some time:
>
>   kepler:~/tip/tools/perf> make clean
>   Makefile.perf:1149: *** Missing bpftool input for generating vmlinux.h.=
  Stop.
>   make: *** [Makefile:90: clean] Error 2
>
> ... but if I clone a new repository, it works fine, until a point.
>
> 'make clean' doesn't work - and 'make mrproper' in the main kernel
> directory doesn't clean up properly.
>
> Only if I do a brute-force:
>
>         rm -rf tools/
>         git checkout HEAD -f
>
> does it get resolved.
>
> The failure condition triggers if I Ctrl-C the following build a couple o=
f
> times, without it being finished:
>
>
>    cd tools/perf; make clean install
>    ...
>
>    LD      util/perf-in.o
>    LD      perf-in.o
>    CC      pmu-events/pmu-events.o
>  ^Cmake[3]: *** [pmu-events/Build:43: pmu-events/pmu-events.o] Interrupt
>  make[2]: *** [Makefile.perf:709: pmu-events/pmu-events-in.o] Interrupt
>  make[1]: *** [Makefile.perf:264: sub-make] Interrupt
>  make: *** [Makefile:113: install] Interrupt
>  kepler:~/tip> perfi
>  Makefile.perf:1149: *** Missing bpftool input for generating vmlinux.h. =
 Stop.
>  make: *** [Makefile:90: clean] Error 2

We have a checked-in vmlinux.h:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tr=
ee/tools/perf/util/bpf_skel/vmlinux/vmlinux.h?h=3Dperf-tools-next
so this shouldn't have been a problem for a while. bpftool is no
longer on that line:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tr=
ee/tools/perf/Makefile.perf?h=3Dperf-tools-next#n1149
so I suspect if you use a newer tree then things will work.

Thanks,
Ian

> Thanks,
>
>         Ingo