Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761498AbYA3LXh (ORCPT ); Wed, 30 Jan 2008 06:23:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753674AbYA3LXZ (ORCPT ); Wed, 30 Jan 2008 06:23:25 -0500 Received: from sovereign.computergmbh.de ([85.214.69.204]:33672 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753206AbYA3LXY (ORCPT ); Wed, 30 Jan 2008 06:23:24 -0500 Date: Wed, 30 Jan 2008 12:23:23 +0100 (CET) From: Jan Engelhardt To: Jonas Bonn cc: netdev@vger.kernel.org, romieu@fr.zoreil.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [SIS190] Constify data marked as __devinitdata In-Reply-To: <1201690388-9052-1-git-send-email-jonas@southpole.se> Message-ID: References: <1201690388-9052-1-git-send-email-jonas@southpole.se> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 919 Lines: 23 On Jan 30 2008 11:53, Jonas Bonn wrote: > >This fixes build error as gcc complains about a "section type conflict" >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = { >+static const struct pci_device_id sis190_pci_tbl[] __devinitdata = { > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0190), 0, 0, 0 }, > { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x0191), 0, 0, 1 }, > { 0, }, Eh? Did you mean to - static const u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; + static u16 __devinitdata ids[] = { 0x0965, 0x0966, 0x0968 }; instead? Because AFAIK, const *and* __sectionmarker does not mix. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/