Received-SPF: pass (google.com: domain of linux-kernel+bounces-173828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240503171847.68267-1-puranjay@kernel.org>
References: <20240503171847.68267-1-puranjay@kernel.org>
From: Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date: Wed, 8 May 2024 17:10:00 -0400
Message-ID: <CAE-0n50Pcmjq7b3F7OiU066FR3vk9avU22H0OEcoGcbGVd14dw@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] arm64/arch_timer: include <linux/percpu.h>
To: Catalin Marinas <catalin.marinas@arm.com>, Douglas Anderson <dianders@chromium.org>, 
	Mark Rutland <mark.rutland@arm.com>, Peter Zijlstra <peterz@infradead.org>, 
	Puranjay Mohan <puranjay@kernel.org>, Sumit Garg <sumit.garg@linaro.org>, 
	Thomas Gleixner <tglx@linutronix.de>, Will Deacon <will@kernel.org>, bpf@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: puranjay12@gmail.com
Content-Type: text/plain; charset="UTF-8"

Quoting Puranjay Mohan (2024-05-03 10:18:46)
> arch_timer.h includes linux/smp.h since the commit:
>
>   6acc71ccac7187fc ("arm64: arch_timer: Allows a CPU-specific erratum to only affect a subset of CPUs")
>
> It was included to use DEFINE_PER_CPU(), etc. But It should have
> included <linux/percpu.h> rather than <linux/smp.h>. It worked because
> smp.h includes percpu.h.
>
> The next commit will remove percpu.h from smp.h and it will break this
> usage.
>
> Explicitly include percpu.h and remove smp.h
>
> Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>