Received-SPF: pass (google.com: domain of linux-kernel+bounces-173829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240508141458.439017-1-james.clark@arm.com> <CAP-5=fWMbLDmT8=h_He7+9V+ntTdg1+5hmSTm87VJsTy2m3Bag@mail.gmail.com>
In-Reply-To: <CAP-5=fWMbLDmT8=h_He7+9V+ntTdg1+5hmSTm87VJsTy2m3Bag@mail.gmail.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Wed, 8 May 2024 14:10:44 -0700
Message-ID: <CAM9d7cgeWXB45WEwHLOazVKvq-e-34v2q-MikdjyweHP8b7tFg@mail.gmail.com>
Subject: Re: [PATCH] perf dwarf-aux: Fix build with HAVE_DWARF_CFI_SUPPORT
To: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@arm.com>, linux-perf-users@vger.kernel.org, 
	leo.yan@linux.dev, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, "Liang, Kan" <kan.liang@linux.intel.com>, 
	Masami Hiramatsu <mhiramat@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 8, 2024 at 2:05=E2=80=AFPM Ian Rogers <irogers@google.com> wrot=
e:
>
> On Wed, May 8, 2024 at 7:15=E2=80=AFAM James Clark <james.clark@arm.com> =
wrote:
> >
> > check_allowed_ops() is used from both HAVE_DWARF_GETLOCATIONS_SUPPORT
> > and HAVE_DWARF_CFI_SUPPORT sections, so move it into the right place so
> > that it's available when either are defined. This shows up when doing
> > a static cross compile for arm64:
> >
> >   $ make ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- LDFLAGS=3D"-st=
atic" \
> >     EXTRA_PERFLIBS=3D"-lexpat"
> >
> >   util/dwarf-aux.c:1723:6: error: implicit declaration of function 'che=
ck_allowed_ops'
> >
> > Fixes: 55442cc2f22d ("perf dwarf-aux: Check allowed DWARF Ops")
> > Signed-off-by: James Clark <james.clark@arm.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
> (eye-balled to see the #if problem exists and this is the correct fix)

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung