Received-SPF: pass (google.com: domain of linux-kernel+bounces-173830-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240503181333.2336999-1-eahariha@linux.microsoft.com>
 <20240503181333.2336999-2-eahariha@linux.microsoft.com> <0a6d4fa9-169f-425b-93d6-04314c617090@linux.microsoft.com>
 <CADnq5_NpxPM-FTcCchdBMRng=6xdM03s93XEX2_8fx44MRVYag@mail.gmail.com> <2654ad6e-66b7-4698-94da-892cc9d0802c@linux.microsoft.com>
In-Reply-To: <2654ad6e-66b7-4698-94da-892cc9d0802c@linux.microsoft.com>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Wed, 8 May 2024 17:12:26 -0400
Message-ID: <CADnq5_PAr6GHEBuStcJ6KVBS+mg64koqJwTDcz+7UcaEy_P_qA@mail.gmail.com>
Subject: Re: [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology
 more inclusive
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, 
	Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" <intel-gfx@lists.freedesktop.org>, 
	"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS" <intel-xe@lists.freedesktop.org>, 
	"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" <nouveau@lists.freedesktop.org>, 
	"open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@vger.kernel.org>, 
	"open list:BTTV VIDEO4LINUX DRIVER" <linux-media@vger.kernel.org>, 
	"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>, "Pan, Xinhui" <Xinhui.Pan@amd.com>, 
	Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>, 
	Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>, Evan Quan <evan.quan@amd.com>, 
	Hawking Zhang <Hawking.Zhang@amd.com>, Candice Li <candice.li@amd.com>, 
	Ran Sun <sunran001@208suo.com>, Alexander Richards <electrodeyt@gmail.com>, 
	Wolfram Sang <wsa@kernel.org>, Andi Shyti <andi.shyti@linux.intel.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, Heiko Stuebner <heiko@sntech.de>, 
	Heiner Kallweit <hkallweit1@gmail.com>, Hamza Mahfooz <hamza.mahfooz@amd.com>, 
	Ruan Jinjie <ruanjinjie@huawei.com>, Aurabindo Pillai <aurabindo.pillai@amd.com>, 
	Wayne Lin <wayne.lin@amd.com>, Samson Tam <samson.tam@amd.com>, Alvin Lee <alvin.lee2@amd.com>, 
	Sohaib Nadeem <sohaib.nadeem@amd.com>, Charlene Liu <charlene.liu@amd.com>, 
	Tom Chung <chiahsuan.chung@amd.com>, Alan Liu <haoping.liu@amd.com>, 
	Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>, 
	Meenakshikumar Somasundaram <meenakshikumar.somasundaram@amd.com>, George Shen <george.shen@amd.com>, 
	Aric Cyr <aric.cyr@amd.com>, Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>, 
	Qingqing Zhuo <Qingqing.Zhuo@amd.com>, Dillon Varone <dillon.varone@amd.com>, 
	Lijo Lazar <lijo.lazar@amd.com>, Asad kamal <asad.kamal@amd.com>, 
	Kenneth Feng <kenneth.feng@amd.com>, Ma Jun <Jun.Ma2@amd.com>, 
	Darren Powell <darren.powell@amd.com>, Yang Wang <kevinyang.wang@amd.com>, 
	Mario Limonciello <mario.limonciello@amd.com>, Yifan Zhang <yifan1.zhang@amd.com>, Le Ma <Le.Ma@amd.com>, 
	"open list:RADEON and AMDGPU DRM DRIVERS" <amd-gfx@lists.freedesktop.org>, 
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>, Alex Deucher <alexander.deucher@amd.com>, 
	open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 8, 2024 at 4:12=E2=80=AFPM Easwar Hariharan
<eahariha@linux.microsoft.com> wrote:
>
> On 5/8/2024 7:53 AM, Alex Deucher wrote:
> > On Tue, May 7, 2024 at 2:32=E2=80=AFPM Easwar Hariharan
> > <eahariha@linux.microsoft.com> wrote:
> >>
> >> On 5/3/2024 11:13 AM, Easwar Hariharan wrote:
> >>> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master=
/slave"
> >>> with more appropriate terms. Inspired by and following on to Wolfram'=
s
> >>> series to fix drivers/i2c/[1], fix the terminology for users of
> >>> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exis=
ts
> >>> in the specification.
> >>>
> >>> Compile tested, no functionality changes intended
> >>>
> >>> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sa=
ng-engineering.com/
> >>>
> >>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> >>> ---
> >>>  .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c  |  8 +++---
> >>>  drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c       | 10 +++----
> >>>  drivers/gpu/drm/amd/amdgpu/atombios_i2c.c     |  8 +++---
> >>>  drivers/gpu/drm/amd/amdgpu/atombios_i2c.h     |  2 +-
> >>>  drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c    | 20 ++++++-------
> >>>  .../gpu/drm/amd/display/dc/bios/bios_parser.c |  2 +-
> >>>  .../drm/amd/display/dc/bios/bios_parser2.c    |  2 +-
> >>>  .../drm/amd/display/dc/core/dc_link_exports.c |  4 +--
> >>>  drivers/gpu/drm/amd/display/dc/dc.h           |  2 +-
> >>>  drivers/gpu/drm/amd/display/dc/dce/dce_i2c.c  |  4 +--
> >>>  .../display/include/grph_object_ctrl_defs.h   |  2 +-
> >>>  drivers/gpu/drm/amd/include/atombios.h        |  2 +-
> >>>  drivers/gpu/drm/amd/include/atomfirmware.h    | 26 ++++++++---------
> >>>  .../powerplay/hwmgr/vega20_processpptables.c  |  4 +--
> >>>  .../amd/pm/powerplay/inc/smu11_driver_if.h    |  2 +-
> >>>  .../inc/pmfw_if/smu11_driver_if_arcturus.h    |  2 +-
> >>>  .../inc/pmfw_if/smu11_driver_if_navi10.h      |  2 +-
> >>>  .../pmfw_if/smu11_driver_if_sienna_cichlid.h  |  2 +-
> >>>  .../inc/pmfw_if/smu13_driver_if_aldebaran.h   |  2 +-
> >>>  .../inc/pmfw_if/smu13_driver_if_v13_0_0.h     |  2 +-
> >>>  .../inc/pmfw_if/smu13_driver_if_v13_0_7.h     |  2 +-
> >>>  .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c |  4 +--
> >>>  .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c   |  8 +++---
> >>>  drivers/gpu/drm/radeon/atombios.h             | 16 +++++------
> >>>  drivers/gpu/drm/radeon/atombios_i2c.c         |  4 +--
> >>>  drivers/gpu/drm/radeon/radeon_combios.c       | 28 +++++++++--------=
--
> >>>  drivers/gpu/drm/radeon/radeon_i2c.c           | 10 +++----
> >>>  drivers/gpu/drm/radeon/radeon_mode.h          |  6 ++--
> >>>  28 files changed, 93 insertions(+), 93 deletions(-)
> >>>
> >>
> >> <snip>
> >>
> >> Hello Christian, Daniel, David, others,
> >>
> >> Could you re-review v2 since the feedback provided in v0 [1] has now b=
een addressed? I can send v3 with
> >> all other feedback and signoffs from the other maintainers incorporate=
d when I have something for amdgpu
> >> and radeon.
> >
> > This seems like a lot of churn.  Additionally, a bunch of these
> > headers are shared with other OSes, so it's possible some of the
> > changes may end up getting reverted accidently when we sync up or we
> > may add new headers in new code with the old nomenclature and then
> > we'd need to make sure to adjust it to make sure everything was
> > aligned again.  I would just as soon leave things as is, but I'm open
> > to acking them if there is a strong desire to update things.
> >
> > Alex
>
> The way I see it, this is a small downpayment on the debt we have built u=
p so far. Internship
> programs like LF Outreachy to get more underrepresented groups involved i=
n open source are trying to
> change the open source community culture to be more inclusive, but simult=
aneously rely on the culture
> being welcoming enough as well.
>
> I do see the challenge involved in preserving the changes and ensuring no=
 new code is added with
> outdated nomenclature (but see [1]), but culture changes one person at a =
time, and I'd encourage the community
> to do the work needed so we can move past our (mostly) inadvertent role i=
n perpetuating it.
>
> That's my 2c (or your sub-unit currency of choice).

Fair enough.
Acked-by: Aex Deucher <alexander.deucher@amd.com>

>
> Easwar
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co=
mmit/?id=3D49decddd39e5f6132ccd7d9fdc3d7c470b0061bb