Received-SPF: pass (google.com: domain of linux-kernel+bounces-173847-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240311-decode_stacktrace-find_module-improvements-v1-2-8bea42b421aa@bootlin.com>
References: <20240311-decode_stacktrace-find_module-improvements-v1-0-8bea42b421aa@bootlin.com>
 <20240311-decode_stacktrace-find_module-improvements-v1-2-8bea42b421aa@bootlin.com>
From: Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.10
Date: Wed, 8 May 2024 17:37:53 -0400
Message-ID: <CAE-0n51sER+JsJed9406D8D74dh7dnYOykz9NVv1jHb8Pd--EQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] scripts/decode_stacktrace.sh: clarify command line
To: =?UTF-8?Q?Alexis_Lothor=C3=A9?= <alexis.lothore@bootlin.com>, 
	Konstantin Khlebnikov <koct9i@gmail.com>, Luca Ceresoli <luca.ceresoli@bootlin.com>, 
	Sasha Levin <sashal@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Quoting Luca Ceresoli (2024-03-11 08:24:55)
> The syntax as expressed by usage() is not entirely correct: "<modules
> path>" cannot be passed without "<base path>|auto". Additionally human
> reading of this syntax can be subject to misunderstanding due the mixture
> of '|' and '[]'.
>
> Improve readability in various ways:
>  * rewrite using two lines for the two allowed usages
>  * add square brackets around "<vmlinux>" as it is optional when using
>    debuginfod-find
>  * move "<modules path>" to inside the square brackets of the 2nd
>    positional parameter
>  * use underscores instead of spaces in <...> strings
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>