Received-SPF: pass (google.com: domain of linux-kernel+bounces-173930-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <379ba0ed-5c67-4fb8-9738-952289d2f699@amd.com>
Date: Wed, 8 May 2024 18:29:23 -0500
User-Agent: Mozilla Thunderbird
From: "Moger, Babu" <babu.moger@amd.com>
Subject: Re: [RFC PATCH v3 00/17] x86/resctrl : Support AMD Assignable
 Bandwidth Monitoring Counters (ABMC)
Reply-To: babu.moger@amd.com
To: Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
 fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, yanjiewtw@gmail.com,
 kim.phillips@amd.com, lukas.bulwahn@gmail.com, seanjc@google.com,
 jmattson@google.com, leitao@debian.org, jpoimboe@kernel.org,
 rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
 jithu.joseph@intel.com, kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, peternewman@google.com,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <48b595cc-5ffe-4507-bffd-335a60fdaab9@intel.com>
 <2016b830-64c7-43bd-8116-bdfd239221e3@amd.com>
 <ea75801f-e56a-486d-85a4-85c57bce0c81@intel.com>
 <7e92200e-d68c-4dc4-85c3-7192a23f8cbc@amd.com>
 <b8a87fb1-838f-4337-8940-8eb1c5328a2b@intel.com>
Content-Language: en-US
In-Reply-To: <b8a87fb1-838f-4337-8940-8eb1c5328a2b@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WEZpWTQ5Y0FlNVlicW45NnRBeWtCWFltNEI0V2J4aS9YVlVlZGJaaVlYZnJG?=
 =?utf-8?B?MnFlWU9PQlRucXZjWXU3UXVoMEtLK2lIWUJLbENlUCtDckJ1U2RYL0l0WTBr?=
 =?utf-8?B?NXVpY3JDeFMrNnNiZ2JIaUt1SEZhdXFUNVdmSU5XNVJjVWlvTHZ4azVyUkRT?=
 =?utf-8?B?enAzVTk1akpsT3o1MEt4cStEL0FSRGFsY3gvOEsxMlROYlV5RDQwTkNZL1VR?=
 =?utf-8?B?azhKcmJMbGJnUmV2SVhNNG85SjhBaTJKdWNQVFdFdXQ4QjgrSWN2cXltZDhE?=
 =?utf-8?B?R05uTXNnR0g2VzVJVnQzQ21sRmdsb0kveER6WHJ1RmNTTkxpcEk0NWpScVIx?=
 =?utf-8?B?eVd6bnNzTFZSa3hRZWttelkwMWcxWnBITUFMSWRLc2tjUmRSNjc3bHFtaWx6?=
 =?utf-8?B?UmhYRkFxRkc2YkZvYWhMNFd0S2k4WDErMlRvSmVWQS82d1hLa21kS3ZlV2s0?=
 =?utf-8?B?Z3dKbEpwQ1VVZjdGQzlXeFZrZHlWTTlxWGJMS0RuN0YrMFY3OVFoczROQ01O?=
 =?utf-8?B?UUE0MXE3eWFWNzk3NlRJNW1MVCs2clVDbmpuQTJpNUkrNWx2djJYeWlGQXJK?=
 =?utf-8?B?emlOY2hVR285Szd6Z2ZwNElQcVFXS3MrNTRvbWVBQ2YyZVprU1Q4Z2F6WWNG?=
 =?utf-8?B?akJaWXJkY2JGN0tFM3AvbkQzejdpSUwydlVHemlmMStWaWRyQVBLdHptd3NF?=
 =?utf-8?B?b0FFMzExdmFRcGFiREs0cW5lYnlSUnh6eDNmRGVVOExzMDlOOElmTDArRWNU?=
 =?utf-8?B?bEZLTzFjMGtDQ0FtenNGWjk5Vk5RVWp5TXE0ZHc0VjFRN1hOUGcxL01jWUNJ?=
 =?utf-8?B?eFFtUndZQTVUU0xGcGtjQk9kSm9ZcnZTT0dqdUdsOG1EYmpNZ2tnRVY5M1Rs?=
 =?utf-8?B?R3lkUXBYK3h6elhSZW9TdlZ3eS9uSG45Y01kUXByNWJxeUZBZ1hIYVp4SFZV?=
 =?utf-8?B?dXZld3FVZUVTdzgvVzZqeHhmaytRdERvNE9qR0VlYXhEbVRmZWhVM0xqeTVH?=
 =?utf-8?B?RWp4WG80S3NRRThhOWlKUVcwS2FESk9LT1drQk5WYkE0QzRMcFJHUVVjK1B0?=
 =?utf-8?B?M3QwTFZzbUYzWDdKZFJYWGtaa0xqUHJqaVlVMEhsRU9lUlZtNlVaZHMyYStS?=
 =?utf-8?B?UmI3TEVlYTVSK1J0MHpRbnVPWUtBL09rbmVLNGU1eC9pdHFyNktiRENUMUxY?=
 =?utf-8?B?Zk4rd3lxWXNrNW9WU1YvS0x4YVoyeEFHNVRYUUl3bWE4dGJ6ZE0rN1loR3RK?=
 =?utf-8?B?S2tEVEEyU3dOdXBiQk1wNmVaMHZoQ2dRU0dyQmNmakRtTDVuVXFCbVgyb1F1?=
 =?utf-8?B?ZXRrUTFGdFY3ankxcVdzZW1kMjI4TkdwckpmYXFQY2ZETzVBMDBhTTdhV0U1?=
 =?utf-8?B?KzRjc0dMM01oeG5PS2xsd1ZDU2JoUHhTNTY4djlwNGp1Ui9XakJoZ3NVcDJx?=
 =?utf-8?B?RS85cmNza3VqYS83aGlxSHVHcDY3SHlPMHdDei9CL2g4a0ZESjNpL2NudFpW?=
 =?utf-8?B?TXZVWm51Zy9EN1cwazYyYk1pU3RFaVhNSHlJYjJjVW9VdExrcHI2aGY4cFcv?=
 =?utf-8?B?RHNTTUlVZG1HcFc4NHpvVzN1bnVQMkxiTXF6NG9ZRkxMbUVCS2VlV2lKMnph?=
 =?utf-8?B?c1hKaDhtQzAxZWIrb3k1MVNOOVlyMTdGS3NYUmZWbUgyRWFrNXhNNkVoZXZ1?=
 =?utf-8?B?U3FwVHlmMXh4MGUydzkxK2drZTU3L0djLzNlWC91N0MzNldrWWp5T3pxZzRl?=
 =?utf-8?B?WEZwcWRyeThQYnRsT1VlZTlLdkVpUzArbGhGemdFQzVLTk01WWUxL1JqbGs2?=
 =?utf-8?B?WHhYUWdoWWw2YkVOUWJUaEIzSjNnL3JIdDUvL0hhQ0locHI2bXJFOVBvUjRW?=
 =?utf-8?B?ZjMxK1l2Q3RQMHc3NUJXWjZXRU5yOHNBQnZpRktRemZNZXpUdkJ4ODNXLzZF?=
 =?utf-8?B?WURJVzN2amoyeWRWREQ4UURYcDkrZmZYYm9GZ2ZpaUNpOGoyRVFxYUVoTDh2?=
 =?utf-8?B?UCtvK296dGh1Nmh3VmJHSEt6QUN1RzUraEdLR3Ird00xaFY0NEFJQTRMSGVL?=
 =?utf-8?B?TGcyWlNWV2Z2MThsRXprVWxLNG4xTUpXMHpZRkI4UmpyWHlkbDkvN0JFMjN0?=
 =?utf-8?Q?15Rk=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85b54708-505f-41b7-345a-08dc6fb6b412
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 23:29:27.7300
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: abA+dgKdV3EoQR/WduxWRIMPyeuLY/OQabuH/CXe94GB7LnEIL1tSCZmjF8I7ckL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4228

Hi Reinette,

On 5/8/24 15:41, Reinette Chatre wrote:
> Hi Babu,
> 
> On 5/8/2024 1:07 PM, Moger, Babu wrote:
>> Hi Reinette,
>>
>> On 5/7/24 15:26, Reinette Chatre wrote:
>>> Hi Babu,
>>>
>>> On 5/6/2024 10:18 AM, Moger, Babu wrote:
>>>> On 5/3/24 18:24, Reinette Chatre wrote:
>>>>> On 3/28/2024 6:06 PM, Babu Moger wrote:
>>>>>
>>>>>> a. Check if ABMC support is available
>>>>>> 	#mount -t resctrl resctrl /sys/fs/resctrl/
>>>>>>
>>>>>> 	#cat /sys/fs/resctrl/info/L3_MON/mbm_assign
>>>>>> 	[abmc] 
>>>>>> 	legacy_mbm
>>>>>>
>>>>>> 	Linux kernel detected ABMC feature and it is enabled.
>>>>>
>>>>> Please note that this adds the "abmc" feature to the resctrl
>>>>> *filesystem* that supports more architectures than just AMD. Calling the
>>>>> resctrl filesystem feature "abmc" means that (a) AMD needs to be ok with
>>>>> other architectures calling their features that are
>>>>> similar-but-maybe-not-identical-to-AMD-ABMC "abmc", or (b) this needs
>>>>> a new generic name.
>>>>
>>>> It should not a problem if other architecture calling abmc for similar
>>>> feature. But generic name is always better if there is a suggestion.
>>>
>>> "should not a problem" does not instill confidence that AMD is
>>> actually ok with this.
>>
>> The feature "ABMC" has been used in the public document already to refer
>> this feature.
>> https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24594.pdf
> 
> It is clear to me that Assignable Bandwidth Monitoring Counters (ABMC) is the
> name of the AMD feature. The question is whether users can use the 
> same name to interact with "similar but maybe not identical" features from other
> architectures, which is what this series enables.
> 
>> If there comes a conflict then we can change it to amd_abmc. Didn't see
>> any conflict at this pint.
> 
> How do you envision this? The resctrl filesystem interface is intended to be
> architecture neutral so it is not obvious to me how "amd_abmc" is expected
> to look? Why would it be necessary to have different architecture specific names
> for a similar feature from different architectures that users interact with in
> the same way? Sounds to me as though this just needs a new non-AMD marketing name. 

I think I misunderstood it.
It is not a concern to have a same name("abmc") for similar feature across
the architectures.

ABMC is also kind of generic. I am open to other generic suggestions. I
think we should have "assign" and "monitor" words in them.
-- 
Thanks
Babu Moger