Received-SPF: pass (google.com: domain of linux-kernel+bounces-173988-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 8 May 2024 17:56:38 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Tariq Toukan <ttoukan.linux@gmail.com>, Zhu Yanjun
 <zyjzyj2000@gmail.com>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, saeedm@nvidia.com, gal@nvidia.com,
 nalramli@fastly.com, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Leon Romanovsky <leon@kernel.org>, "open
 list:MELLANOX MLX5 core VPI driver" <linux-rdma@vger.kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats
Message-ID: <20240508175638.7b391b7b@kernel.org>
In-Reply-To: <ZjwJmKa6orPm9NHF@LQ3V64L9R2>
References: <20240503022549.49852-1-jdamato@fastly.com>
	<c3f4f1a4-303d-4d57-ae83-ed52e5a08f69@linux.dev>
	<ZjUwT_1SA9tF952c@LQ3V64L9R2>
	<20240503145808.4872fbb2@kernel.org>
	<ZjV5BG8JFGRBoKaz@LQ3V64L9R2>
	<20240503173429.10402325@kernel.org>
	<ZjkbpLRyZ9h0U01_@LQ3V64L9R2>
	<8678e62c-f33b-469c-ac6c-68a060273754@gmail.com>
	<ZjwJmKa6orPm9NHF@LQ3V64L9R2>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 8 May 2024 16:24:08 -0700 Joe Damato wrote:
> > A possible reason for this difference is the queues included in the sum.
> > Our stats are persistent across configuration changes, so they doesn't reset
> > when number of channels changes for example.
> > 
> > We keep stats entries for al ring indices that ever existed. Our driver
> > loops and sums up the stats for all of them, while the stack loops only up
> > to the current netdev->real_num_rx_queues.
> > 
> > Can this explain the diff here?  
> 
> Yes, that was it. Sorry I didn't realize this case. My lab machine runs a
> script to adjust the queue count shortly after booting.
> 
> I disabled that and re-ran:
> 
>   NETIF=eth0 tools/testing/selftests/drivers/net/stats.py
> 
> and all tests pass.

Stating the obvious, perhaps, but in this case we should add the stats
from inactive queues to the base (which when the NIC is down means all
queues).