Received-SPF: pass (google.com: domain of linux-kernel+bounces-174020-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <cf80c2e6ab5aee23c4425419324bca32.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240508-unabashed-cheese-8f645b4f69ba@spud>
References: <20240508-unabashed-cheese-8f645b4f69ba@spud>
Subject: Re: [PATCH v1] clk, reset: microchip: mpfs: fix incorrect preprocessor conditions
From: Stephen Boyd <sboyd@kernel.org>
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, kernel test robot <lkp@intel.com>, Daire McNamara <daire.mcnamara@microchip.com>, linux-kernel@vger.kernel.org
To: Conor Dooley <conor@kernel.org>, linux-clk@vger.kernel.org
Date: Wed, 08 May 2024 18:39:12 -0700
User-Agent: alot/0.10

Quoting Conor Dooley (2024-05-08 14:33:24)
> From: Conor Dooley <conor.dooley@microchip.com>
>=20
> While moving all the reset code in the PolarFire SoC clock driver to the
> reset subsystem, I removed an `#if IS_ENABLED(RESET_CONTROLLER)` from
> the driver and moved it to the header, however this was not the correct
> thing to do. In the driver such a condition over-eagerly provided a
> complete implementation for mpfs_reset_{read,write}() when the reset
> subsystem was enabled without the PolarFire SoC reset driver, but in the
> header it meant that when the subsystem was enabled and the driver was
> not, no implementation for mpfs_reset_controller_register() was
> provided. Fix the condition so that the stub implementation of
> mpfs_reset_controller_register() is used when the reset driver is
> disabled.
>=20
> Fixes: 098c290a490d ("clock, reset: microchip: move all mpfs reset code t=
o the reset subsystem")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202405082259.44DzHvaN-lkp@i=
ntel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202405082200.tBrEs5CZ-lkp@i=
ntel.com/
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---

Applied to clk-next