Received-SPF: pass (google.com: domain of linux-kernel+bounces-174052-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 8 May 2024 19:08:39 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Tariq Toukan <ttoukan.linux@gmail.com>, Zhu Yanjun
 <zyjzyj2000@gmail.com>, linux-kernel@vger.kernel.org,
 netdev@vger.kernel.org, saeedm@nvidia.com, gal@nvidia.com,
 nalramli@fastly.com, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Leon Romanovsky <leon@kernel.org>, "open
 list:MELLANOX MLX5 core VPI driver" <linux-rdma@vger.kernel.org>, Paolo
 Abeni <pabeni@redhat.com>, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net-next 0/1] mlx5: Add netdev-genl queue stats
Message-ID: <20240508190839.16ec4003@kernel.org>
In-Reply-To: <ZjwtoH1K1o0F5k+N@ubuntu>
References: <20240503022549.49852-1-jdamato@fastly.com>
	<c3f4f1a4-303d-4d57-ae83-ed52e5a08f69@linux.dev>
	<ZjUwT_1SA9tF952c@LQ3V64L9R2>
	<20240503145808.4872fbb2@kernel.org>
	<ZjV5BG8JFGRBoKaz@LQ3V64L9R2>
	<20240503173429.10402325@kernel.org>
	<ZjkbpLRyZ9h0U01_@LQ3V64L9R2>
	<8678e62c-f33b-469c-ac6c-68a060273754@gmail.com>
	<ZjwJmKa6orPm9NHF@LQ3V64L9R2>
	<20240508175638.7b391b7b@kernel.org>
	<ZjwtoH1K1o0F5k+N@ubuntu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 9 May 2024 01:57:52 +0000 Joe Damato wrote:
> If I'm following that right and understanding mlx5 (two things I am
> unlikely to do simultaneously), that sounds to me like:
> 
> - mlx5e_get_queue_stats_rx and mlx5e_get_queue_stats_tx check if i <
>   priv->channels.params.num_channels (instead of priv->stats_nch),

Yes, tho, not sure whether the "if i < ...num_channels" is even
necessary, as core already checks against real_num_rx_queues.

>   and when
>   summing mlx5e_sq_stats in the latter function, it's up to
>   priv->channels.params.mqprio.num_tc instead of priv->max_opened_tc.
> 
> - mlx5e_get_base_stats accumulates and outputs stats for everything from
>   priv->channels.params.num_channels to priv->stats_nch, and

I'm not sure num_channels gets set to 0 when device is down so possibly
from "0 if down else ...num_channels" to stats_nch.

>   priv->channels.params.mqprio.num_tc to priv->max_opened_tc... which
>   should cover the inactive queues, I think.
> 
> Just writing that all out to avoid hacking up the wrong thing for the v2
> and to reduce overall noise on the list :)