Received-SPF: pass (google.com: domain of linux-kernel+bounces-174075-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 8 May 2024 23:06:59 -0400
From: Frank Li <Frank.li@nxp.com>
To: Vabhav Sharma <vabhav.sharma@nxp.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Franck LENORMAND <franck.lenormand@nxp.com>,
	Dong Aisheng <aisheng.dong@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	Varun Sethi <V.Sethi@nxp.com>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>, daniel.baluta@nxp.com
Subject: Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree
 bindings
Message-ID: <Zjw9044yBRn9+adW@lizhi-Precision-Tower-5810>
References: <20240509-secvio-v1-0-90fbe2baeda2@nxp.com>
 <20240509-secvio-v1-1-90fbe2baeda2@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240509-secvio-v1-1-90fbe2baeda2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?WCcGYwN8bwRgKqTW3M6o+jb+vPuKUmhdrBYQ/pa3AEXCSfWrxf5sasKsyZUv?=
 =?us-ascii?Q?8W5Md9M3BUs17ptT5toIEw04EFMsyj/pf5I1GQRnduEmqEuioGZbjVDht8eX?=
 =?us-ascii?Q?WDeeM/QD/K4EA4+cG2W0FP+TO8OD4qVn1m9VVUTUbb98xzpRfF8rjMJAEM2R?=
 =?us-ascii?Q?jDoy+Z+Uy47vYj9h8sk+K4MopdFjECHL+vyF2FpM5ZyaM2f1uecai8HT/d3A?=
 =?us-ascii?Q?jPzgJgEGHBFsw0++T9Cq8Kr78YIS3RablBt6py601EXGr32kbaff7tPFlByY?=
 =?us-ascii?Q?TxYZNsaeGH8AO0q4cKyFvJqqRp4iro4w5Zgt/rhwGdlkXoCjmSabrBKO0Yqh?=
 =?us-ascii?Q?k/X19nd4DVDc8s23sseJwsqRieGal6AybYAEeJe8wbwJUTPbqUtnVmcrephJ?=
 =?us-ascii?Q?lTycwgxwcArwoK259Qgea3asiHRh6kl3wHgEdYK1q2j2KaUo4TjGHTGjq/83?=
 =?us-ascii?Q?fINaTPXKzEaJRkCqW9NUeUvAP3vRaiPrefl4jcek2JwKFIfa2+Ofe0zD79+1?=
 =?us-ascii?Q?2ZCt9gdRHafYcHiSdT8mnJbFqwGFc6C/4jV0eg5TIPVfCzjfvf7eN8FR1qQb?=
 =?us-ascii?Q?BAK5Gs8Qy2ftS0i7aWJVks1Skud/bLHQ1K6vwNhXikT/ONeW8PrdZ435JzTW?=
 =?us-ascii?Q?vjfB6UsaCJtJ1O4VNTqtMRYVtV/7RKue/NEBr9FHcWalqB8KvWvOFNIltyoC?=
 =?us-ascii?Q?GXrt7NkY7ihqLov+umO2W0pMcJEXCwxrIUHDNkQNpQUf2fJHNsRuZ6FZDIR3?=
 =?us-ascii?Q?ozYuZ6Ac8YiUEYZclezggTCHe7JtfptA4JjYFKoVgkJ+L8VxUFfOV3cUSlBy?=
 =?us-ascii?Q?X8hkhRF1o+zvPHIdM9AbmMaIl1pSQzElU+Jdx5zTsg2sNXrJLxY8K/SEN0mG?=
 =?us-ascii?Q?s4IewDoM3oXXmI4y+hpkM8CSMZ9R2H2CDrKkNsAo+dpPT8nhM7x27JjpCoko?=
 =?us-ascii?Q?1S3xO8JsBpa05/bUd532Jg+IYo7nFzxVN7XW1OF1bbITIPx7shKDT5WRrLdX?=
 =?us-ascii?Q?jbQz2WMHwUOp+yH5SKq3mXUILYPP/Z65uSv7ZBJ6fO+YN0Mw/hshOGO8tmkT?=
 =?us-ascii?Q?HQuD/SBqSZMaWmuzDZ9ycFObig3rR+AeGJdKm/noNMblJ4zCvLNE6I3lPYrw?=
 =?us-ascii?Q?SahXQC0uR6LK0ZAB9vlBTIEh7zFpbiNdBW4r5r5iUKpSm8mYyQSpjbXKQtWK?=
 =?us-ascii?Q?h7HYElfDCBTTDnBr2YgVOEKRCCcTjId5Bmrfzp/PWpUnkB8lsVO+Eflivz7j?=
 =?us-ascii?Q?L9kh5kSRPRCLQhGNMOSMgvCAD1rzvQvd9UFeZ0RaUQOsH1U0nOjS+UhkZQLm?=
 =?us-ascii?Q?uW1zpHqObv+ZKovovVoRsZW1O5fJzucYx1YRvuQftDOEkfcSUb3lOiw4Zm0v?=
 =?us-ascii?Q?u4wwtcPpvAUCbraLIMQrB4oIGMGe9LvwjOFZ7usd1CgwR8HYujbcwpLX/suq?=
 =?us-ascii?Q?vLOqfjqfjK9+rWNuv5kaHOXYzvV/j3v4+yM3qw1i14f28eq3mzdZG2k4iz0v?=
 =?us-ascii?Q?nl2MxVd0af6tjM/DWeYA/udcCnqias/7RmGO9Ua66vbaks2X6khMWr/6Zzjh?=
 =?us-ascii?Q?Y3LpCDPnl6/CgwGeUwg=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f049977-cf20-4845-24a5-08dc6fd51dc4
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 03:07:09.9183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QEfAf0bxR8THZlzS/3Rl9rwoY1gILpwRpCuM0PlZ+q72TNFsJSj9DSlJY28ajYijwbfBUflFIu/0+mgfIgjwYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7155

On Thu, May 09, 2024 at 02:45:32AM +0200, Vabhav Sharma wrote:
> Document the secvio device tree bindings.

reduntant sentence. 
> 
> The tampers are security feature available on i.MX products and
> managed by SNVS block.The tamper goal is to detect the variation
                        ^^ space here

> of hardware or physical parameters, which can indicate an attack.
> 
> The SNVS, which provides secure non-volatile storage, allows to
> detect some hardware attacks against the SoC.They are connected
                                               ^^ space here 
> to the security-violation ports, which send an alert when an
> out-of-range value is detected.
> 
> The "imx-secvio-sc" module is designed to report security violations
> and tamper triggering via SCU firmware to the user.
> 
> Add the imx-scu secvio sub node and secvio sub node description.
> 
> Signed-off-by: Franck LENORMAND <franck.lenormand@nxp.com>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@nxp.com>
> ---
>  .../bindings/arm/freescale/fsl,scu-secvio.yaml     | 35 ++++++++++++++++++++++
>  .../devicetree/bindings/firmware/fsl,scu.yaml      | 10 +++++++
>  2 files changed, 45 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.yaml
> new file mode 100644
> index 000000000000..30dc1e21f903
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-secvio.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/freescale/fsl,scu-secvio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX Security Violation driver

Violation detect driver

> +
> +maintainers:
> +  - Franck LENORMAND <franck.lenormand@nxp.com>
> +
> +description: |

Needn't "|"

> +  Receive security violation from the SNVS via the SCU firmware. Allow to
> +  register notifier for additional processing
> +
> +properties:
> +  compatible:
> +    enum:
> +      - fsl,imx-sc-secvio
> +
> +  nvmem:
> +    maxItems: 1
> +

any interrupt defined? how do you notify such violation event?

> +required:
> +  - compatible
> +  - nvmem
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    secvio {
> +        compatible = "fsl,imx-sc-secvio";
> +        nvmem = <&ocotp>;
> +    };
> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> index 557e524786c2..b40e127fdc88 100644
> --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> @@ -129,6 +129,11 @@ properties:
>        RTC controller provided by the SCU
>      $ref: /schemas/rtc/fsl,scu-rtc.yaml
>  
> +  secvio:
> +    description:
> +      Receive security violation from the SNVS via the SCU firmware
> +    $ref: /schemas/arm/freescale/fsl,scu-secvio.yaml
> +
>    thermal-sensor:
>      description:
>        Thermal sensor provided by the SCU
> @@ -197,6 +202,11 @@ examples:
>                  compatible = "fsl,imx8qxp-sc-rtc";
>              };
>  
> +            secvio {
> +                compatible = "fsl,imx-sc-secvio";
> +                nvmem = <&ocotp>;
> +            };
> +
>              keys {
>                  compatible = "fsl,imx8qxp-sc-key", "fsl,imx-sc-key";
>                  linux,keycodes = <KEY_POWER>;
> 
> -- 
> 2.25.1
>