Received-SPF: pass (google.com: domain of linux-kernel+bounces-174081-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 9 May 2024 08:42:53 +0530
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Duoming Zhou <duoming@zju.edu.cn>
CC: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-hams@vger.kernel.org>, <pabeni@redhat.com>, <kuba@kernel.org>,
        <edumazet@google.com>, <davem@davemloft.net>, <jreuter@yaina.de>,
        <dan.carpenter@linaro.org>
Subject: Re: [PATCH net v6 1/3] ax25: Use kernel universal linked list to
 implement ax25_dev_list
Message-ID: <20240509031253.GA1077013@maili.marvell.com>
References: <cover.1715219007.git.duoming@zju.edu.cn>
 <d52c1f4dbd6e09769007233aa343010e98c85f0d.1715219007.git.duoming@zju.edu.cn>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d52c1f4dbd6e09769007233aa343010e98c85f0d.1715219007.git.duoming@zju.edu.cn>

On 2024-05-09 at 07:26:12, Duoming Zhou (duoming@zju.edu.cn) wrote:
>  		if (ax25cmp(addr, (const ax25_address *)ax25_dev->dev->dev_addr) == 0) {
>  			res = ax25_dev;
>  			ax25_dev_hold(ax25_dev);
> @@ -52,6 +53,9 @@ void ax25_dev_device_up(struct net_device *dev)
>  {
>  	ax25_dev *ax25_dev;
>
> +	/* Initialized the list for the first entry */
> +	if (!ax25_dev_list.next)
will there be any case where this condition is true ? LIST_HEAD() or list_del() will never
make this condition true.

> +		INIT_LIST_HEAD(&ax25_dev_list);
>  	ax25_dev = kzalloc(sizeof(*ax25_dev), GFP_KERNEL);
>