Received-SPF: pass (google.com: domain of linux-kernel+bounces-174097-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Cristian Marussi <cristian.marussi@arm.com>, "Peng Fan (OSS)"
	<peng.fan@oss.nxp.com>
CC: Sudeep Holla <sudeep.holla@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 0/2] firmware: arm_scmi: add notification completion
 channel
Thread-Topic: [PATCH 0/2] firmware: arm_scmi: add notification completion
 channel
Thread-Index: AQHaoJMB/cXoS4cdSUKMJpx9wox8vLGNkksAgACwkYA=
Date: Thu, 9 May 2024 03:38:42 +0000
Message-ID:
 <DU0PR04MB941788789A3B0DF23995D28488E62@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240507-scmi-notify-v1-0-1fdefc984d53@nxp.com>
 <ZjuwgLZ1Sh5jRBWn@pluto>
In-Reply-To: <ZjuwgLZ1Sh5jRBWn@pluto>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?/nhMLYzIMVoKHpe9j4MnUWZ2b2NUuO/VOqLQrxJEP3n0quahHs8h4NFn3YKn?=
 =?us-ascii?Q?luD6jZmv4JPQTlywv9rbUpqwL11vaL64QqF2R99q9KY6GCZo0nzIrr5mJDbk?=
 =?us-ascii?Q?MZUsE1WOoR6gBKL19EZmTM0mb45fWv5+rSKdqcht3Qlwalm6ESyGFWURzVMu?=
 =?us-ascii?Q?5GjR7aVxlnyItM/4D0rInsqgASZomQG+7Z1OJshViIdzzmfktVLXnjgGrpCK?=
 =?us-ascii?Q?vMV96qDo/7OaNkfDr7ISn5S0602wQdCJwvWb2B5DfpgbAe800JWjzacQQVgk?=
 =?us-ascii?Q?dKEbbWJcvzlIXBvaB6wpFyZJ8si0vnJMHGcbCI//pYA/C98AG2vOailEJFDq?=
 =?us-ascii?Q?0ww1QytXtwKs3Ad5KShubS76wgRhwX7He8BCtuyNFQLO1Z7QqQKVvO02zzoc?=
 =?us-ascii?Q?2bWa4Cy+uE0V1xQz74qlIQfPFLCjqXO3lqxrjLGIQlTWfbNs851sUXfDAIb5?=
 =?us-ascii?Q?h4KbntQXVDjQkY4WUI1UtA7OfNqeIwAPUx/9adJk2c23LpRDBY1wQuPBfzkE?=
 =?us-ascii?Q?D4QywMUWYHB78ew7I+c2f+offrVoxlTmIMaHbuSMWLCB2woPe1DFlMgdLNFA?=
 =?us-ascii?Q?MLG8ZYl/AK/vRJGLgbM8KNWH/wktc2K5dWfW+Z4HqeVbapNUGObpev6Rcz4F?=
 =?us-ascii?Q?fHS2duQgkpgxOnxLiKA8HRH44svL1EXzeol/4JumZ3QegfZoW5WxpOXL3+ki?=
 =?us-ascii?Q?OJv6wSQe0tpNci3hWD3A90XZgDRfAVxIsfCaEb920Kap+dUBHcPLFLLbiLO3?=
 =?us-ascii?Q?qtconVez5MoRkKEwl7Tli4hnKTDVmUvKAm1MuvYDJqj9657UwQj6qqV4n0Pi?=
 =?us-ascii?Q?CtmpxLO9m7C1LgxXIC3CSryvdYo9Qv+RVcgrULsiEx43Ae+gM/fmuq17BNqB?=
 =?us-ascii?Q?8OvUQ/kbxIEFRNVxY1zTvqgHcUY8kJHgFDGLg0L3dk1WZeOIlk3lFmebiFpO?=
 =?us-ascii?Q?icY7mv3M8pq0jc5j79GeuGa2D5LTCWh4S0DmZM9n6wwOzQdXLl/S92DDYwga?=
 =?us-ascii?Q?U3TFXgXWRcP1XPd5LT9pqXJtEgWyu1BLBCXRN3mnS7ay7tqDczUxQIozxrS9?=
 =?us-ascii?Q?VKkHeZjkox2Y+vU7aLPH34LVUSoZzkKHcosqciyV+5VaPLVzI9lwVyjz6zGK?=
 =?us-ascii?Q?H+VphWgqKJjZP9Lw7YnV4x+90ledcu+elKzHPVLxb8ktJnVA41uZT5VnJliL?=
 =?us-ascii?Q?hS7xRf6jrJk6MlwDNCPoiy2BXO1m5UJqgN3weuoWF5fX76HVzvo0Jygpbypt?=
 =?us-ascii?Q?oyAQLI833EWa5t3J7Va69W2Tv7lHzySWQn7bVfCzyH9p1MQUXtWzhJjyrrBV?=
 =?us-ascii?Q?y5Y/je6aw7AKd1+OPEso0L6uYyARezskB8ZR3Pf/tUNYTwG/ySnE+cEHkxdf?=
 =?us-ascii?Q?AmOgubqM8DpeM9U/aIr2otWS3DGm62LZeJhF//iydY58P8jRT/gb6Jd/Y/S6?=
 =?us-ascii?Q?Lfqr2bHSTIzwU4LPgV9HV9/LOSymBvB3Mcms+T5iZZCNYL58x3WVemPLaSgj?=
 =?us-ascii?Q?wkAYUmaDs962wn5i9a3MswYWq4KBLD3gCy0j6+/blJBafoNjQuDOUgE0iHwC?=
 =?us-ascii?Q?Iwas01Vtc6whtSGeglA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b542c4e3-124d-4749-65f8-08dc6fd985e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 May 2024 03:38:42.3896
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /Tw1LtevUk0QWhTiOnXUk74n2TRvUFYnfnGmqF1YH57008kILmVXxa0V7Aly5tCLREx7trpR/d4D2YNjymrqSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7154

Hi Cristian,

> Subject: Re: [PATCH 0/2] firmware: arm_scmi: add notification completion
> channel
>=20
> On Tue, May 07, 2024 at 11:34:59PM +0800, Peng Fan (OSS) wrote:
> > Per spec:
>=20
> Hi Peng,
>=20
> thanks for doing this.
>=20
> > Completion interrupts This transport supports polling or interrupt
> > driven modes of communication. In interrupt mode, when the callee
> > completes processing a message, it raises an interrupt to the caller.
> > Hardware support for completion interrupts is optional.
> >
> > i.MX95 SCMI firmware is fully interrupt driven, so Platform expects
> > completion interrupt for Platform to Agent(P2A) notifictions.
> >
> > Add another optional mailbox channel for Agent to notify Platform that
> > notification message has been accepted
> >
> > After notification channel status become freed, Agent will use the new
> > mailbox channel to send completion interrupt to Platform.
> >
> > Add shmem_channel_intr_enabled to check channel flags.
>=20
> Glancing through the series I think the bindings and the code are quite g=
ood
> and sensible to achieve the addition of the optional P2A completion inter=
rupt.
>=20
> Your current solution, though, addresses only the case of a mailbox contr=
oller
> providing unidirectional channels. (which I suppose is the one you are us=
ing
> on your platform)

Right. i.MX95 use unidirectional channels.

>=20
> We should take care to add such optional P2A completion interrupt support
> also for the case of mailboxes sporting bidirectional channels.
>=20
> For bidirectional channels we really have already the needed bindings...
> ...no changes there...you have just to also ring the doorbell on that sam=
e P2A
> if completion IRQs are requested.
>=20
> IOW, when the DT description is made by 2 mboxes + 2 shmem, means we
> have both A2P and P2A provided via bidirectional channels...we currently =
just
> use the P2A (RX) channel to receive notifs/dresp via rx_callback (so usin=
g only
> the platform_to_agent direction)...now we should also ring the P2A doorbe=
ll
> on the existing P2A channel if the FLAG_INTR_ENABLED is set to signal the
> completion interrupt on the other direction (agent_to_platform)
>=20
> Not sure if I have been clear or make it worst with my explanation :P

Thanks for detailed explanation, it is clear enough. I will update to suppo=
rt
bidirectional channel in V2.

Thanks,
Peng.
>=20
> Thanks,
> Cristian