Received-SPF: pass (google.com: domain of linux-kernel+bounces-174137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 9 May 2024 06:50:48 +0200
From: Mark Brown <broonie@kernel.org>
To: Chen-Yu Tsai <wens@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
	Andre Przywara <andre.przywara@arm.com>,
	Chen-Yu Tsai <wens@csie.org>
Subject: Re: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs
 driver
Message-ID: <ZjxWKOoLMNQAmhla@finisterre.sirena.org.uk>
References: <20240507041343.272569-1-wens@kernel.org>
 <20240507041343.272569-3-wens@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="g1RsFHX7V6ArnC2e"
Content-Disposition: inline
In-Reply-To: <20240507041343.272569-3-wens@kernel.org>


--g1RsFHX7V6ArnC2e
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 07, 2024 at 12:13:43PM +0800, Chen-Yu Tsai wrote:
> From: Samuel Holland <samuel@sholland.org>
>=20
> D1 contains two pairs of LDOs, "analog" LDOs and "system" LDOs. They are
> similar and can share a driver, but only the system LDOs have a DT
> binding defined so far.

This doesn't build on at least multi_v5_defconfig, multi_v7_defconfig
and arm64 defconfig:

/build/stage/linux/drivers/regulator/sun20i-regulator.c: In function =E2=80=
=98sun20i_reg
ulator_probe=E2=80=99:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:16: error: impl=
icit=20
declaration of function =E2=80=98of_device_get_match_data=E2=80=99 [-Werror=
=3Dimplicit-function-de
claration]
  111 |         data =3D of_device_get_match_data(dev);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:111:14: warning: as=
signm
ent to =E2=80=98const struct sun20i_regulator_data *=E2=80=99 from =E2=80=
=98int=E2=80=99 makes pointer from inte
ger without a cast [-Wint-conversion]
  111 |         data =3D of_device_get_match_data(dev);
      |              ^
/build/stage/linux/drivers/regulator/sun20i-regulator.c: At top level:
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: error: arra=
y typ
e has incomplete element type =E2=80=98struct of_device_id=E2=80=99
  136 | static const struct of_device_id sun20i_regulator_of_match[] =3D {
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: warning: =
=E2=80=98sun20i
_regulator_of_match=E2=80=99 defined but not used [-Wunused-variable]

--g1RsFHX7V6ArnC2e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY8ViUACgkQJNaLcl1U
h9DVRwf/W0u/DsfRiOg544BQO14Ruk6H0o+gXYE8qd5+KA124vKjN3tCXj3M5dfX
wMKDwWXD4MmMHCDdyaQO+ZvlUojvktKtVJTsTmesOXeV6oX1KFgKPd/lVWnI3Hkb
gSBz3iTePYx0olIQFKi0RWvqn2ykvEfKdGMxFiXexCeCKvx59eVf+Prr35cpNvXr
QD57BzTpmHkA0X5zMJayU04imi/IwLoTSCfZFWkfdk4WqeEOaV/VwSpdZ0ZEpKe6
cFsWgmSxIT3SaqPJfHcUAKS9btPLY4pzF2j/4pqS6HUILVLPjULh/0vPiNLF9JOq
E1OYXyruAQ+pa70o/cnO1OkVRec/8g==
=f3+H
-----END PGP SIGNATURE-----

--g1RsFHX7V6ArnC2e--