Received-SPF: pass (google.com: domain of linux-kernel+bounces-174149-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 9 May 2024 07:15:21 +0200
From: Oleksij Rempel <o.rempel@pengutronix.de>
To: Arun.Ramadoss@microchip.com
Cc: andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net,
	Woojung.Huh@microchip.com, pabeni@redhat.com, edumazet@google.com,
	f.fainelli@gmail.com, kuba@kernel.org, kernel@pengutronix.de,
	dsahern@kernel.org, san@skov.dk, willemb@google.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	horms@kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 3/3] net: dsa: microchip: dcb: set default
 apptrust to PCP only
Message-ID: <Zjxb6a_MaSxjTQxU@pengutronix.de>
References: <20240508103902.4134098-1-o.rempel@pengutronix.de>
 <20240508103902.4134098-4-o.rempel@pengutronix.de>
 <d4f7d3be15d46b07d7139ee4d453d7366d7aedc3.camel@microchip.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d4f7d3be15d46b07d7139ee4d453d7366d7aedc3.camel@microchip.com>

Hi Arun,

On Wed, May 08, 2024 at 03:11:24PM +0000, Arun.Ramadoss@microchip.com wrote:
> Hi Oleksij,
> 
> On Wed, 2024-05-08 at 12:39 +0200, Oleksij Rempel wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> > 
> > 
> > -static const u8 ksz8_port2_supported_apptrust[] = {
> > -       DCB_APP_SEL_PCP,
> > -};
> > -
> >  static const char * const ksz_supported_apptrust_variants[] = {
> >         "empty", "dscp", "pcp", "dscp pcp"
> >  };
> > @@ -771,9 +767,8 @@ int ksz_port_get_apptrust(struct dsa_switch *ds,
> > int port, u8 *sel, int *nsel)
> >   */
> >  int ksz_dcb_init_port(struct ksz_device *dev, int port)
> >  {
> > -       const u8 *sel;
> > +       const u8 ksz_default_apptrust[] = { DCB_APP_SEL_PCP };
> >         int ret, ipm;
> > -       int sel_len;
> > 
> >         if (is_ksz8(dev)) {
> >                 ipm = ieee8021q_tt_to_tc(IEEE8021Q_TT_BE,
> > @@ -789,18 +784,8 @@ int ksz_dcb_init_port(struct ksz_device *dev,
> > int port)
> >         if (ret)
> >                 return ret;
> > 
> > -       if (ksz_is_ksz88x3(dev) && port == KSZ_PORT_2) {
> > -               /* KSZ88x3 devices do not support DSCP classification
> > on
> > -                * "Port 2.
> > -                */
> > -               sel = ksz8_port2_supported_apptrust;
> > -               sel_len = ARRAY_SIZE(ksz8_port2_supported_apptrust);
> 
> If we remove this, How the user application knows about the DSCP
> resistriction of KSZ8 port 2. Is it implemented in other functions?

Yes, it is implemented in
ksz_port_set_apptrust()->ksz88x3_port_apptrust_quirk(). This patch
affects only default configuration.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |