Received-SPF: pass (google.com: domain of linux-kernel+bounces-174144-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <91a904c3-fe6c-2e0f-0af9-6c687ce45c4e@amd.com>
Date: Thu, 9 May 2024 10:39:11 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [RFC 0/4] perf sched: Introduce schedstat tool
To: Ian Rogers <irogers@google.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
 namhyung@kernel.org, swapnil.sapkal@amd.com, mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com, jolsa@kernel.org, rostedt@goodmis.org,
 vincent.guittot@linaro.org, bristot@redhat.com, adrian.hunter@intel.com,
 james.clark@arm.com, kan.liang@linux.intel.com, gautham.shenoy@amd.com,
 kprateek.nayak@amd.com, juri.lelli@redhat.com, yangjihong@bytedance.com,
 linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
 santosh.shukla@amd.com, ananth.narayan@amd.com, sandipan.das@amd.com,
 Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240508060427.417-1-ravi.bangoria@amd.com>
 <CAP-5=fX1r2RA1=2Bs4DmMGjrV0VD-kYGMCtt+E530rVihK+MxQ@mail.gmail.com>
Content-Language: en-US
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAP-5=fX1r2RA1=2Bs4DmMGjrV0VD-kYGMCtt+E530rVihK+MxQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YUlNeE1WVWh3MmQzLzVtZ0E3dzFMNHJYcWxFVWtCc2Z4aFI3VWVPKy9Pczk1?=
 =?utf-8?B?YTIvMVpNY1ZrczVWdmdPV1hCd25WMFpvVE40OHlMZkZ2VlhQK0VKVVphOGc2?=
 =?utf-8?B?dlV3eW5Sdmc1SXRXT3pPOUFZUFE5SnpUMm1kT2RmQ2N6MWRSaFRId3ZsTTZo?=
 =?utf-8?B?WS9WcDIwbGg5YnJEMWRqRjVkNGYxWTN1V1VDOU1vVCszd0E2b1BzZHpxTS8r?=
 =?utf-8?B?MXQyY3B3bTk5UlNnb1YyYzdoOTNtYUJOeThSQjcxZCtxckE5aDNMaHRQQjZL?=
 =?utf-8?B?dFFOakJvYURDQk5rM3ExZmhZSmxoeVplbFhJNE55SVNQNS9LcWNBdUF4SzJ1?=
 =?utf-8?B?a05PbmlMRGJEMlJ4VHN5bEdKcGtRSDhPNlEwQW1wVHEzMUlIQUlucGVETExK?=
 =?utf-8?B?RlBjSWdCOWwvbFpLdElVcHpKUFQreGwzd1g5bnFtWnowczdjOTJGbjdPbnRG?=
 =?utf-8?B?ZnJJZlZkUmZGRGRFdXVKc3E3YnRjYW9VU3R5bzJDc3UrQzhaQXNoVlh1VXpk?=
 =?utf-8?B?WTF6aVFGZVF0d0xSeXlOZTR6L2FNOHZHRVE5ejk4UElFUmZwV1FUK2RTUjIw?=
 =?utf-8?B?NS9odjBsc0lCTDd0VVZrWXJLYkZPSmR5SHpUSWpKYTFtMmwzb2FoMTlETHZ1?=
 =?utf-8?B?akJjdTcyUmhOSzhZaklwVXdrTXlHd0JqaFltU3AyREJodkFROWdJdlhKMDJ3?=
 =?utf-8?B?NmhjNjZlanpPUlhyeWx3RURZZUhxS2E3UlhxbW5iOTMzNmM1U1VtNnBmbnho?=
 =?utf-8?B?MGZIYndFSnBUeFREUmJhWTZ5di91WXMxNU4yMjlCTm13TGtLUHM2SzUrbTMw?=
 =?utf-8?B?SjlxQjNTdS9OemRoK2czb2QwdjA1ejFkbTduaDgvRjQvNjNpOWdQSnZyN2Ew?=
 =?utf-8?B?QnViL05saFI4MnZrY0UvV0owcFE5NjlBRkZCeTRMMkZ2SndJYUtTYnFockdW?=
 =?utf-8?B?RTRydWo5bk56TmZzdGJNZHo3Wkhxei9MZzZqV2gyUHVMcjVlZjEyMFp1R2Vx?=
 =?utf-8?B?a0RKNnpER0p3RW55anUyeFZ5OUQ3UXVsYUhEdkY1a1JHNGQrWTJCTFAzNEpj?=
 =?utf-8?B?Y2x4L0puclZ0WmpRYWphY0laQWpMQzQzUHpTMWN3Y2RNNzZSc2J5eDRaZTJU?=
 =?utf-8?B?VTF6YWlKcmZjRjh2Y2cyTnNld0ZhK3lWSkR5LzVpTXAvTUZXYTFkbUVaaFly?=
 =?utf-8?B?S2YzUUhna3RTc0NsK254MDBDbGVqK1hiSElJb2tSR1RlVmJGSHMvR0xqY1FL?=
 =?utf-8?B?WGtPT3h5ZUdsNGl2amdnMlpIOXBCM0ZHZmsvUUI4ck00bmlBYVFHQ2IzMUN6?=
 =?utf-8?B?aktIT2haRGRlbndGUFFzdHhJSG9QTFVjNW5wWEtTYVQrZk5kMDlvSmhLUzNM?=
 =?utf-8?B?VUlFREp3UnlkTVRhVDRoSGpqaWcxeDMrb2lFQmxnNFZwWUFCYzNnVzF5alhN?=
 =?utf-8?B?Z2I3d3B4a3VyYkFsQXpvMmJ4Nkl2QlVYUFF5bDYrc1VMR04zZHRVOXBOaXE5?=
 =?utf-8?B?V3dnU0grd3V2aVVjNUpwNmdaQVlYZ1pHRGNZQnh5Qlc0ODFHc3k5U1pCRVBt?=
 =?utf-8?B?TGVUQXVxU2g3WSs3Ry96a3piam45UnpCV0NKbDdVZGJEcS9Kc2RxNmhuRkJH?=
 =?utf-8?B?YUIxQ2pqZ3pxZU5hdXpDOFFHd3hMMW4rYko2cEJIRkorRHEzK0xkcnJObE9y?=
 =?utf-8?B?R1pqQnN2cE5LRWU5REJQci8ycjNOR2pTQ3RGZFZ5VG1MOHR6T1QrK0Nib3li?=
 =?utf-8?B?SlpzTnBGSzJhOWNvNzVYK01EYnJBOStRakxhWDBMMjd6V3VUQjZtVkJlckhZ?=
 =?utf-8?B?SHFON1hacVo4RVdKcW5lNlJyUmREVFltVEFKcGFrTm9jSXduUXBuVWE3bEli?=
 =?utf-8?B?aWdQNlE4NEd6dDRYUllITC9US1BFMVhmdGNGWHU5RHZoWTlNMlpVK0tJZ01v?=
 =?utf-8?B?Y0k5WjJGQzhGY3cwQTFmVGdVUjRVRXpRWmwycVVhMkpXK1Z1M3lsTkdSYXUz?=
 =?utf-8?B?bkRLNytsSkgzZGE2cHVPT1p3U2xmbnJVWjNLZ3Z2Tk1WMEF2UUI0d1h5TGdG?=
 =?utf-8?B?cHJML21XNXFlU1lZbDdmZ1k3VnQvOTFUZmFScFJWZUx3UVlmVk1OUnQrL1lC?=
 =?utf-8?Q?lLtZ5XS/V4P4rDIQf7UqmTeD4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8ca70a1-d2dd-4069-bbbd-08dc6fe632de
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 05:09:26.7486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E30L8wZvX4w2yX79YgpB5IDbV6GnpJyWPGte3Dxn2s8VlWHuP7PfxlrRIGWZyZzuknGtuX/llyKrX/NR5Aup8Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6758

>> TODO:
>>  - This RFC series supports v15 layout of /proc/schedstat but v16 layout
>>    is already being pushed upstream. We are planning to include v16 as
>>    well in the next revision.
>>  - Currently schedstat tool provides statistics of only one run but we
>>    are planning to add `perf sched schedstat diff` which can compare
>>    the data of two different runs (possibly good and bad) and highlight
>>    where scheduler decisions are impacting workload performance.
>>  - perf sched schedstat records /proc/schedstat which is a cpu and domain
>>    level scheduler statistic. We are planning to add taskstat tool which
>>    reads task stats from procfs and generate scheduler statistic report
>>    at task granularity. this will probably a standalone tool, something
>>    like `perf sched taskstat record/report`.
>>  - /proc/schedstat shows cpumask in domain line to indicate a group of
>>    cpus that belong to the domain. Since we are not using domain<->cpumask
>>    data anywhere, we are not capturing it as part of perf sample. But we
>>    are planning to include it in the next revision.
>>  - We have tested the patch only on AMD machines, not on other platforms.
> 
> This is great! Is it possible to add some basic shell script testing:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tree/tools/perf/tests/shell?h=perf-tools-next
> for the sake of coverage, other platform testing, etc. ?

Sure, I will think about adding some simple tests.

Thanks,
Ravi