Received-SPF: pass (google.com: domain of linux-kernel+bounces-174205-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <ZjpBnkL2wO3QJa5W@x1>
In-Reply-To: <ZjpBnkL2wO3QJa5W@x1>
From: Ian Rogers <irogers@google.com>
Date: Wed, 8 May 2024 23:43:15 -0700
Message-ID: <CAP-5=fX3c60v=7dt+Nryd5KqvKMU8EXz-jJAvJ=p=S_N6hJjUw@mail.gmail.com>
Subject: Re: [PATCH 1/1] perf probe: Use zfree() to avoid possibly accessing
 dangling pointers
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Kan Liang <kan.liang@linux.intel.com>, Namhyung Kim <namhyung@kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 7, 2024 at 7:58=E2=80=AFAM Arnaldo Carvalho de Melo <acme@kerne=
l.org> wrote:
>
> When freeing a->b it is good practice to set a->b to NULL using
> zfree(&a->b) so that when we have a bug where a reference to a freed 'a'
> pointer is kept somewhere, we can more quickly cause a segfault if some
> code tries to use a->b.
>
> Convert one such case in the 'perf probe' codebase.
>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ian Rogers <irogers@google.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Kan Liang <kan.liang@linux.intel.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/builtin-probe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
> index 019fef8da6a8e60f..003a3bcebfdfc2d1 100644
> --- a/tools/perf/builtin-probe.c
> +++ b/tools/perf/builtin-probe.c
> @@ -325,7 +325,7 @@ static void cleanup_params(void)
>         for (i =3D 0; i < params->nevents; i++)
>                 clear_perf_probe_event(params->events + i);
>         line_range__clear(&params->line_range);
> -       free(params->target);
> +       zfree(&params->target);
>         strfilter__delete(params->filter);
>         nsinfo__put(params->nsi);
>         zfree(&params);

The change is fine but params is freed here, so the potential to read
"->target" is small.

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> --
> 2.44.0
>