Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp976051lqo; Thu, 9 May 2024 00:31:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWGuZzbvlIUkcWk8AIDzJbArEn8//5/BkBv9MXl55XkyrMjU7xnDVnpvLkf7l4OBMW6IjFMBKfPev/iWd72bOY+XfJ/fjHkZvPBcd5g9g== X-Google-Smtp-Source: AGHT+IFw66fG1zjn8FD4RfxVm2ONN3FSUv41eT7q/QT3s3g8mRoHB+mdLYDKlhUQCeWxZ9M/HCZQ X-Received: by 2002:a05:6a20:dda3:b0:1a9:22cc:3ed4 with SMTP id adf61e73a8af0-1afc8d05d82mr5145911637.6.1715239904430; Thu, 09 May 2024 00:31:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715239904; cv=pass; d=google.com; s=arc-20160816; b=lir76/aFi/38yNeuVLm2D2qo2KOGpnj/q6YtUZf/4ox4e4URC5VMfe2W+cW2kpX10k MMb9enY0xn7lbKbuqvfJTmIEAyw2EE7PmsuRSqA4ch1MGg+poktz26r9Xz7YOJk9519+ 25xvBhajiMz/IFY3BEUfclqTsrX3qYPfugA3Z4b4nEN9fX4fSRsjSZ2+r25iqzf2NUnh fH4yUhSW2/oBBf5KjJScA0eMJ3faFcukH9CvxoxrnlMCaoOp731tNH09uQKXZ3T++2vT G4KpL4f5bE0u1w7tdwXXGjVlKjSLpkwmjteB9QDlmddBG8eG7V/NM7EyTIUbUm4ScR+J u7mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=yFIJqrgUYRufZO44ifi0BeHH43Pj5mRVkX8VaE4POmU=; fh=1rO51bnstyagnJVxos5CWnujEq1EYPnQgQFwHhpozjQ=; b=UcikXdglAvVzX7q3XdMmCBFaEcWdnLisdMAzOe3VFRjnE+G7jUqJw9x3HROpMgfvn9 JJNhtpTFrIFIwY13Il86xwEpc7jeSUmLRVv8RYeOsaicqpDW59pyOkqr7cUuW1AT5Vbl MzPTmR6CIC6Qn+Hr3p5DOgDwgorZPtI4WWGyGQSkarPa0nGRpOHUO9tXLEs5cPv1vtS8 CQLPEUV/4VtYE31RX237nBijziz77iN6uJswBUM5KD2Cj2QmldFRpvGA62hZwp70kWF3 ZHuBee/niyLQuQ6aTX1dsuoAfHCdizi3jf8PksRQc0m6aGi365V2FjzcglZU/vNWW54E lgow==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Lr/LXdoM"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-174234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174234-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4d2b41c0bsi914108b3a.341.2024.05.09.00.31.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 00:31:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Lr/LXdoM"; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-174234-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174234-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 16475284CAD for ; Thu, 9 May 2024 07:31:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A7C7C13C90A; Thu, 9 May 2024 07:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Lr/LXdoM" Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59E3113C830 for ; Thu, 9 May 2024 07:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715239897; cv=none; b=T45JPjuQqHaer9baxeqVJaYunTnaBLjETGr36V5/JRBdDu6oyaCe3FNpKalh+9IKlsni0uJsBQO51V707nfbOqQHMtQjSnZLF+MuDWMXI4cV7vw1zYPXcmTxQjDhcN70CUf7RnoTJ7ie2kpYhCBVZ6ZLZ1xb6RSOJAg8mfY7cCw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715239897; c=relaxed/simple; bh=hKlzg7n2M91QHuHzIH/i/jIkyPsZmX7wBR+g4EMToUY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=BxFHS3tZ5luKk3P4o8cKkgxwBL30Z44C52dgdBiXlb6PhYp7KdFah9G7wKvtHxbkModmEIZLAUJobxDAcSsx62TXDNKFu3oy5aCcJu0o2OIwWqfSf7W4SXhyUTP2QuZfdnALACoSrvABgEYgk9U/HOSaVM+3cISigkVXhDZZyzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Lr/LXdoM; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5b2733389f9so138979eaf.1 for ; Thu, 09 May 2024 00:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715239895; x=1715844695; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=yFIJqrgUYRufZO44ifi0BeHH43Pj5mRVkX8VaE4POmU=; b=Lr/LXdoMbExDeLTbSKvH0ycJjU5V9bM7H0nFJRN5U0jfbF8CvKMGkociBxhie2YERj yOvmCYLeI3vRMQ7CUU13LEA6Nt0kknsMkdeHvpjtpeCJ0bHz0ioyopVD4dePZpCptJ5w tYaT0UsBg/NnC13AwQTy+N4vZ3sgb58gauj40= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715239895; x=1715844695; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yFIJqrgUYRufZO44ifi0BeHH43Pj5mRVkX8VaE4POmU=; b=C0AjWf7U1deYcl/1mCQly2/46WD8fwHgKjPGD+RRIM19rsedkVOivptqann1qFy058 bEl12x/5x7+dIOBVZoQtEIXXt38EAMWIb6smrvlkeEr9EfN2bflWy3sCScWWuDaHVjF2 wIE3TFrZCY228Iy/VCgzShCneqwnUKxJ/QcVM1FA9bQ5shmTyxXJxTos1K06Y0R4z6oU kXNAQrHyHUVjcs8MiIYMgQQESgpXwzhAgYaoIF6LX9d/z99EX9fjnDkpdAGJ1gSxVFn/ 4cqtbfJcBGy4eHfywQu5U24XUdm18Ok+v5OszHf0tIwKfTrD/wDOtWpaAnQHwZy83pSv SKTg== X-Forwarded-Encrypted: i=1; AJvYcCWOtpnqlMK/te4hI9aMSfUCLVaf8gvYItlPA297lhytTnDvOl3KmSV7Vj7xlfBtaczqqgb6nNUj/Y3tNIiAbTpAWoT0MwSIdN504fYh X-Gm-Message-State: AOJu0Ywfhi/4RZg0dVpRWQtZRGLXw/7nZ5tvW1RYwl2evgNxKQHmfyyB IJW2XDE/KJyMsxigs2ZdVZpp/iAHgcKMih3lHUfDquktF9OOYnSxfiQP0QyPOQ== X-Received: by 2002:a05:6358:54a2:b0:18e:a0ce:a35c with SMTP id e5c5f4694b2df-192d2c2b383mr578760355d.14.1715239895370; Thu, 09 May 2024 00:31:35 -0700 (PDT) Received: from yuanhsinte1.c.googlers.com (150.221.124.34.bc.googleusercontent.com. [34.124.221.150]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-63411346d46sm586459a12.79.2024.05.09.00.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 00:31:34 -0700 (PDT) From: Hsin-Te Yuan Date: Thu, 09 May 2024 07:31:29 +0000 Subject: [PATCH] ASoC: mediatek: mt8192: fix register configuration for tdm Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240509-8192-tdm-v1-1-530b54645763@chromium.org> X-B4-Tracking: v=1; b=H4sIANB7PGYC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIxMDUwNLXQtDSyPdkpRc3eSkNKNEc+Nky5QUYyWg8oKi1LTMCrBR0bG1tQD PHd/7WgAAAA== To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Matthias Brugger , AngeloGioacchino Del Regno , Jiaxin Yu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hsin-Te Yuan X-Mailer: b4 0.12.4 For DSP_A, data is a BCK cycle behind LRCK trigger edge. For DSP_B, this delay doesn't exist. Fix the delay configuration to match the standard. Fixes: 52fcd65414abfc ("ASoC: mediatek: mt8192: support tdm in platform driver") Signed-off-by: Hsin-Te Yuan --- sound/soc/mediatek/mt8192/mt8192-dai-tdm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c b/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c index 9ce06821c7d0f..49440db370af0 100644 --- a/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c +++ b/sound/soc/mediatek/mt8192/mt8192-dai-tdm.c @@ -566,10 +566,10 @@ static int mtk_dai_tdm_hw_params(struct snd_pcm_substream *substream, tdm_con |= 1 << DELAY_DATA_SFT; tdm_con |= get_tdm_lrck_width(format) << LRCK_TDM_WIDTH_SFT; } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_A) { - tdm_con |= 0 << DELAY_DATA_SFT; + tdm_con |= 1 << DELAY_DATA_SFT; tdm_con |= 0 << LRCK_TDM_WIDTH_SFT; } else if (tdm_priv->tdm_out_mode == TDM_OUT_DSP_B) { - tdm_con |= 1 << DELAY_DATA_SFT; + tdm_con |= 0 << DELAY_DATA_SFT; tdm_con |= 0 << LRCK_TDM_WIDTH_SFT; } --- base-commit: 45db3ab70092637967967bfd8e6144017638563c change-id: 20240509-8192-tdm-cbf2a73c9dd3 Best regards, -- Hsin-Te Yuan