Received-SPF: pass (google.com: domain of linux-kernel+bounces-174246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <bd4799ab-9456-421a-8294-de6481543ad1@enneenne.com>
Date: Thu, 9 May 2024 09:41:45 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] pps: clients: gpio: Convert to platform remove callback
 returning void
To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
References: <f4b9402af72e5f285c8b0f068076a76418f653f5.1709886922.git.u.kleine-koenig@pengutronix.de>
 <6d73b0a4-34e6-44ce-8757-4f4931c3da85@enneenne.com>
 <4iii7uxyfovs6ntm7hs2w546k3upbhkepgzxarjk4wnlqmeern@sh6gkyuiqpjs>
 <v7sefhmq42ro2dfpxgipxxajxpuh3xy46c77uibmypyp34duqs@5vw5ava4ns7d>
From: Rodolfo Giometti <giometti@enneenne.com>
Content-Language: en-US
In-Reply-To: <v7sefhmq42ro2dfpxgipxxajxpuh3xy46c77uibmypyp34duqs@5vw5ava4ns7d>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 08/05/24 15:57, Uwe Kleine-König wrote:
> On Fri, Apr 12, 2024 at 02:26:48PM +0200, Uwe Kleine-König wrote:
>> [Cc: += linuxpps@ml.enneenne.com]
>>
>> On Fri, Mar 08, 2024 at 09:57:29AM +0100, Rodolfo Giometti wrote:
>>> On 08/03/24 09:51, Uwe Kleine-König wrote:
>>>> The .remove() callback for a platform driver returns an int which makes
>>>> many driver authors wrongly assume it's possible to do error handling by
>>>> returning an error code. However the value returned is ignored (apart
>>>> from emitting a warning) and this typically results in resource leaks.
>>>>
>>>> To improve here there is a quest to make the remove callback return
>>>> void. In the first step of this quest all drivers are converted to
>>>> .remove_new(), which already returns void. Eventually after all drivers
>>>> are converted, .remove_new() will be renamed to .remove().
>>>>
>>>> Trivially convert this driver from always returning zero in the remove
>>>> callback to the void returning variant.
>>>>
>>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>>>
>>> Acked-by: Rodolfo Giometti <giometti@enneenne.com>
>>
>> The MAINTAINERS entry for drivers/pps lists you as single maintainer.
>> Who is expected to pick up this patch given that you "only" send an ack
>> but didn't pick up the patch? (Or only picked it up in a tree not
>> included in next.)
> 
> In the meantime you sent an Ack to my patch. Does that mean I can/should
> include this patch in the series changing struct platform_driver that I
> intend to send to Greg after the upcoming merge window closes?

Yes.

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming