DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=hHbI8Av9psJglG3g9Yo2xHtzXGm09OSb1nGkT1AZ4VeunSpX97v1/TPov30bNYg16hXmUbOQ9tk5/wpVqxjXGNUcyezVmWByRI67/IsfQ5M+73TvMgKvHGPwGVkbbi5HI3CIIqrf3RrJ7dnGF4FYYBk2I6pnxd61VjuIGAZu3VQ=
Message-ID: <47A07DCE.5010808@gmail.com>
Date: Wed, 30 Jan 2008 14:38:22 +0100
From: Jiri Slaby <jirislaby@gmail.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071031)
MIME-Version: 1.0
To: Mike Frysinger <vapier.adi@gmail.com>
CC: Bryan Wu <bryan.wu@analog.com>, linux-kernel@vger.kernel.org,
       Mike Frysinger <michael.frysinger@analog.com>
Subject: Re: [PATCH 1/1] [Blackfin] char driver for Blackfin on-chip OTP memory
References: <1201689401-2892-1-git-send-email-bryan.wu@analog.com>	 <47A058B3.6000009@gmail.com> <8bd0f97a0801300519g22c5b66fjcba22a027e7043cc@mail.gmail.com>
In-Reply-To: <8bd0f97a0801300519g22c5b66fjcba22a027e7043cc@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1078
Lines: 25

On 01/30/2008 02:19 PM, Mike Frysinger wrote:
> On Jan 30, 2008 6:00 AM, Jiri Slaby <jirislaby@gmail.com> wrote:
>> On 01/30/2008 11:36 AM, Bryan Wu wrote:
>>> +     ret = cdev_add(&bfin_otp_cdev, bfin_otp_dev_node, 1);
>>> +     if (ret) {
>>> +             unregister_chrdev_region(bfin_otp_dev_node, 1);
>>> +             printk(KERN_ERR PFX "unable to register char device\n");
>>> +             return ret;
>>> +     }
>>> +
>>> +     bfin_otp_class = class_create(THIS_MODULE, "otp");
>>> +     device_create(bfin_otp_class, NULL, bfin_otp_dev_node, "otp");
>> Anyway, wouldn't be easier/better to use misc.c functionality here
>> (misc_register() et al.)?
> 
> probably ... i just didnt want to statically allocate a number in the
> range that would be Blackfin specific ...

MISC_DYNAMIC_MINOR is definitely your friend ;).

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/