Received-SPF: pass (google.com: domain of linux-kernel+bounces-174269-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 9 May 2024 10:16:10 +0200
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Alexis =?UTF-8?Q?Lothor=C3=A9?= <alexis.lothore@bootlin.com>, Konstantin
 Khlebnikov <koct9i@gmail.com>, Sasha Levin <sashal@kernel.org>, Thomas
 Petazzoni <thomas.petazzoni@bootlin.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] scripts/decode_stacktrace.sh: remove find_module
 recursion and improve error reporting
Message-ID: <20240509101610.5b9dc3a9@booty>
In-Reply-To: <CAE-0n52cX0qhTWdNtJEvy_GUEbXonf9LgmU253Rn8xTehj5OKg@mail.gmail.com>
References: <20240311-decode_stacktrace-find_module-improvements-v1-0-8bea42b421aa@bootlin.com>
	<20240311-decode_stacktrace-find_module-improvements-v1-1-8bea42b421aa@bootlin.com>
	<CAE-0n52cX0qhTWdNtJEvy_GUEbXonf9LgmU253Rn8xTehj5OKg@mail.gmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hello Stephen,

On Wed, 8 May 2024 17:35:53 -0400
Stephen Boyd <swboyd@chromium.org> wrote:

> Quoting Luca Ceresoli (2024-03-11 08:24:54)
> > The find_module() function can fail for two reasons:
> >
> >  * the module was not found
> >  * the module was found but without debugging info
> >
> > In both cases the user is reported the same error:
> >
> >    WARNING! Modules path isn't set, but is needed to parse this symbol
> >
> > This is misleading in case the modules path is set correctly.
> >
> > find_module() is currently implemented as a recursive function based on
> > global variables in order to check up to 4 different paths. This is not
> > straightforward to read and even less to modify.
> >
> > Besides, the debuginfod code at the beginning of find_module() is executed
> > identlcally every time the function is entered, i.e. up to 4 times per each  
> 
> s/identlcally/identically/

Well spotted!

Thanks for reviewing, v2 on its way.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com