Received-SPF: pass (google.com: domain of linux-kernel+bounces-174336-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <334396b5-0acc-43f7-b046-30bcdab1b6fb@intel.com>
Date: Thu, 9 May 2024 12:13:27 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations
 problem
To: Sasha Neftin <sasha.neftin@intel.com>, Andrew Lunn <andrew@lunn.ch>, Ricky
 Wu <en-wei.wu@canonical.com>
CC: <netdev@vger.kernel.org>, <rickywu0421@gmail.com>,
	<linux-kernel@vger.kernel.org>, <edumazet@google.com>,
	<intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
	<anthony.l.nguyen@intel.com>, <pabeni@redhat.com>, <davem@davemloft.net>,
	"Lifshits, Vitaly" <vitaly.lifshits@intel.com>, naamax.meir
	<naamax.meir@linux.intel.com>, "Avivi, Amir" <amir.avivi@intel.com>, "Keller,
 Jacob E" <jacob.e.keller@intel.com>
References: <20240503101836.32755-1-en-wei.wu@canonical.com>
 <83a2c15e-12ef-4a33-a1f1-8801acb78724@lunn.ch>
 <514e990b-50c6-419b-96f2-09c3d04a2fda@intel.com>
Content-Language: en-US
From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
In-Reply-To: <514e990b-50c6-419b-96f2-09c3d04a2fda@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmpzOG9iY0cyMllpUXVkYzZLdmdRL3lsMkMxdnl3R0x6UEVvYVBuU2hnYm1l?=
 =?utf-8?B?OXBhMmpnL1lPTWFJM0o3K0tVNHdDdmRDUDVweEF1Tit5YkNVdVYxZFBCOGhG?=
 =?utf-8?B?U0lNRlRpb2RPYXlYMWppcjJuTzBKZCtFbUFJYWljRXBhMFcyRVFlSnFtWDND?=
 =?utf-8?B?dXVkbDEzRTBHeTVFM0M5V0JYc0xoNGZHditGbkVCSnloWVNaOEN2RHU0T1lq?=
 =?utf-8?B?bG1aOXJrOVpWdGlxcjZocnFxTkdyeGNyMFYzNWZJME9vdU1oZ3VMQnNhUllq?=
 =?utf-8?B?L0ZqbkswQmdzc3FKRjVJb2JibVVRRWg0eXR3MkllWDBFOUxnU0V1ZXZCUUV4?=
 =?utf-8?B?eFBxWWd5cHdvemxGci9lYk9Nb3NKMXl4czNoSC9DaWlDcXhPR29qYmlMWWF5?=
 =?utf-8?B?VTI1UmRQeUtlelQvdjlSZ05qM3Q2cVZYUUV1blhubjJLcTk4WnA3MThzMFdH?=
 =?utf-8?B?d1RlK1FzanRLZjlrbzhJOFV3UWsrQ1R3bUh3T3E0T1U3bjB2dyszMHJOWmk4?=
 =?utf-8?B?L2N1N1ZLbllpR0xTQW5PM2FuMzFYWkQvdU5YNnNrVlZKMDBaS3hoR09XQXVj?=
 =?utf-8?B?ckIvcXBGUUNvbTF5VEFTYzdKczZaRkxrZTNURFUxYTF4NURzek1YUFZpSGov?=
 =?utf-8?B?RVNnSEdkVytpT3dEVEhSUXdsaTk3RGt5Sm03VkJxKzhnYmtXRVFoUzVMdG91?=
 =?utf-8?B?M1RKUWdHVWVBVzhjYjVJNS9vRGZvWVQ0QXoycDF4bG9TZ0FTRHJ0UGVqK0RC?=
 =?utf-8?B?Q1pjTU9QYjlyN3VaSUVyNE4vMGZqSHFVL1dKZDRSdjJyQ2k0ZitkWk5pSzFB?=
 =?utf-8?B?bk5TcEpkTWFsUCtOYWdtaCthQ3VYYlVQNlZzejNCdm95TlkyVVJRYnhQd3dR?=
 =?utf-8?B?cHd0ZTNMdkUwYVlId1VzRjlKRHB5d2Zib2tpSkE1QVIxRWlqeG0zNmtsRmZZ?=
 =?utf-8?B?S0h3cUpGQVRzc2tOTUVENXRyVTlyYXNZT2llSW1IMU9hcmtGbDZIVDBnMVNK?=
 =?utf-8?B?RXZOamRMWHFVRkFENldVSXhwdkdzMm04UGFDZUFFZ3djWGNCRGJWb1Y0ZElD?=
 =?utf-8?B?bkV6RXFlMVI2K3N5OEhaSHc0QVNZVkJrNVEwN0tlVDZrcm5WTmV0bnZKUmVs?=
 =?utf-8?B?dERnckZJZjVXSWhwVnRpblB3MkFXVXo1MkZaTXdCZVdWazFKRW0zK2c0WkVm?=
 =?utf-8?B?RzRIdytvS0VtQnZ3a0pKM1RDNkVqVTQ2Y0VjT1lIK1VxNm56dVpsMFdiVlFJ?=
 =?utf-8?B?QklLL1B3NmVnYnBhL0xEVnM4Tncrd3NQYkVCMGdDUFdwVlljV2NaQ0dZQVdP?=
 =?utf-8?B?UnliZEUzcnFmbjNyNUZjckw1MmFRY2tvK1pCNzV3R094L3lVdjcvaWhGWnlz?=
 =?utf-8?B?N0hRbHJsa3U4NXJNYXpNVUNqV0tZemF2QnNTQkxnQ3ZxMjlNajloaXB1L2Qv?=
 =?utf-8?B?ZGlOZE9zYXNhSHE0WHlFVnRaMHFOaVh3dFNQNHdXelduV3REM3dqTWNZU1FJ?=
 =?utf-8?B?c3VwK0l0bUhCUkMwaWZPdVJVV09WQVZyNGoxVWxlc3pqK1pVamUrYzV2L25O?=
 =?utf-8?B?czByVUVBcTZkWnI2L1NjaGkxYk94TStCVG5odnZpNFplNlBXLzZGK0cyTHhV?=
 =?utf-8?B?cXV3dUhIamsydTdxZ2JIV0NDVUoxQWJqVUt3VWNhN2FmVjh0cmFOZjhjbWZR?=
 =?utf-8?B?cDQ4NlVvQm8vcTVDVUc4QTgxejZYVTFnaFZRQkVGQ0JFR2lkWWpIbHlEbXRY?=
 =?utf-8?B?VDVIUFBCeU80bEducElrQTRoWDU4c2pMcitxQ1U0eG9QblVSVk8vbkVCWmo2?=
 =?utf-8?B?bDBueWEvd1BsYmtNb0V2WktGcWxDcVlhYnRhczBqNXhiYWtPRU5STnJJWHEx?=
 =?utf-8?B?bStkZUpKdUQxa0hYNTVuWkZuWGtsaUFRZzNPdXNDTkkyMnJINmNOajJ2T0xr?=
 =?utf-8?B?UW9MU1NGd1EvYjNqWDJKQzRKd0kyRWlnckdGeURkSmNOSDhzYTFJU2NtOVBu?=
 =?utf-8?B?OUZFcGNuWmZiZXRlZS9DamI4REV0OU5BK0ltSk5STnIxbkpRQlhkSDg2bmhW?=
 =?utf-8?B?dSs4UjJZRExHRHQzS1lad3VMQjVCa3MzZzVWanNQV3VWWjNwbXYzbm9SZ2Yx?=
 =?utf-8?B?ajlLMFVsamt3a1JrREp0cXdLWHZNaFJZTnZDQmVPcUwzelYyMGRyVXVIdUQ3?=
 =?utf-8?B?VWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 65593de0-43e6-4cfd-5659-08dc70084d71
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6280.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 09:13:34.3344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rbf1Sd1HRq2s/ajZFkAUAaVPOPPSNoRjJSgBUbQQ/NoR9+0kcBxUTjE4270OsFlIO1vdEYXTzeDs/Gj8MPcUhg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4799
X-OriginatorOrg: intel.com

On 08/05/2024 8:05, Sasha Neftin wrote:
> On 07/05/2024 15:31, Andrew Lunn wrote:
>> On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote:
>>> As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642,
>>> Intel I219-LM reports link up -> link down -> link up after hot-plugging
>>> the Ethernet cable.
>>
>> Please could you quote some parts of 802.3 which state this is a
>> problem. How is this breaking the standard.
>>
>>     Andrew
> 
> In I219-* parts used LSI PHY. This PHY is compliant with the 802.3 IEEE 
> standard if I recall correctly. Auto-negotiation and link establishment 
> are processed following the IEEE standard and could vary from platform 
> to platform but are not violent to the IEEE standard.
> 
> En-Wei, My recommendation is not to accept these patches. If you think 
> there is a HW/PHY problem - open a ticket on Intel PAE.
> 
> Sasha

I concur. I am wary of changing the behavior of some driver 
fundamentals, to satisfy a particular validation/certification flow, if 
there is no real functionality problem. It can open a big Pandora box.

Checking the Bugzilla report again, I am not sure we understand the 
issue fully:

[  143.141006] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 1000 Mbps 
Half Duplex, Flow Control: None
[  143.144878] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Down
[  146.838980] e1000e 0000:00:1f.6 enp0s31f6: NIC Link is Up 1000 Mbps 
Full Duplex, Flow Control: None

This looks like a very quick link "flap", following by proper link 
establishment ~3.7 seconds later. These ~3.7 seconds are in line of what 
link auto-negotiation would take (auto-negotiation is the default mode 
for this driver). The first print (1000 Mbps Half Duplex) actually makes 
no sense - it cannot be real link status since 1000/Half is not a 
supported speed. So it seems to me that actually the first "link up" is 
an incorrect/incomplete/premature reading, not the "link down".

--Dima