Received-SPF: pass (google.com: domain of linux-kernel+bounces-174350-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 9 May 2024 11:31:22 +0200
From: Johan Hovold <johan@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Johan Hovold <johan+linaro@kernel.org>, Lee Jones <lee@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Das Srinagesh <quic_gurus@quicinc.com>,
	Satya Priya <quic_c_skakit@quicinc.com>,
	Stephen Boyd <swboyd@chromium.org>, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH 03/13] mfd: pm8008: deassert reset on probe
Message-ID: <ZjyX6iBqc50ic_oI@hovoldconsulting.com>
References: <20240506150830.23709-1-johan+linaro@kernel.org>
 <20240506150830.23709-4-johan+linaro@kernel.org>
 <4468becb-dc03-4832-aa03-5f597023fcb2@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4468becb-dc03-4832-aa03-5f597023fcb2@linaro.org>

On Wed, May 08, 2024 at 05:12:51PM +0100, Bryan O'Donoghue wrote:
> On 06/05/2024 16:08, Johan Hovold wrote:
> > Request and deassert any (optional) reset gpio during probe in case it
> > has been left asserted by the boot firmware.
> > 
> > Note the reset line is not asserted to avoid reverting to the default
> > I2C address in case the firmware has configured an alternate address.

> > @@ -169,6 +171,10 @@ static int pm8008_probe(struct i2c_client *client)
> >   
> >   	i2c_set_clientdata(client, regmap);
> >   
> > +	reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
> > +	if (IS_ERR(reset))
> > +		return PTR_ERR(reset);
> > +
> >   	if (of_property_read_bool(dev->of_node, "interrupt-controller")) {
> >   		rc = devm_regmap_add_irq_chip(dev, regmap, client->irq,
> >   				IRQF_SHARED, 0, &pm8008_irq_chip, &irq_data);
> 
> So not resetting is fine and I understand you want to retain the address 
> given by the firmware, I think that's the right thing to do.

> In addition to adding a small delay suggested by Andy - a few 
> microseconds pick a number, I think you should verify the chip is out of 
> reset as we would do with many other i2c devices.

> In this case, suggest reading REVID_PERPH_TYPE @ 0x104 and 
> REVID_PERPH_SUBTYPE @ 0x105
> 
> REVID_PERPH_TYPE @ 0x104 == 0x51 (PMIC)
> REVID_PERPH_SUBYTE @ 0x105 == 0x2C (PM8008)

I'll consider it for v2.

Johan