Received-SPF: pass (google.com: domain of linux-kernel+bounces-174405-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5408b3fd-3ca9-47b7-83f1-567bea1387a0@redhat.com>
Date: Thu, 9 May 2024 12:39:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] extcon: Add LC824206XA microUSB switch driver
To: Chanwoo Choi <chanwoo@kernel.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
 Chanwoo Choi <cw00.choi@samsung.com>, linux-kernel@vger.kernel.org
References: <20240406140621.18355-1-hdegoede@redhat.com>
 <CAGTfZH1_-x+Z5+t=GCrJ+uEsuV2DPm9m+sKFYDXXXFprAVXekA@mail.gmail.com>
Content-Language: en-US, nl
From: Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <CAGTfZH1_-x+Z5+t=GCrJ+uEsuV2DPm9m+sKFYDXXXFprAVXekA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi,

On 5/8/24 5:21 PM, Chanwoo Choi wrote:
> On Sat, Apr 6, 2024 at 11:07 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Add a new driver for the ON Semiconductor LC824206XA microUSB switch and
>> accessory detector chip.
>>
>> ON Semiconductor has an "Advance Information" datasheet available
>> (ENA2222-D.PDF), but no full datasheet. So there is no documentation
>> available for the registers.
>>
>> This driver is based on the register info from the extcon-fsa9285.c driver,
>> from the Lollipop Android sources for the Lenovo Yoga Tablet 2 (Pro)
>> 830 / 1050 / 1380 models. Note despite the name this is actually a driver
>> for the LC824206XA not the FSA9285.
>>
>> This has only been tested on a Lenovo Yoga Tablet 2 Pro 1380 and
>> using the driver on other setups may require additional work.
>>
>> So far this driver is only used on x86/ACPI (non devicetree) devs.
>> Therefor there is no devicetree bindings documentation for this driver's
>> "onnn,enable-miclr-for-dcp" property since this is not used in actual
>> devicetree files and the dt bindings maintainers have requested properties
>> with no actual dt users to _not_ be added to the dt bindings.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

<snip>

> Firstly, I'm sorry for late reply.
> 
> When I check the patch with checkpatch script, there are following warnings.
> Could you please fix it?

Weird, I normally always run checkpatch myself before submitting
I must have forgotten that this time.

I'll submit a new version addressing the checkpatch issues.

Regards,

Hans


> 
> Traceback (most recent call last):
>   File "scripts/spdxcheck.py", line 11, in <module>
>     import git
> ModuleNotFoundError: No module named 'git'
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #71:
> new file mode 100644
> 
> ERROR: trailing whitespace
> #241: FILE: drivers/extcon/extcon-lc824206xa.c:166:
> +^I$
> 
> ERROR: code indent should use tabs where possible
> #322: FILE: drivers/extcon/extcon-lc824206xa.c:247:
> +        struct lc824206xa_data *data = container_of(work, struct
> lc824206xa_data, work);$
> 
> WARNING: please, no spaces at the start of a line
> #322: FILE: drivers/extcon/extcon-lc824206xa.c:247:
> +        struct lc824206xa_data *data = container_of(work, struct
> lc824206xa_data, work);$
> 
> ERROR: code indent should use tabs where possible
> #323: FILE: drivers/extcon/extcon-lc824206xa.c:248:
> +        bool vbus_boost_enable = false;$
> 
> WARNING: please, no spaces at the start of a line
> #323: FILE: drivers/extcon/extcon-lc824206xa.c:248:
> +        bool vbus_boost_enable = false;$
> 
> ERROR: code indent should use tabs where possible
> #324: FILE: drivers/extcon/extcon-lc824206xa.c:249:
> +        int status, id;$
> 
> WARNING: please, no spaces at the start of a line
> #324: FILE: drivers/extcon/extcon-lc824206xa.c:249:
> +        int status, id;$
> 
> ERROR: code indent should use tabs where possible
> #326: FILE: drivers/extcon/extcon-lc824206xa.c:251:
> +        status = lc824206xa_read_reg(data, REG_STATUS);$
> 
> WARNING: please, no spaces at the start of a line
> #326: FILE: drivers/extcon/extcon-lc824206xa.c:251:
> +        status = lc824206xa_read_reg(data, REG_STATUS);$
> 
> ERROR: code indent should use tabs where possible
> #327: FILE: drivers/extcon/extcon-lc824206xa.c:252:
> +        if (status < 0)$
> 
> WARNING: please, no spaces at the start of a line
> #327: FILE: drivers/extcon/extcon-lc824206xa.c:252:
> +        if (status < 0)$
> 
> ERROR: code indent should use tabs where possible
> #328: FILE: drivers/extcon/extcon-lc824206xa.c:253:
> +        ^Ireturn;$
> 
> WARNING: please, no space before tabs
> #328: FILE: drivers/extcon/extcon-lc824206xa.c:253:
> +        ^Ireturn;$
> 
> WARNING: please, no spaces at the start of a line
> #328: FILE: drivers/extcon/extcon-lc824206xa.c:253:
> +        ^Ireturn;$
> 
> ERROR: trailing whitespace
> #430: FILE: drivers/extcon/extcon-lc824206xa.c:355:
> +^Ischedule_work(&data->work);^I^I$
> 
> ERROR: trailing whitespace
> #553: FILE: drivers/extcon/extcon-lc824206xa.c:478:
> +^Ischedule_work(&data->work);^I^I$
> 
> total: 9 errors, 8 warnings, 524 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> NOTE: Whitespace errors detected.
>       You may wish to use scripts/cleanpatch or scripts/cleanfile
> 
> 
>