Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp1091148lqo; Thu, 9 May 2024 04:43:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUO2KLpO0wqSUJVWe1pW+d3wsuBsbBo5utUAq7nqfuI+kNmq/EILV62QnxC+HqpRY+FKIKV5tJ/asJPKwMiC6cG7PiLIA2+37iuDSyILg== X-Google-Smtp-Source: AGHT+IE4mChpADwVCe9ptDwHqcVVvc6HB+0ND8LKL1zNjlRhR8CY5FkWJT+rEmZamhjfWVO0dAVk X-Received: by 2002:a05:6a00:820d:b0:6ec:db05:36cd with SMTP id d2e1a72fcca58-6f49c212f92mr4759097b3a.9.1715255020435; Thu, 09 May 2024 04:43:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715255020; cv=pass; d=google.com; s=arc-20160816; b=EKJvAjIAwNY3S6JJIwwBs5p4tjo0IRhv4HtsZqt/uof7HsOB/UGBZXz3v+agbXhDtT s9j3hHxA1Ty03h86y0JHWRwL8Nl/Ydeow58rldGpnhbXyh7tDuGtwk3dof1j/s05cgK3 FXW3KWyyHeyU4VylzxoI8AkNJWWP4pWETJ1MlFOMTtDBwpqjaVWQ11Pzm48Jj2XoPg9b Kbh30r653+4FmJmeJntvlhLZJrPy5FZM7ZyfDRtGQszPDRt+ozdvyyEv4O5H5K6GdJX2 rB4Isr8Ni1UEUr9CyV66vnLTKIweeb/QGZBIe6ero80pFUZHNvyRE9liBNpc76yPJDRL vvHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=vq2mjCOsl6Marf6zjWHcGKLeoXAkUCwpfDkn/dtXyOo=; fh=jNwJc3hzWkmJ/AfK/vs718YqKR/T1Su83l+JG96Lh7c=; b=TVP+bEM8t1oqeu3231QTII+KE+2MYVg/V/YVExqGk8o9akl5HGh02N/7MQRzkssKxH kOH/HjX/QRMlJgBedeJ5TGjWvacTcKMCeFfuCre4tD25JmTt63+pOKrOVcQ+smdHwWlU rCEIuKMPTFyG2bFqMAAWizDLdEDmDj5uODnUPYbwlx5naTdXIPWqokjt0GRf3DyoCF55 qXu49Fq0Z2giwAoiqD09Bx+rjNBa64BbRPd7jkB8dBkiHNXDSDt1sac3/0bjGk/besIy iqehJADua17o6dp34+F/LpBipXOoZn4wQ2xghqaxiGP4jg/MxZ0kwb+8Cg4ZTh8QTty1 Ii7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VIyTcFs4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-174451-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174451-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-6f4d2aee607si1360376b3a.205.2024.05.09.04.43.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 04:43:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174451-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VIyTcFs4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-174451-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174451-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C2257B2148E for ; Thu, 9 May 2024 11:43:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64CEA149C40; Thu, 9 May 2024 11:43:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VIyTcFs4" Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C673912FB0A for ; Thu, 9 May 2024 11:43:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715255006; cv=none; b=Gls0nkWxD7LLba459N0vgX7onEuze8Sxd52WryEyolfPbh77SJb9c2fut9nXg733puP6VNkT1XaOKuICRpKEngcCeTZaQRc0JUHVdMc3QcFYciVRQJuAFdNdF5oUHtPKlDCiredfKaEP1YowEIJjekPaw2VQ6uBei2hIMTR9+vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715255006; c=relaxed/simple; bh=6XWYnkdFEBRgr4Uvci/np65/qXyvHuEamHU0e+LhQAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jJA5vISDC08NkHTQjfeTAH6kh3e06X6L8P1/zIyt2Qz/PuBUvi2KwzFT1rrvXzlRh4twpxfGOVzUQV9xkSy8UzYr7XPPF9pAXRbYeEYDAEF3+gfLyxf67m2nTsbbbZJwsOJfriyUg4Pi6441Yz1EBA+tRcvbreham5D4gyVPuFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VIyTcFs4; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a59a352bbd9so141647966b.1 for ; Thu, 09 May 2024 04:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715255003; x=1715859803; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=vq2mjCOsl6Marf6zjWHcGKLeoXAkUCwpfDkn/dtXyOo=; b=VIyTcFs4mz7qjz4U5I0AW5YqukWoXYX730YVDrfNyJqY87SchHQoTziFgcYfVIzEPd aFSr/++OwE2a7z3kgzmki8ZGIso9xmUy5HLz0M+zZyf+MkWaO/IRzl9cqztD0mOj1MQS kHmkTADmLGs8kqE4fyStpGcQ5Jn5itjdT92ixQPFV0GWeMqwHC7ZbKZM7imTm6C/BZcs th835n04XwUHN3m2SK8hRSRS1EbagkYQ3YyciOVRbLgSxiUB8Bc/f12qFgKIRmYXV8vj Oz/BXOlOD9pXZCwG8xo1nte5JMtlAITrasLXSZ+0nuEg9oRHzK4eccJQtuVLDPZ/edSI 3zpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715255003; x=1715859803; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vq2mjCOsl6Marf6zjWHcGKLeoXAkUCwpfDkn/dtXyOo=; b=J0WSWAQuQ494CnF2nLsIZxPVLCeYhLdk2SFG1qYyseHqXgOxtCAYetgK++5+NiolmU wZYApLTfjbeoXgPhRyd81Kx92AoQmmBpJKVXrbMsZVB6F27A0F7YOb/RzgztJJi09haB 5596A/Hv2A3Mj8SfQhemh8LcZ8rDSTL0QN5UI7H0M06jcH9IdvgxUEvyvkzjC/ktKjYI pIMMwuR4Kq4QBnhrCU4W9cpjw5byMx0S0q/SrFYT0dmSAZOvmk48wjtcDU+Pa7uO8j9r bMLTuSVOaozEBZ0rpcfhekIOJqV9vJ87VH1WzpQG5qIJYU80z6XAy9TibUPrXu87bx1U EBtw== X-Forwarded-Encrypted: i=1; AJvYcCXdZ4eD1FgK/BLRR8TCKzJ6DfvIJrxbHsX7rdIu6qvhoZMp9EtTciPx5+rXr2za872Bglgdpg/gg9VIr92IfhYJe4oW3W15kg3Scu4S X-Gm-Message-State: AOJu0YyOCxFVodgcyRTNoh2bZ0Nnz05mcBhR/qQjaKpgEA3E8HHHSE4s c009dFhI4tmAOsEkJk2duUMvq7nrvKoIeK2gxA0w8a5Gd3WX0nbLuvK9UDT3MBg= X-Received: by 2002:a17:906:6a10:b0:a59:9636:f3e with SMTP id a640c23a62f3a-a5a118c520bmr221662566b.33.1715255003249; Thu, 09 May 2024 04:43:23 -0700 (PDT) Received: from [192.168.1.20] ([178.197.206.169]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a1781d1fcsm64999066b.35.2024.05.09.04.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 May 2024 04:43:22 -0700 (PDT) Message-ID: Date: Thu, 9 May 2024 13:43:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] ASoC: qcom: qdsp6: Set channel mapping instead of fixed defaults To: Srinivas Kandagatla , James Schulman , David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown , Lars-Peter Clausen , =?UTF-8?Q?Nuno_S=C3=A1?= , Banajit Goswami Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240509-asoc-x1e80100-4-channel-mapping-v3-0-6f874552d7b2@linaro.org> <20240509-asoc-x1e80100-4-channel-mapping-v3-3-6f874552d7b2@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/05/2024 11:17, Srinivas Kandagatla wrote: >> diff --git a/sound/soc/qcom/qdsp6/audioreach.h b/sound/soc/qcom/qdsp6/audioreach.h >> index eb9306280988..208b74e50445 100644 >> --- a/sound/soc/qcom/qdsp6/audioreach.h >> +++ b/sound/soc/qcom/qdsp6/audioreach.h >> @@ -766,6 +766,7 @@ struct audioreach_module_config { >> /* Packet Allocation routines */ >> void *audioreach_alloc_apm_cmd_pkt(int pkt_size, uint32_t opcode, uint32_t >> token); >> +void audioreach_set_channel_mapping(u8 *ch_map, int num_channels); >> void *audioreach_alloc_cmd_pkt(int payload_size, uint32_t opcode, >> uint32_t token, uint32_t src_port, >> uint32_t dest_port); >> diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c >> index 00bbd291be5c..8ab55869e8a2 100644 >> --- a/sound/soc/qcom/qdsp6/q6apm-dai.c >> +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c >> @@ -243,6 +243,7 @@ static int q6apm_dai_prepare(struct snd_soc_component *component, >> cfg.num_channels = runtime->channels; >> cfg.bit_width = prtd->bits_per_sample; >> cfg.fmt = SND_AUDIOCODEC_PCM; >> + audioreach_set_channel_mapping(cfg.channel_map, runtime->channels); >> > > Prepare can be called multiple times.. so we have channels overwritten here. Which is expected - just like we overwrite number of channels. Best regards, Krzysztof