Received-SPF: pass (google.com: domain of linux-kernel+bounces-174505-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <fdce3c08-a3cb-4d5b-ad1a-0eeb8761778f@collabora.com>
Date: Thu, 9 May 2024 14:39:36 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dt-bindings: leds: mark label as depected to match
 description
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Frank Wunderlich <linux@fw-web.de>, Pavel Machek <pavel@ucw.cz>,
 Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: Frank Wunderlich <frank-w@public-files.de>, linux-leds@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240509110545.49889-1-linux@fw-web.de>
 <c461b4cb-2f14-4793-a967-bf08e2b4ab88@linaro.org>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Content-Language: en-US
In-Reply-To: <c461b4cb-2f14-4793-a967-bf08e2b4ab88@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 09/05/24 13:46, Krzysztof Kozlowski ha scritto:
> On 09/05/2024 13:05, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> The description for property 'label' describes it as deprected, so
> 
> Typos here and in subject.
> 
> 
>> add a option to mark it like that. Future devicetrees should use
>> function and color properties.
>>
>> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Fixes: 24a71afe05a8 ("dt-bindings: leds: Convert common LED binding to schema")
> 
> Nooo, that's not a fix.
> 
> I don't think there was conclusion to make it deprecated on last attempt:
> 
> https://lore.kernel.org/all/20221122111124.6828-1-cniedermaier@dh-electronics.com/
> 

It's not a fix, agreed.

But that property being deprecated deserves to be marked as deprecated, anyway.
Otherwise the documentation shouldn't say in words that it is such.

Cheers,
Angelo