Received: by 2002:ab2:6991:0:b0:1f7:f6c3:9cb1 with SMTP id v17csp1156073lqo; Thu, 9 May 2024 06:25:34 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCV4cZ2MwcbLvqhe9amoUJwW3IF+q2a6v+XP0lMPuefEXRW8pmubUAUDaW6L/5wp+h6/6cIW+tn/zVv0hL30hR7YONSkvxHAbfVUATmhCw== X-Google-Smtp-Source: AGHT+IEh69VYt1HgwShpt3Vno1utc2GHBzPLKKk9d4rDpiUOCUWaQQBE7Gf7AZEzu+b5NcF4ClTl X-Received: by 2002:a17:90a:8b01:b0:2ad:e004:76e6 with SMTP id 98e67ed59e1d1-2b6163a269amr5450134a91.7.1715261134515; Thu, 09 May 2024 06:25:34 -0700 (PDT) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b671689f9asi1508402a91.177.2024.05.09.06.25.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 06:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174534-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-174534-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174534-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 50E7C28550B for ; Thu, 9 May 2024 13:25:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 032B6158208; Thu, 9 May 2024 13:24:48 +0000 (UTC) Received: from fgw21-7.mail.saunalahti.fi (fgw21-7.mail.saunalahti.fi [62.142.5.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE03F152783 for ; Thu, 9 May 2024 13:24:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.82 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715261087; cv=none; b=RVwZd+oFOfuzH6hHr6AnG6A5J/MeKYLXv6XY92IjQo3o0p91Xpp7Q24V4LkrGWJuFTVwp+YgGNFAr7/SI4LWAgvsOG4msCkGuzfpKsPr+E/4bBUtuCkcE42Bl+ReBDGUyoqSGl8lvM+VAyviRkyAXXp97rO3GWptVUCUIHIku64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715261087; c=relaxed/simple; bh=6USuKq62doKHphgqcLAIG53oZFLpJicWipnC4Iu7nI4=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Lc/zo5NdxHN10EgH+aaTkWEMCq9nRygP8cjXyPuRP+DVrGYj5fuy2xUCXVDxEmU+IuamURpW27HhyiUZPutMlOZSFJ2n0mzhZO/er1VplPS+XTSqkgPdSCXXcGs10PWZR0DSjRRE8XGB+ymZI28j3EDQy/0Bt9+CynK7YqOW9lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.82 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw23.mail.saunalahti.fi (Halon) with ESMTP id 7f04bc40-0e07-11ef-b972-005056bdfda7; Thu, 09 May 2024 16:24:43 +0300 (EEST) From: Andy Shevchenko Date: Thu, 9 May 2024 16:24:42 +0300 To: Johan Hovold Cc: Andy Shevchenko , Krzysztof Kozlowski , Johan Hovold , Lee Jones , Mark Brown , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Das Srinagesh , Satya Priya , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 12/13] regulator: add pm8008 pmic regulator driver Message-ID: References: <20240506150830.23709-1-johan+linaro@kernel.org> <20240506150830.23709-13-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Thu, May 09, 2024 at 10:53:02AM +0200, Johan Hovold kirjoitti: > On Tue, May 07, 2024 at 08:22:34PM +0300, Andy Shevchenko wrote: > > On Tue, May 7, 2024 at 6:44 PM Johan Hovold wrote: > > > On Mon, May 06, 2024 at 10:09:50PM +0300, Andy Shevchenko wrote: > > > > Mon, May 06, 2024 at 05:08:29PM +0200, Johan Hovold kirjoitti: .. > > > > return dev_err_probe(...); > > > > > > Nah, regmap won't trigger a probe deferral. > > > > And it doesn't matter. What we gain with dev_err_probe() is: > > - special handling of deferred probe > > - unified format of messages in ->probe() stage > > > > The second one is encouraged. > > I don't care about your personal preferences. Did I say it's mine personal preference. Or should I put it as preference of several (majority?) maintainers? Whatever, it's up to Lee. -- With Best Regards, Andy Shevchenko