Received-SPF: pass (google.com: domain of linux-kernel+bounces-174542-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <697ccebb-ffbc-4bb3-81ed-a7fab6f5a679@oracle.com>
Date: Thu, 9 May 2024 14:29:22 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bdev: make blockdev_mnt static
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>, brauner@kernel.org,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
References: <20240227081958.89092-1-jiapeng.chong@linux.alibaba.com>
 <2dea08f3-03c8-46aa-af57-45cbd9556df4@kernel.dk>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <2dea08f3-03c8-46aa-af57-45cbd9556df4@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?NjdvejVKTUs0dlZzeEUweXg0NmttTW55V2ljS1FBVU9PSkFkWGphN09TY1Zh?=
 =?utf-8?B?anZidU8zRXk5bjJwdnE0ZGl2YmUwTW5lWXh2RlRFSnU0MWhYeElGWGQvQ2Zw?=
 =?utf-8?B?cFdkalR4SklrWmVSMU0zQ09vNEZIUlNVdGtoWFlOaHNINkZxWXozeTBQOWhH?=
 =?utf-8?B?TEN4YnpWcFAxcmZtNUNLRkN0Y1pnV0pkc3FGT0QwaEJ4K3NSV2o0dmdoeHhH?=
 =?utf-8?B?NUZjd2FNR1BueWRQTi92cmpiWGJDM3dFaTBHTE1yT0FEUE5landvYXVTZHdD?=
 =?utf-8?B?cGNtZkdUdWVMY0JHcDVqdHZxTnN1Um1LM0NkRDhRMW53L0g1TXVQUk9CMjdS?=
 =?utf-8?B?bnFQSi9OWDVCNWFRckVVb2c2VTM3MUlkeE5qSzZESU9UV2NZY09OVWVrMHFt?=
 =?utf-8?B?MkFuRHVzOGUwc3hHT0hINnJBTzBDZjcvSHBBVXcxTUtIOFV3NVR6b0phM3o4?=
 =?utf-8?B?WWlKb0t1UzkzalpSNmJmQ1pSc1dLS0RDano0TzE2L1VVSUxzNytVaTFSSXFm?=
 =?utf-8?B?UkVWQ1R0SW15YXZEUUpFRWtpUE9PeDV3YzJRTlFPdTdVM24yY3o2cXhPTHZM?=
 =?utf-8?B?ajl0UGdoZ2ZMMXYyWCtzQUNzbS9QZWdORThUTVN3RHJTdGxQbGxaTU5NMG5p?=
 =?utf-8?B?bmo4QldVcHhBcUZnWlk3TWJMZWxoQVRPZEZGU3lXNWVuTjNDTGpwSkVFUzFO?=
 =?utf-8?B?VmdiM0s4YWR2aFZuYWZTYWFhdjRRdHlCa0k4djZuRTBMTUo3SmJwZDdsRVpP?=
 =?utf-8?B?TWZTKzFNbk1BNElBTmQ5QUJwR2t1aUNTV3JWNVVlbmlPVGgxeVZ0bENNT0U5?=
 =?utf-8?B?UHl2OWdTR21FVmU1ZzZOczBrdndRemRZNFdUMW9GQ0RjeHk5c1dMcGlkN09a?=
 =?utf-8?B?amY3ckJaMUU0cVo1ZEtJV056MW1odVQ2VlF3R2F6WUFhRmZKV0ZHbXNtRkx2?=
 =?utf-8?B?SUFXOWpKSUdGaDNoak85eUhzank2eDVaeVZSd054U2Rlc3owVUxvUzRrVFlL?=
 =?utf-8?B?b1JpSWc2elJObGdTSzlXd0xhaU9oMFFYajlWRElSbGc4UklqSFJyUzFub2Vi?=
 =?utf-8?B?YTNtK01CNWtWRXFKanRXU3cyNmo5L0VyV3hpaS93MS92dHh1YnFIYW1TNDlF?=
 =?utf-8?B?REtyVXJvNk5HeVd6Lzl0ajVYdVNwK1N1Rkp5T0lpbERlUnlhaWpOUkhtb0cw?=
 =?utf-8?B?dUVHSzJiOXFqYmY5OHRMZTk0d083blhhU2RKZWhpMlUvaHFLV1BTc05NVXRW?=
 =?utf-8?B?KzdselVXTzdpdFY3QUltT3RNMnpLZDVJeTBKMVBudVgyZmgwdldCOGlUOTNw?=
 =?utf-8?B?d3R2VE5LejlhSUtVUmIyU3E2b3hjaTJYc1YxSGt1NndvYUlwMDg2ZmpESGhL?=
 =?utf-8?B?aU1jeVZkTHpMWTNSY1Jta1ZSazJUQkdoUTg1MlpLYXViNVY3d2d0T1Z4QXFU?=
 =?utf-8?B?N1pyT2l3aE04Tk1Icm1OdGJMbHk4S0dCUWQwcytNNjBUYkhET1BMTEN2UUR0?=
 =?utf-8?B?YlRGL1NiY0pQV1BKT3U3L1BsMEJoTUh4RUxnV2RiRXBCak83QWRSQmJleDND?=
 =?utf-8?B?VlJDWW1DOVB5WWxtQWlWN3Vpdzh5cXFmWTdwdEV2by9JcGZQRFFoeGtmLzBI?=
 =?utf-8?B?UVRRd3hnSW9zenIrZExnQWxmbzQ2U1JHdlJMUDBsakxLQnVnZExhNHVIdmhu?=
 =?utf-8?B?cHVsRXdmellUL3I2aERSb09LQkhJSjNjVzZycjBnKzc3a09BSjBGbm5FcDF4?=
 =?utf-8?B?WjYyWjBWcEpDQSsyd3ljcUttdllqR3dod3llK3dSMkdIa29yM0tUeVVWNC9V?=
 =?utf-8?B?Znljakljb2UybGZOMVl4dVBpMUo4MDlvbGpJckYwdXJuRlZYenhublhSaEJD?=
 =?utf-8?B?YjZLQkJ5Z01pSkdNbldIL0o4T0RrbkphaXE5NkNPc3ZGKy82MU9OY1NxZWpr?=
 =?utf-8?B?YkVLOW1ySkd5eWlsTzdxeDlaSTlZdkVXQ25PT1FENTNOTS9pSjZUMVBnMWM1?=
 =?utf-8?B?VC92dmFhQkhWSFlwL25hYXdaWXREcjlQb2hYYVVHb1J0Q08yekhickZaN0I3?=
 =?utf-8?B?WjVRQnIzWUxrV0NLQjZyQ095NG84UnJ2UkRHTUpYdy90NG1IQXBPWnNsd2s2?=
 =?utf-8?B?eHdUSnMxa0JrbHI3YlZJWWtDNVU3QWk4b0VFWnVVR2pkY3RvMlE0QWU2ZzJK?=
 =?utf-8?B?cFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	oBwLIKXzZVJMYYErDykxhpmmLWqYLs8rmfCf1t/rHpUyZUpKpjiBTYQff6G6t49ZlMO9uH6iy1hiMAQQbaopdVUbKe4FzB3d5J5MWtI1ipvgyf2s/d6695DeAk21GOxZFEoxD88EH7Q6PLOBhb0rEJYTKKB6hrdsGMBmhB4XSso3uZ3+Wmr2ECK/nnLJQcLD4CHeFYOJz9/doIFReinkO9lpT3yaVj26ncj/jRB2L3yGXcBG1qQLtB1VtvpuleZ6BTcm5nJdg4e40AVb2sB/Qc19lQO2GsTl5JJHwxkUwFf7et5PwbPBYUD/nPOOZtuZzPXm3oxrfM2KaSWZi9pIvlxjjgCYhjjnDzM18MAcKAtUx4FLwu8lLCj70MCI5XgB1g3O+8U7ajao8tnmQdmT4xJZnfr4SkrLaw8eB+SBlA08mfG3AJ+KoaHXb/LqKtjaDYPCekPypFl5PxBCkOMKUfpCUuwJrZct196bT1j97YUMVE9KBIFD1TiznrLud95N0GJEQDWEPA6U7RZtVNJXeLMJyoLiFT587vbgOFvwvlQoq8H1HVtgqRD98KA5dIZSMVb79cj7Oig28P7dN9JIGOBBdrU8wqhL8zQ78CdJpXU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0db8add2-ff3f-4cdf-48c2-08dc702c0f7b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 13:29:32.3499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s6H5if+B2F+fAYgcEXdgSZubE+RoRtHBbry2u/aVJGm7YB98v15uOrSYX5SFnd5GvfD+/SkXrhHkI7hdQ3vIrA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB7392
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-09_06,2024-05-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 spamscore=0 bulkscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405090091
X-Proofpoint-ORIG-GUID: 92AyuXaGra4f2nUYaf6t60gGMjDVBTbo
X-Proofpoint-GUID: 92AyuXaGra4f2nUYaf6t60gGMjDVBTbo

+

On 28/02/2024 14:21, Jens Axboe wrote:
> On 2/27/24 1:19 AM, Jiapeng Chong wrote:
>> The blockdev_mnt are not used outside the file bdev.c, so the modification
>> is defined as static.
>>
>> block/bdev.c:377:17: warning: symbol 'blockdev_mnt' was not declared. Should it be static?
> 
> What is this against?
> 

Please note I see this issue on your 6.9 block branch today @

fd379c13fc0 (HEAD, block/block-6.9) block: set default max segment
size in case of virt_boundary

And I think that it fixes 8f3a608827d1, so

Fixes: 8f3a608827d1 ("bdev: open block device as files")
Tested-by: John Garry <john.g.garry@oracle.com>