Received-SPF: pass (google.com: domain of linux-kernel+bounces-174547-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <cfa4ec0f8f26ffceb6adcea96a182736519886ef.camel@surriel.com>
Subject: Re: [PATCH] fs/proc: fix softlockup in __read_vmcore
From: Rik van Riel <riel@surriel.com>
To: Baoquan He <bhe@redhat.com>
Cc: akpm@linux-foundation.org, Vivek Goyal <vgoyal@redhat.com>, Dave Young
 <dyoung@redhat.com>, kexec@lists.infradead.org,
 linux-kernel@vger.kernel.org,  linux-fsdevel@vger.kernel.org,
 kernel-team@meta.com
Date: Thu, 09 May 2024 09:41:27 -0400
In-Reply-To: <ZjxImBiQ+niK1PEw@MiWiFi-R3L-srv>
References: <20240507091858.36ff767f@imladris.surriel.com>
	 <ZjxImBiQ+niK1PEw@MiWiFi-R3L-srv>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) 
Precedence: bulk
MIME-Version: 1.0
Sender: riel@surriel.com

On Thu, 2024-05-09 at 11:52 +0800, Baoquan He wrote:
> Hi,
>=20
> On 05/07/24 at 09:18am, Rik van Riel wrote:
> > While taking a kernel core dump with makedumpfile on a larger
> > system,
> > softlockup messages often appear.
> >=20
> > While softlockup warnings can be harmless, they can also interfere
> > with things like RCU freeing memory, which can be problematic when
> > the kdump kexec image is configured with as little memory as
> > possible.
> >=20
> > Avoid the softlockup, and give things like work items and RCU a
> > chance to do their thing during __read_vmcore by adding a
> > cond_resched.
>=20
> Thanks for fixing this.
>=20
> By the way, is it easy to reproduce? And should we add some trace of
> the
> softlockup into log so that people can search for it and confirm when
> encountering it?

It is pretty easy to reproduce, but it does not happen all the time.
With millions of systems, even rare errors are common :)

However, we have been running with this fix for long enough (we
deployed it in order to test it) that I don't think we have the=C2=A0
warning stored any more. Those logs were rotated out long ago.

kind regards,

Rik
--=20
All Rights Reversed.