Received-SPF: pass (google.com: domain of linux-kernel+bounces-174557-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240507041343.272569-1-wens@kernel.org> <20240507041343.272569-3-wens@kernel.org>
 <ZjxWKOoLMNQAmhla@finisterre.sirena.org.uk>
In-Reply-To: <ZjxWKOoLMNQAmhla@finisterre.sirena.org.uk>
Reply-To: wens@kernel.org
From: Chen-Yu Tsai <wens@kernel.org>
Date: Thu, 9 May 2024 21:55:19 +0800
Message-ID: <CAGb2v66VmizAy-+XWUK3-tYyZFV6qQUdBrxPU72nFPH71tNekw@mail.gmail.com>
Subject: Re: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs driver
To: Mark Brown <broonie@kernel.org>
Cc: Samuel Holland <samuel@sholland.org>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, linux-kernel@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-sunxi@lists.linux.dev, Andre Przywara <andre.przywara@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 9, 2024 at 12:50=E2=80=AFPM Mark Brown <broonie@kernel.org> wro=
te:
>
> On Tue, May 07, 2024 at 12:13:43PM +0800, Chen-Yu Tsai wrote:
> > From: Samuel Holland <samuel@sholland.org>
> >
> > D1 contains two pairs of LDOs, "analog" LDOs and "system" LDOs. They ar=
e
> > similar and can share a driver, but only the system LDOs have a DT
> > binding defined so far.
>
> This doesn't build on at least multi_v5_defconfig, multi_v7_defconfig
> and arm64 defconfig:
>
> /build/stage/linux/drivers/regulator/sun20i-regulator.c: In function =E2=
=80=98sun20i_reg
> ulator_probe=E2=80=99:
> /build/stage/linux/drivers/regulator/sun20i-regulator.c:111:16: error: im=
plicit
> declaration of function =E2=80=98of_device_get_match_data=E2=80=99 [-Werr=
or=3Dimplicit-function-de
> claration]
>   111 |         data =3D of_device_get_match_data(dev);
>       |                ^~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/sun20i-regulator.c:111:14: warning: =
assignm
> ent to =E2=80=98const struct sun20i_regulator_data *=E2=80=99 from =E2=80=
=98int=E2=80=99 makes pointer from inte
> ger without a cast [-Wint-conversion]
>   111 |         data =3D of_device_get_match_data(dev);
>       |              ^
> /build/stage/linux/drivers/regulator/sun20i-regulator.c: At top level:
> /build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: error: ar=
ray typ
> e has incomplete element type =E2=80=98struct of_device_id=E2=80=99
>   136 | static const struct of_device_id sun20i_regulator_of_match[] =3D =
{
>       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/sun20i-regulator.c:136:34: warning: =
=E2=80=98sun20i
> _regulator_of_match=E2=80=99 defined but not used [-Wunused-variable]

Looks like the patch was from when of_device.h still included of.h.

I'll send a new version shortly.


ChenYu