Received-SPF: pass (google.com: domain of linux-kernel+bounces-174591-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: brgl@bgdev.pl,
	warthog618@gmail.com,
	linus.walleij@linaro.org,
	Zhongqiu Han <quic_zhonhan@quicinc.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpiolib: cdev: Fix use after free in lineinfo_changed_notify
Date: Thu,  9 May 2024 16:33:08 +0200
Message-Id: <171526518127.18413.18287613546076931026.b4-ty@linaro.org>
In-Reply-To: <20240505141156.2944912-1-quic_zhonhan@quicinc.com>
References: <20240505141156.2944912-1-quic_zhonhan@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Sun, 05 May 2024 22:11:56 +0800, Zhongqiu Han wrote:
> The use-after-free issue occurs as follows: when the GPIO chip device file
> is being closed by invoking gpio_chrdev_release(), watched_lines is freed
> by bitmap_free(), but the unregistration of lineinfo_changed_nb notifier
> chain failed due to waiting write rwsem. Additionally, one of the GPIO
> chip's lines is also in the release process and holds the notifier chain's
> read rwsem. Consequently, a race condition leads to the use-after-free of
> watched_lines.
> 
> [...]

Applied, thanks!

[1/1] gpiolib: cdev: Fix use after free in lineinfo_changed_notify
      commit: 02f6b0e1ec7e0e7d059dddc893645816552039da

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>