Received-SPF: pass (google.com: domain of linux-kernel+bounces-174694-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Sender: Guenter Roeck <groeck7@gmail.com>
Date: Thu, 9 May 2024 09:32:59 -0700
From: Guenter Roeck <linux@roeck-us.net>
To: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Cc: jdelvare@suse.com, ninad@linux.ibm.com, eajames@linux.ibm.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hwmon: (ucd90320) Increase delay from 250 to 500us
Message-ID: <6ea76e83-f623-4bf8-9594-dc882cda6c81@roeck-us.net>
References: <20240507194603.1305750-1-lakshmiy@us.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240507194603.1305750-1-lakshmiy@us.ibm.com>

On Tue, May 07, 2024 at 02:46:03PM -0500, Lakshmi Yadlapati wrote:
> Following the failure observed with a delay of 250us, experiments were
> conducted with various delays. It was found that a delay of 350us
> effectively mitigated the issue.
> 
> To provide a more optimal solution while still allowing a margin for
> stability, the delay is being adjusted to 500us.
> 
> Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

Why did you not send this patch to the hardware monitoring mailing list ?
Such an omission all but guarantees that it gets lost, so you should not
be surprised if that happens with your patches if you do that on a regular
basis.

I am going to apply your patch (fortunately I still had it in my inbox),
but please keep that in mind for the future if you want your patches
applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/ucd9000.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/pmbus/ucd9000.c b/drivers/hwmon/pmbus/ucd9000.c
> index 8d9d422450e5..d817c719b90b 100644
> --- a/drivers/hwmon/pmbus/ucd9000.c
> +++ b/drivers/hwmon/pmbus/ucd9000.c
> @@ -80,11 +80,11 @@ struct ucd9000_debugfs_entry {
>   * It has been observed that the UCD90320 randomly fails register access when
>   * doing another access right on the back of a register write. To mitigate this
>   * make sure that there is a minimum delay between a write access and the
> - * following access. The 250us is based on experimental data. At a delay of
> - * 200us the issue seems to go away. Add a bit of extra margin to allow for
> + * following access. The 500 is based on experimental data. At a delay of
> + * 350us the issue seems to go away. Add a bit of extra margin to allow for
>   * system to system differences.
>   */
> -#define UCD90320_WAIT_DELAY_US 250
> +#define UCD90320_WAIT_DELAY_US 500
>  
>  static inline void ucd90320_wait(const struct ucd9000_data *data)
>  {
> -- 
> 2.40.1
>