Received-SPF: pass (google.com: domain of linux-kernel+bounces-174699-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <fdb287c4-1db9-425e-84fc-013ef539cf72@oracle.com>
Date: Thu, 9 May 2024 09:40:31 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] mm/memory-failure: try to send SIGBUS even if unmap
 failed
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-2-jane.chu@oracle.com>
 <d5dc761e-3f66-99a3-5325-dd2f161235cf@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <d5dc761e-3f66-99a3-5325-dd2f161235cf@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WlhlTjQ4QlNIT1FFTDVFQlBvZ2xWV0YwaFlWemVGNGVvT29OanFISW0zWDRT?=
 =?utf-8?B?Z0NTV0RxNVJqdWVXREhWOTJHWjVMVjNWaTQ5clpvTVZxMmUzcVlBSUpiVUli?=
 =?utf-8?B?VUZwQ0twWnZkckI1UW1seUxROHIxby9xSk9FQTB5NVFjU3QzSVJMZWZwOXdL?=
 =?utf-8?B?UDFPc0NoV2pqYkE0cnlmMnRidERZYnVyR3JqZ3Z4SmtMeGp3RUd1aExyVi82?=
 =?utf-8?B?anUvbEZZaGhQOFZzVTFzaXBEc2pYNmo2czZiZEJRaGhnQ1hWQWM0SlhWS25I?=
 =?utf-8?B?M0h3V1c1eDJuL2RITXZhY09CL0F0aVB3TmdnZXQwS2trWDllSlczZFpSVHIx?=
 =?utf-8?B?VHM5Z2p4V3F0ZTdyL00vT3hNVm1mUE1wcnVZQkZZRC9IQkh2MjhwZzdvaEU0?=
 =?utf-8?B?Y0Y4SWpOWS9INmpWdnIxRzI5S3h2QTQwanVCTi9ySGdBd3dyb2IwSTZqaW50?=
 =?utf-8?B?MGpOZ05lbEZveDlqV2s5NWtQWnpNblVGdUxlbVo4Z0grQWZOQjAzSkJmL1Vm?=
 =?utf-8?B?ZWFSY0QrSzZBVVBzWmhOejlnRys5c1l4QThocXllZUYrMnZCdTVaZWs2Y0sw?=
 =?utf-8?B?eEJnUWVyVStmSjNjYzNxQmlGNForNTlrN2pwRnFMNVIxOEdBTHo4Z1FjQlNP?=
 =?utf-8?B?R3N0TEt0OU84eGpzbXNHc2R0Rzg2d1Fma2JJREdFc240bldlUkJkbUdVdmps?=
 =?utf-8?B?OFl6M3BpM3RiM1NrcW93d21UVXhRbEhsWEU1SjlzSnlJbDlOZlpNWjRCUWZs?=
 =?utf-8?B?L3cxMjR5NWpNTUtIV1VxNHdTUGc2YlYvaHV6Zit4ckw5SEF0UHNiWHZ1NVg2?=
 =?utf-8?B?WS80RUVscW9xZFg1UDlXY3pqWVJqcWJKVUgyaFBpVW1wR244R0NQdW1tVEhS?=
 =?utf-8?B?cEtvbURySHlMM0VTeHkrY29ucFAyQktpREVMQnc4SkU2VUhmT2hWWExKenB4?=
 =?utf-8?B?STJpZkZ2cWFSMFBHQjlFNkdNaTdJQ2V5N2xNbUE4ZXdBdDdwd3BmUFUwZUdH?=
 =?utf-8?B?ZURPWjZXQlR6amF4VUtMcGRqS3picy9zTVpnWVZnMlZJakcvK2JKM0ExWmVl?=
 =?utf-8?B?alVwOTZWVjBFUHpwWkVNek5KdjhiTEVpT3o2YnA5VVdlS1RwOXNUbkZqbHN5?=
 =?utf-8?B?ZUxEVm16K2lEUjVTN0RXZndIaGlSNHk5WEx1Z2lDRWhZT1N4V1g0VittaGdG?=
 =?utf-8?B?a3ZxR0RtSXpsMzlmV28yZmViTjRHcTVXeDJGSUNZc0hwbUpjMXMrakJRN09P?=
 =?utf-8?B?emtkUDJ1QkZiVmJCdEU0b0pqcC9Ld21pd0tLdXdVbjhpTENtUHBVTitLeG13?=
 =?utf-8?B?YkoyYzVLSlBnSk9heWhaUS9mTFRIdW9pOVJhNDNldm9hcDg5Rk5SWXF6YWNR?=
 =?utf-8?B?Sk1hc0RqM3I2V1lLb1QwMXlwRGU3WUk3VjlOa045S0I0ZUIzYUt4Qm9RL3lD?=
 =?utf-8?B?ZXkvSThoemNmT043eXQxUlJlZUcxbnZDcDZsOEpOMW5NR3U3dUNsM1JnZVhn?=
 =?utf-8?B?YVJvb05YRmJGenhXNXMwUTJ1UXlNVStObThyTTZyU1k1YXZwMWlhQ1JLNjMz?=
 =?utf-8?B?RWJBQ1NIbGYydVdubWpSdlp2UTZUQ2FUN3FCdU1tZmI5K3Ywb2dHSmdsT3VN?=
 =?utf-8?B?cDc3K1JPc2NzU0pKcVZWTGxhakxXUnFnMGFLOE9VeE5DN0ZHdDBhSGx5aFZX?=
 =?utf-8?B?VlFNN3E5Rk9FOFNFd3NYeGtPZFBPV1JJeXVzMWZuYy9Ba2oyNURjVHlRd21l?=
 =?utf-8?B?SFdwaHU2c2hRMHc0dGYyakt2TGlKUlVLUXl2M1VCK0pFRTdvSDdVcnRVblgv?=
 =?utf-8?B?eDZHQmx3aFV6SUJDNVovTzdlVkdKd3Jrai9JbUFGSEROVE9QL21rRllPejZn?=
 =?utf-8?B?WnZLRS9wMGtybzgwUU1DRUpKNjBtL0tlc1N2cTdicE1nMTlMRVkydEVzaVpI?=
 =?utf-8?B?ZTJxc25OOUdwT0xBOTVDQ1RSTkJiTjBKS3JnY3VPbnR0L3FzTE9PVm5NMUUz?=
 =?utf-8?B?ai9Kc1l4dFkwK0RUS0NtVlIzdmtSRStTdWpjVzNXYlhBb0VpSDBFcG95a0M3?=
 =?utf-8?B?ZG9yS2pqZHAveE44OHYyUk0vblNucFNPd2I3RWtTWkE4M3JXNm9NeTdTNVlY?=
 =?utf-8?Q?J4Au2fVWvjwPeHXx6RotS3t2x?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	bnTjpZR9spZQ+K0rauxPdauv1vHoyn0WEF462tUOw52b2fksAyuxfItE28lLiJBBKMYsyBgQYLMTvDx+6KDvL7xjyUcADifIPjhHN4Ui1+9K7uLpKQvmQ0aP7+/arY9JLtAc9pHYFvA4v7oh/CdKXO2J9FlNIbDDxKz3GP8brtXAcLyA1fRW2kvt26cjykkVsMQx+ovhJbTGmXxvrxdGq7ZxukewBAraQ0Vwv9IB5GfxlQWrQUh62bCo9d8yBJ3NSezn/yhu6pFaGMLpKW1EquOMLEBLP4QI9MIKHw+UKl3/bo8WcOnUE3MvUtpNPqFopIzGees0P0Vn5CMEUyx33u0KXJlDBMepiPg/M4cCcTpXqmlxGRoxK+YzsTiDHChC9rQoZT5MpaG/CkT06XxEyEys7O2w3IAMANtBPP41n0fWcydc2cSv4jru4DNJGkycjuQkyp2iBqbGNtZipr9fzkZJEREgU0DGMxGAZH4aiVqQVYFD+PHkp6OSXk2U3XdL3wXkj2wgyv7yzUMKy5FHN7HZsum8ADGu3Cvzb1Z1ebYAwWEkHxMRRTlAuNilYLUuJnDAg4hzguNlm/CBQBZOA5mzQo2ShNXQ2MiuCKJEQqI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86d39adc-07bd-48f7-4f6a-08dc7046bfb5
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 16:40:34.7318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D1gu4cxH/6fv7mQkTODhkZf0Go9MH83e4Kf34r3EoxlikH3NgEcHLq7Zw0pkfW6nEKl/VXwOesojoQBygssXXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7852
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-09_08,2024-05-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405090114
X-Proofpoint-GUID: ui_I6HkRp1tKVVdVklFCXJzZdY7a1Lg8
X-Proofpoint-ORIG-GUID: ui_I6HkRp1tKVVdVklFCXJzZdY7a1Lg8

On 5/8/2024 7:54 PM, Miaohe Lin wrote:

> On 2024/5/2 7:24, Jane Chu wrote:
>> For years when it comes down to kill a process due to hwpoison,
>> a SIGBUS is delivered only if unmap has been successful.
>> Otherwise, a SIGKILL is delivered. And the reason for that is
>> to prevent the involved process from accessing the hwpoisoned
>> page again.
>>
>> Since then a lot has changed, a hwpoisoned page is marked and
>> upon being re-accessed, the process will be killed immediately.
>> So let's take out the '!unmap_success' factor and try to deliver
>> SIGBUS if possible.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>> ---
>>   mm/memory-failure.c | 13 ++++---------
>>   1 file changed, 4 insertions(+), 9 deletions(-)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 9e62a00b46dd..7fcf182abb96 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -519,19 +519,14 @@ void add_to_kill_ksm(struct task_struct *tsk, struct page *p,
>>    * Also when FAIL is set do a force kill because something went
>>    * wrong earlier.
>>    */
>> -static void kill_procs(struct list_head *to_kill, int forcekill, bool fail,
>> +static void kill_procs(struct list_head *to_kill, int forcekill,
>>   		unsigned long pfn, int flags)
>>   {
>>   	struct to_kill *tk, *next;
>>   
>>   	list_for_each_entry_safe(tk, next, to_kill, nd) {
>>   		if (forcekill) {
>> -			/*
>> -			 * In case something went wrong with munmapping
>> -			 * make sure the process doesn't catch the
>> -			 * signal and then access the memory. Just kill it.
>> -			 */
>> -			if (fail || tk->addr == -EFAULT) {
>> +			if (tk->addr == -EFAULT) {
>>   				pr_err("%#lx: forcibly killing %s:%d because of failure to unmap corrupted page\n",
>>   				       pfn, tk->tsk->comm, tk->tsk->pid);
>>   				do_send_sig_info(SIGKILL, SEND_SIG_PRIV,
>> @@ -1666,7 +1661,7 @@ static bool hwpoison_user_mappings(struct page *p, unsigned long pfn,
>>   	 */
> There is comment above the forcekill saying:
>
>      When there was a problem unmapping earlier use a more force-full
> uncatchable kill to prevent any accesses to the poisoned memory.
>
> This might need to be changed too.

Yes, will do.

thanks!

-jane

> Thanks.
> .
>
>>   	forcekill = PageDirty(hpage) || (flags & MF_MUST_KILL) ||
>>   		    !unmap_success;
>> -	kill_procs(&tokill, forcekill, !unmap_success, pfn, flags);
>> +	kill_procs(&tokill, forcekill, pfn, flags);
>>   
>>   	return unmap_success;
>>   }
>> @@ -1730,7 +1725,7 @@ static void unmap_and_kill(struct list_head *to_kill, unsigned long pfn,
>>   		unmap_mapping_range(mapping, start, size, 0);
>>   	}
>>   
>> -	kill_procs(to_kill, flags & MF_MUST_KILL, false, pfn, flags);
>> +	kill_procs(to_kill, flags & MF_MUST_KILL, pfn, flags);
>>   }
>>   
>>   /*
>>
>