Received-SPF: pass (google.com: domain of linux-kernel+bounces-174728-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240509085758.123046-1-oushixiong@kylinos.cn>
In-Reply-To: <20240509085758.123046-1-oushixiong@kylinos.cn>
From: Alex Deucher <alexdeucher@gmail.com>
Date: Thu, 9 May 2024 13:24:03 -0400
Message-ID: <CADnq5_PB_6Cz0UuYh+jEZeuE0Ld4f_ehf_H4N_rO=-ZqdfSQdw@mail.gmail.com>
Subject: Re: [PATCH] drm/radeon: Delay Connector detecting when HPD singals is unstable
To: oushixiong <oushixiong@kylinos.cn>
Cc: Alex Deucher <alexander.deucher@amd.com>, 
	=?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, 
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org, 
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, 
	Xinhui.Pan@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 9, 2024 at 4:58=E2=80=AFAM oushixiong <oushixiong@kylinos.cn> w=
rote:
>
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> In some causes, HPD signals will jitter when plugging in
> or unplugging HDMI.
>
> Rescheduling the hotplug work for a second when EDID may still be
> readable but HDP is disconnected, and fixes this issue.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/radeon/radeon_connectors.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm=
/radeon/radeon_connectors.c
> index b84b58926106..cf0114ca59a4 100644
> --- a/drivers/gpu/drm/radeon/radeon_connectors.c
> +++ b/drivers/gpu/drm/radeon/radeon_connectors.c
> @@ -1267,6 +1267,16 @@ radeon_dvi_detect(struct drm_connector *connector,=
 bool force)
>                         goto exit;
>                 }
>         }
> +
> +       if (dret && radeon_connector->hpd.hpd !=3D RADEON_HPD_NONE &&
> +           !radeon_hpd_sense(rdev, radeon_connector->hpd.hpd) &&
> +           connector->connector_type =3D=3D DRM_MODE_CONNECTOR_HDMIA) {
> +               DRM_DEBUG_KMS("EDID is readable when HPD disconnected\n")=
;
> +               schedule_delayed_work(&rdev->hotplug_work, msecs_to_jiffi=
es(1000));
> +               ret =3D connector_status_disconnected;
> +               goto exit;
> +       }
> +
>         if (dret) {
>                 radeon_connector->detected_by_load =3D false;
>                 radeon_connector_free_edid(connector);
> --
> 2.17.1
>