Received: by 2002:ab2:6816:0:b0:1f8:1780:a4ed with SMTP id t22csp35342lqo; Thu, 9 May 2024 10:27:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVqQEe/iXmp+/Jb1n+EecSAwAxYfWknL9R54N7la8NB66E+/3qecN306dSi9AbK/tXfS4LZvyR9UwnEYdrMlzgbWdQ2kZJnkHq5mFRHTg== X-Google-Smtp-Source: AGHT+IH9yLJaVs/Z0ROZVsdqG5drfaOCS6V6kgxRKPbYPLWgWKeHd9BneAycwD2l5O9+SWr0JsYL X-Received: by 2002:a50:ccc1:0:b0:56c:1696:58a8 with SMTP id 4fb4d7f45d1cf-5734d44fe63mr343407a12.0.1715275652453; Thu, 09 May 2024 10:27:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715275652; cv=pass; d=google.com; s=arc-20160816; b=NNcvAoZBdBy8UQWPhqklIivEHjLNvmjLgPk26k07IIVsa97OW2/kMEGL8P/aomkqW9 c7YUnocFCSoMXZnhMpxMMqR01SNfT1BKgKdR06qGFSJBasXP5UQlKoZ2uiKTQXib9B9t IinXSBTm8erToqsO2s8mLQ+VSYRU5gogRTx9jG/idWZaIEno1bfpPq++RNxlTI1FRY3n bJBut8evS3VwJWmYYKxXrqGD/aD6boapZNHKaSwDuCefNgAMDwAdvEMoN7TU/78tEkEo n9SqplSbwjMFfXnDMGUPqdZBPg/zf7yyKg6r5hL65gqg5aWnaD/ULzakM4d9fk4VvCTQ oDnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=P/Yh6fmWOx0S3hHFDnR/3XNxSMU0c5O7DQ9VhEI3qZ4=; fh=4f5BC0CYglSj1JPTqRb7l7pDPieAv+Ew1B90P5z057U=; b=wI1nUWhiMSRd9PKrzM8AHqJ/W59/DTB6qpybdw/mK6GhfpUr8741BtYkeYmb5cdwZ6 fzRti5qE0x1KefMYSLMo1P2Nu2HQ5SoalCgYBS1N7/llSLM6uAKAYzNjr1EU5Y4rxdyI hkIzjCPRM0+oNyT8DorFJ5xNYITlmFhhliJ2n0XcJ/djY/JsGqTtgUnXZgXNYVVjnVTd +MxgS/yOnP5bOmHEYznifzhCA482d+ww0eRbVjHo+X0HWc8RwwLacd0KzlkwU3ipn+fg kLAr6tDJkQ++fUVq0u5kx/F5VRKEZNLI8pGPf7/YdjrQQEK/sORCBK1AYLmg1Qdynue8 Lzhw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Ee/2otxe"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-174506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174506-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733c32c55esi1064293a12.439.2024.05.09.10.27.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 10:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="Ee/2otxe"; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-174506-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174506-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5B7BF1F23558 for ; Thu, 9 May 2024 12:40:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B21F713B5B6; Thu, 9 May 2024 12:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ee/2otxe" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F25513B2BB; Thu, 9 May 2024 12:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715258409; cv=none; b=rMF8CZatXp46Vkf1Gniy7fih2RCbFo1vnSwGDTnPwzcv96gKkiPSvG6YwAkHGiK5MfQ3Z2YGZ769mE8F1DLlBw+f2VMuhFltFY1ndhaUpTgyeQ5sk/y4WyVzBPVl5f7kYOYshGC9vFDKokCZyvYHpNEJWznnAgk91PFfqGDBQeg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715258409; c=relaxed/simple; bh=o4EJzw5BUXuBgoy2uU4zb1qMLA37I4KNAPe8azdAsNQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UdxdhDeNnXWjmQGNtV4e7YlWadJAOU+vZg0hYOTC4Ip/kBGHZhePfbn0K3Nh1T+0VTprg9EZZWYCuCKr3Yuw8sCujWm2tDUlD1CvsraJkWsuDhM7Xqu3ovDZ+d/tEjkUzQRQFJsdhWelrX9osv2joFyhy7dGRJbC1y5mAI5coCU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Ee/2otxe; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=P/Yh6fmWOx0S3hHFDnR/3XNxSMU0c5O7DQ9VhEI3qZ4=; b=Ee/2otxepDaoDyWBcWwFyiIctq nqoj0uR7R7rKU2RVLehLlBSEbFOIzg3Ei49vP9t0eZfHXbnK7Clo4ViqVb2Eja8jvDoFoOTO7KzS2 mx0+KGb840gHS36HB/TO+kOV3kAi9xSNAap53ofcOVYJn54tWWpd/4UJL62TiOyvKVqCS9AMgY1H1 E8R41KbrN0wd6lmELud0Aer8PlF9GNud2sqoOAkxfMREoWS8Fpdn+2hR+mRQyF706nSm7HCCNFC7P sKuzRooBCw5ovFR3K20jpikuGw2ivt218HNx5m6JJwCgrgrc3OArj4I8OPVW2Pp+0bUA1SLr+L/1P 3czW+isA==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5343-00000001STi-2Jqg; Thu, 09 May 2024 12:39:59 +0000 Date: Thu, 9 May 2024 05:39:59 -0700 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Andrew Morton , Matthew Wilcox , Jens Axboe , Tejun Heo , Josef Bacik , Baolin Wang , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com Subject: Re: [RFC PATCH 2/2] mm: introduce budgt control in readahead Message-ID: References: <20240509023937.1090421-1-zhaoyang.huang@unisoc.com> <20240509023937.1090421-3-zhaoyang.huang@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240509023937.1090421-3-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > + unsigned long budgt = inode->i_sb->s_bdev ? > + blk_throttle_budgt(inode->i_sb->s_bdev) : 0; The readahead code is used for all file systems, you can't just call into block layer code here.