Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp54lqo; Thu, 9 May 2024 10:41:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWEr3i3oTq+VeO1/Xjs088WsK+7y0jpiQJBzk5OeoDpHTqnOfUGHEzZZmTXwXaQwRwECgd4O1gKtKY0gDLaCd5PyFYkhsH0NbdsaG2BAA== X-Google-Smtp-Source: AGHT+IHQMlBc9p+WsZLI9qQ1qG38ZUpofriaIdyvB1e8aIpIKoG0Lrw7+CDLntLdYS2PAi22j1mf X-Received: by 2002:a17:90a:2e84:b0:2b2:7e94:c5e0 with SMTP id 98e67ed59e1d1-2b6cc758cfemr171823a91.20.1715276506380; Thu, 09 May 2024 10:41:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715276506; cv=pass; d=google.com; s=arc-20160816; b=Dvm4oNJYiDTVKuvw0TN11lem3jVguxYNhOfSw/oxH597F82NUH1vHdLNUdyfWrwiBt N5MCcvS1825chWQAWtbFTMH3GKXOSeotH35hqZZnL0ieh+6z7quqgkzxBVSs8+1KkXi2 UI2eH8G4x1ZLMhYlS2oNWxyS5E0E2Eo194ZVNSEblglhFcf36bvHgbZi9GSCTMD1hIzM Gr4cVzxRh/xd3aM5Ad1kSdZAVHnoL1E2D5B/QMVpDMBthRSM2okqpqHp6DV+3Gm4wI8q bqg5vFOfZmEOOBs3yO8XqNVba5lMyvt+HqOi0NingLidE/3HPQA0Jb5ZJYVwSi6pRHc/ Zxhg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=GM2ZvWKiybToI5Jaia+X595p1zDl/fOsiHCGflbLSrA=; fh=00LNzTwzr6bVCOk1Vc1vzH0d5JR45K48BfBINaSaC1M=; b=c+R1LYfZ5J6WYBcwMjNJs/s1zmQwhOwgtlEwsrHnxvinBCbMS8n4bmxTH95CW+tDzs 9E6wZijVrtUqjOKrf0RxkzM/dr0RIGubIUwCdX73Z9d71Y2xLqba3BVL5bcyct5BoOaR XBkle+aYteLRE/FiK6RcQ8iQ1SrCCR7MkW5CaQYRKvwq3shzk6QhIZloxC76/TV/VLZQ o3HdcjNAIpIefY3JalxOrRcZNBhX23G41Xt9BJIVQPDV9FAc70oINSO3TkKM1q1DjdjO HiXcSPussTcrzip0G7iMiX4M/p2YjTmsPkZ5YqH2hScJe4slCL5iv/ePD+GKEPs5fdR3 qz7g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gAvvjhHC; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-174742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2b62886874fsi3961229a91.36.2024.05.09.10.41.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 10:41:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=gAvvjhHC; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-174742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174742-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F2FEA282AE0 for ; Thu, 9 May 2024 17:41:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 17ABB6A35D; Thu, 9 May 2024 17:41:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gAvvjhHC" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE43954744; Thu, 9 May 2024 17:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.8 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715276491; cv=none; b=VQAw9nB2XDxhFwl7akPSyOns59hY6T5B6/fBppYZbWviJ1kY+IUQunfGiy/r94uCwvXsgwbW2/7s07UELk9LZJwqdAUoJD/m3wxhdSv6N5wIknk0W2qFxCh23KzuMJQr7urkFHoTWRd59IFOKCL1bpDUJZzeEy85l9aYN7XcJ8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715276491; c=relaxed/simple; bh=TvAv6RIRdJ6UXYVDyY55mGFngtRMP3lARVmH25SoP6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i5xghisjQvBRZbmBPdW0r+kMIKSKJteRzN+3+Nez9vlZGg7wHPgzk9SX869G4D7j1aFU2P88qAfoKDsXejo+7grRidK0Mnwh4vMXJWDmXOEKLOJs8DIrBWu685bEYR+IwW8jlpFNCOF28G81usc68NxeVxZk4LkHr7lMXVBQhTM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gAvvjhHC; arc=none smtp.client-ip=192.198.163.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715276489; x=1746812489; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TvAv6RIRdJ6UXYVDyY55mGFngtRMP3lARVmH25SoP6Y=; b=gAvvjhHCkS13wMgj+iBn52u1x6OAwzqw2yZ1Qxr2UTKqyAGe0DpvStG9 Ns3FreuLocG0lbw58qWkM5rfoDYA/mKvlJpSkX0J0vlCp1C+uYXY7Qnsk zo57g3QR7cwUocs4xqO50nZIggqUV5hlht6G6QkdVookMfqbO0DY3YH/a K+EErZ2NV40jNbP5hm++PJgCUDcyuXKQhu6yTgEsgZ1xE6xV7BwTRx3Ti EHMtJL2vh/72G1BW24mlngyhQErhpVDPhNbYagXA5e3El+nGd4ZG0GtDc SZUcNsSuxO7fs5sly0XqFmnQFYr0rYkRhPfLroE/zQbt0WXoUQ/ye0D0Y A==; X-CSE-ConnectionGUID: 4Aj0kh4PS0G/MBBRd5ukUA== X-CSE-MsgGUID: z7z5+KjbTG+h+1eluX0Dgg== X-IronPort-AV: E=McAfee;i="6600,9927,11068"; a="28726535" X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="28726535" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 10:41:29 -0700 X-CSE-ConnectionGUID: jpyht6XkRlOFAwJvw10NOw== X-CSE-MsgGUID: BfaaeqSWTHCej6QY8wZyYQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,148,1712646000"; d="scan'208";a="29264745" Received: from epinckar-mobl.amr.corp.intel.com (HELO [10.209.98.74]) ([10.209.98.74]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2024 10:41:28 -0700 Message-ID: Date: Thu, 9 May 2024 10:41:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] x86/fpu: Extend kernel_fpu_begin_mask() to initialize AMX state To: "Chang S. Bae" , linux-kernel@vger.kernel.org Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, tony.luck@intel.com, ashok.raj@intel.com, jithu.joseph@intel.com References: <20240430212508.105117-1-chang.seok.bae@intel.com> <20240507235344.249103-1-chang.seok.bae@intel.com> <20240507235344.249103-2-chang.seok.bae@intel.com> <7e589b35-4ff8-43fa-99dd-d3b17f56d3ea@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/24 10:36, Dave Hansen wrote: > + restore_fpregs_from_fpstate(&init_fpstate, > + fpu_user_cfg.max_features); There is *one* subtlety here. This assumes that 'init_fpstate' has AMX marked as being in its init state. But I think that's a pretty safe assumption.