Received-SPF: pass (google.com: domain of linux-kernel+bounces-174757-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240509100148.22384-1-osalvador@suse.de> <ZjzO4xH97Lu2UgEu@x1n>
In-Reply-To: <ZjzO4xH97Lu2UgEu@x1n>
From: Axel Rasmussen <axelrasmussen@google.com>
Date: Thu, 9 May 2024 11:13:50 -0700
Message-ID: <CAJHvVcjP6PS-m4dTTTF2MhDiaZ_U9WPfWO=JZZwGpHaA8o=qtA@mail.gmail.com>
Subject: Re: [PATCH 0/2] Minor fixups for hugetlb fault path
To: Peter Xu <peterx@redhat.com>
Cc: Oscar Salvador <osalvador@suse.de>, Andrew Morton <akpm@linux-foundation.org>, 
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	Muchun Song <muchun.song@linux.dev>, Liu Shixin <liushixin2@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 9, 2024 at 6:26=E2=80=AFAM Peter Xu <peterx@redhat.com> wrote:
>
> On Thu, May 09, 2024 at 12:01:46PM +0200, Oscar Salvador wrote:
> > Hi,
> >
> > this series contains a couple of fixups for hugetlb_fault and hugetlb_w=
p
> > respectively, where a VM_FAULT_SET_HINDEX call was missing.
> >
> > I did not bother with a Fixes tag because the missing piece here is tha=
t
> > we will not report to userspace the right extension of the faulty area
> > by adjusting struct kernel_siginfo.si_addr_lsb, but I do not consider t=
hat
> > to be a big issue because I assume that userspace already knows the siz=
e
> > of the mapping anyway.
>
> Acked-by: Peter Xu <peterx@redhat.com>

Looks correct to me as well. Thanks!

Acked-by: Axel Rasmussen <axelrasmussen@google.com>

>
> --
> Peter Xu
>