Received: by 2002:ab2:6a05:0:b0:1f8:1780:a4ed with SMTP id w5csp105580lqo; Thu, 9 May 2024 14:09:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVnYZOGL+zu2sY73x5sJjz/SF3NRH/X6dL8DDa4MiLhwNYTb57II8/LzngA08KwNLPywCjNc4GBE1IfL6F7ZOOTQg3Ib3lU/OWfEd03xw== X-Google-Smtp-Source: AGHT+IE6ZikcF5aPUNFjsDeNk+bwWMdYpE+1Q71qx3ghecRrZXTZ4353LLuKEKyTXABwq0OK+o8V X-Received: by 2002:a50:d65d:0:b0:572:3483:8a27 with SMTP id 4fb4d7f45d1cf-5734d67f8f7mr651422a12.33.1715288984631; Thu, 09 May 2024 14:09:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715288984; cv=pass; d=google.com; s=arc-20160816; b=LyVh6E+dopY0v5PIosN/6HH9KoyMCrbrgiYV5UjRs9DRPVKisM3kOAQIv5K34hA/yj bcGUPisJSo4rEemO0rXv182KU18buMMySgsYgc1x5FgFOtSrWuGa/bqALu10jsGHA6Sz HNEIktgAcm+UcEY72KBoKGqsL31cXkXAJEpFqf2gsKl+B9gw7lO3XTACO+omj9NZvfDp PLZaZ4OJpQpIaIyFmeAKu0Pq82qVV4v4GDmjhcxmd2xxy2FlsdllPLAJfcMFikADxYdO F6g5J++bgq9Y64+AEW0sIV+/SOfR/fHVo0RuL0dKFSVJhujK8YS5V9EBnqSoCNJjPpQr tmSA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=IL/Pjb6tjWhJpQQRsXDN6a0F0TkBXzEFnC2pzR1ugRo=; fh=Bmq/cl1yjlcFPrZ35lf31xX/vDikFR3vcZrLkxqwHqw=; b=VlUiqI8zSYYCknz2TNDPbvYN/2lTsj7si7S3bOe08Pn0JQsWkXuQYgZPrRlpDSuhwm 1MQCiA6EO8ZA2ZulSoC0e/UYWw+OLTyex+qbZiVgZmpvw3e8Cp9OWfFyQJ54Shrx8nIF Hu9eJYkzVHrAE2fdVEZBqSmx2QRlJXoNPZZQ7DRGUeBIgsABkdoRXLn6Dc8HKc6OwuKQ vSyzogodl0fgcjYbUQ3opYB6J5/eY+EDyScGMB64l4zCXnsbMKtxiIbO+ujgKFc3kxD2 DvpyK2vQbEKcNgNhTURxX0Z+MyP8zBnPqaIbTg7G9sOghZBhTRAuDsyCCxQSJAO5YnJl 7bPg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=QfOTS12V; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-174967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-5733beacdc1si1138700a12.61.2024.05.09.14.09.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 14:09:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-174967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=QfOTS12V; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-174967-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-174967-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6007D1F2220F for ; Thu, 9 May 2024 21:09:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 938118563C; Thu, 9 May 2024 21:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QfOTS12V" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9CF84A50 for ; Thu, 9 May 2024 21:09:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715288971; cv=none; b=JDnBdyXMox6QZbC0JirBd0gJ4Ljd5fGNKkVGEdUbE7PfrBhVPL5yykWsItX68swM2MdbzSUx6CfjSf1RtuxY2cfu7ph1d04Ey1tDJBNkagk1L1PySijmf9wJ/ciFaXKremq+XdCfrqjgEYXwCRCZzXwY7F9/c0GEsK+YQiYJpBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715288971; c=relaxed/simple; bh=7cnpsm3ib7QnJPl5zCKiOydDwPHEacdR7vNxGjiSv8Q=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=k8+qtmpxeel7nP9+F/zj8Vvmh3aPh9LvFR8B/8pgdQCtvAyJOHYdeblTjCiKky3j5+v3MqtiQb8p1yPNUl6HEGSYpxGvQsb8quFH4nHSzYijFBFzjwd7guS3hpc5tT7fx5MoAMONUraAb58r40Z6TjWDbshCsnM5NmRZr99V0bM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QfOTS12V; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-572aad902baso4967a12.0 for ; Thu, 09 May 2024 14:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715288968; x=1715893768; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IL/Pjb6tjWhJpQQRsXDN6a0F0TkBXzEFnC2pzR1ugRo=; b=QfOTS12V8fn4ISODCE15/1dK92LwmWbxTpigiSfIVgz/l1OTaw7ouQnXL5PESDqSDW qKsTRWWb7i1dfd3StQT5C+4t5Dj1e/w7OvVwVF8etWprZJxTKb1pFeGSA6m+c7DaqTru CyeQT8JLS9vEOPU2ATQQHhZuqRtwoxRWrJ2hcUPK0vT2jm/hTgwKqvcX9wr6k8xsR2qs lM2mIxOnvgcSr8Nz2X1shsIu+HqX82tTDVIO8vFqT3V+ehtqXxh0C1KijIqQcMW3+VWR f0PlD4XK9h96K1iiBBaojRDq1rKgbF+ZTo4Dt/LK+QpijSMjvNdeAloIQZsA8Xx2X1uY WxvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715288968; x=1715893768; h=content-transfer-encoding:cc:to:subject:message-id:date:from :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IL/Pjb6tjWhJpQQRsXDN6a0F0TkBXzEFnC2pzR1ugRo=; b=wY2k3y9BjaBJx1yuyzlm8etHP92M+A/1BZWdiOtQnMKsZSO4FgvWQn+Wf3t1LG9FxK zndx8XS88P/3NsP+wDurzXHtaY24ptTUZEXD2xTgbNruNT+4AnV/db3bUjIoQFOqppPq OZAfgAaDa/7orHg9uK29KoWenu5CBa1r9AYUT+YhAlc3beLafPZSBDSv6LDswnfWrPli kjFwvzMU8J6d0GBR68qTbeM+ndF/os99twsoGxm1DZL1s1yKigymDiVRIYKgxyUt0qLQ 4xUcEstzGwAuGxxGrjTfq/LCqdo9g4eoq5982OByQnVJ3DxTaJ0yOJE1FVpygSAmHpL+ F/IQ== X-Forwarded-Encrypted: i=1; AJvYcCWcph4x0M3vSTDxfs9Avn/CAx18yW3ARzRZo4aXTd0FjGarKeg9wYacroaZEoqX4+dElyF8hsOc1pBL7xLofm/Jj0qph7ValhAK+54q X-Gm-Message-State: AOJu0Yz2m9TUcfrZ2avD7X7wc1+NQUf1Cy39jQ3o660Pw5S04ETccjAX 4fZsTT6FBmIW28gXQGHgHbmg2ECzlvA52GoXZSJ4YS/Pl533E3PVAELfZ5imXY4i7MlQ6JMcw5E hFmjVmRpbfSfTad32WX9+Csg+HB/KYCuV/R+Q X-Received: by 2002:a50:85cb:0:b0:573:438c:7789 with SMTP id 4fb4d7f45d1cf-57351de5880mr9179a12.1.1715288968389; Thu, 09 May 2024 14:09:28 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jeffery Miller Date: Thu, 9 May 2024 16:09:16 -0500 Message-ID: Subject: Re: [PATCH v2] net: usb: ax88179_178a: avoid writing the mac address before first reading To: jtornosm@redhat.com Cc: davem@davemloft.net, Eric Dumazet , inventor500@vivaldi.net, jarkko.palviainen@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, stable@vger.kernel.org, vadim.fedorenko@linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Jos=C3=A9, I'm testing on the 6.6 kernel with a "0b95:1790 ASIX Electronics Corp. AX88179 Gigabit Ethernet" device. after applying commit 56f78615bcb1 ("net: usb: ax88179_178a: avoid writing the mac address before first reading") the network will no longer work after brining the device down. After plugging in the device, it generally will work with ifconfig: $ ifconfig eth0 However, if I then try bringing the devcie down and back up, it no longer w= orks. $ ifconfig eth0 down $ ifconfig eth0 $ ethtool eth0 | grep detected Link detected: no The link will continue to report as undetected. If I revert 56f78615bcb1 the device will work after bringing it down and back up. If I build at commit d7a319889498 ("net: usb: ax88179_178a: avoid two consecutive device resets") and its parent d7a319889498^ these also work. Is this something you have seen before with your test devices? Regards, Jeff