Received-SPF: pass (google.com: domain of linux-kernel+bounces-174971-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <91eeb2d6-e0bc-43cd-8641-ddede63f3786@intel.com>
Date: Thu, 9 May 2024 14:11:44 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/4] selftests/resctrl: Add support for MBM and MBA
 tests on AMD
To: Babu Moger <babu.moger@amd.com>, <fenghua.yu@intel.com>,
	<shuah@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <maciej.wieczor-retman@intel.com>,
	<peternewman@google.com>, <eranian@google.com>
References: <cover.1708637563.git.babu.moger@amd.com>
 <cover.1714073751.git.babu.moger@amd.com>
 <0367b45170fbc7411aad12c28802284a298c1c6f.1714073751.git.babu.moger@amd.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <0367b45170fbc7411aad12c28802284a298c1c6f.1714073751.git.babu.moger@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzJKR290d1dTditTNWw1VHJsejlmR1FWbGtsSEhzY1BxQm9ER3dzK2drbGlv?=
 =?utf-8?B?eTlLUDk0US82bW5JNDZ1YzJQUVdXN1JpcWJaczlsYytJMU9zL0dTZ3drb2xC?=
 =?utf-8?B?S0hNTk5NTk80WStacmV2VnpZU1FMN0pwdWtLdmNWV3o0dnhrbm94a0pTVVdu?=
 =?utf-8?B?czJhaG5Kc2hmcHprM0lVZktPR1c4c2sxamNtTGt3allLMjFDKzlhdHozZytm?=
 =?utf-8?B?VjN6WnFGZ3kvcFNqb2N5TnJocGJVUjNncVJ2T2huOGY0OG52R0pPeWlxT0FM?=
 =?utf-8?B?aXRtY0pyTjhsT1BjQUVyRHpxYmVoeDRRem94SjlyL25xYTJhb3RKMk1LYWV2?=
 =?utf-8?B?OWRad1cybXdZSndZZ01ubUErK1NoYytaekZDY0JscUMzQmZrYnVFcmpJZHpC?=
 =?utf-8?B?MFJhRnA5bUxPVFVlRUFtM0c3bFlsS2dlQWhKWS84eHcyS1YwQkhXdWd6Mzhw?=
 =?utf-8?B?TndOMmxVYWJCS2JWeVpGOTBiU0RlMEp3Sk00MFV4Q1g4T1QwTk1nYlYrSTJs?=
 =?utf-8?B?V2VRZTE0T1pQSzh1dDAzZExqcUgyTW9kYnQxdVVPRmNKdnVIZmNiVVh6Q3RK?=
 =?utf-8?B?bUUrbVpNSkNVdCt1Y0R3Uk9iVlZaQWtxNEkxQys5QVgxaHJLeG0vOWlKVDFt?=
 =?utf-8?B?clFEakpsZ05VWjBFQlU5VVhFQmtrQXFVZkhLMmN5czQ1NzNUOTJvc3JLcWlo?=
 =?utf-8?B?OGxVVjB3TjlCSGEwVlJxSFVKeE40dHpHaWdDVjNWaWxTSjMxVnlSemJNWk1q?=
 =?utf-8?B?a0tjNE8zeW56a1dWTTVGaGJacFJsem0xbVdtQkE0amRzMStFYzZiVVVYeS9p?=
 =?utf-8?B?c0EwcVhzOWh6dkFZUjJDbHRCMklUcEgrR1BlSS9GdmRJRllGckpWMHBscjBD?=
 =?utf-8?B?WFNTUzE3N25KR1N6dEhONWxLYi90SXpBWUN0RzdRU2FuK2lHWUlHcVFLblg1?=
 =?utf-8?B?anZ1TjNBWGp3YXBMbVFXVUc2eW9kSk94VUVXSmRHMEg0WE9sR2NzY1dKR3VR?=
 =?utf-8?B?RlZkQ1A5eEF3WmVlVXgzMzR0aDdodXpseUtwdkxFbEsxSEZZdFRBNHA3Q3di?=
 =?utf-8?B?aFVoMnY0ejI5RlQySklwQ2gvQ0hSbytsTnVVa1UyTk1aS3M0MmF5b3JINFhk?=
 =?utf-8?B?SU5yWnhKUkxMc0lWWWdrUWhVY1Jreklzd3QxdTlBVUZFY05BbkdvQ1hRa2h3?=
 =?utf-8?B?UWhGcUtvenZaenY1S0FpYUJ5cXJVMG16UkJDOGNxcVJpZldOaVpHY2p0N2NS?=
 =?utf-8?B?T01ta3JoeERsTDE3SExhZStCWDRmZ3o4NkloSllEcmFDUzVRVlZmajJzTDFR?=
 =?utf-8?B?TWNadjNIbjhoeWR6MVl0THJDb1U4QW8wQTJ5UkFrOStHd1NGS3ZLQ0I4NlQz?=
 =?utf-8?B?L0tUcWpRTng4U1dkaHhUY0FmcU8wQ2ZIVkdMSC9jSlg5TU1zUEpqd28zcXdk?=
 =?utf-8?B?TDVhUHR3UnMrdXZPWUwvYWg2MFo5SlBKY0U2WUl0QW44NkVyVlBmU256aG9a?=
 =?utf-8?B?cDBvSUt2a0R0WHVLUStQdFExOGEyT2o5SVpMOC9qOXk4aTYzTWhmS1ovVVpu?=
 =?utf-8?B?THFnSXNVbHNjaW9LSEphZWYzWjg1b3NMS1pwZG1YdzRIZldEZzRreG1PNFpI?=
 =?utf-8?B?RkFuVHVQbkZCVTRBSmxlMVVGRHZ4VkMzTHV3S0Z1d09hNG9yVjBDRGVMbUty?=
 =?utf-8?B?cHJ2dU5sMWZ4WENuVE9zdlk5ZXdjZ3lsUWpacktVNkZaQXJIVmliY3FPTE9q?=
 =?utf-8?B?WXRCT3VRTndLcllCRFhzQ0NjR0pjSHptMnRycXk1OXIxVm9ockVEemRXYVZ3?=
 =?utf-8?B?UjZ4NU02TnBYNFRmUjM3dUIybmVpNlVJb2pEN2w3Y3VSMkNpblAwaHp5aVVO?=
 =?utf-8?B?RndxRFpvTFNHdlJ1NE5nZWR0TDVhQnNoeUltMUxzajBLQXB0UHBIWllTV3pz?=
 =?utf-8?B?UThZd0pMMUZCUG9SSzFzYzhzUUdhT2R2UHlxRDBzdzMzemVNQm12RzF1OXlR?=
 =?utf-8?B?dnZRckNvUzVtaDMyTCt4dnhnZVUzTGhoc3lBakNYZTVVUnlpTGVpSmw1WldK?=
 =?utf-8?B?SkRnTllhcDZUS001ZVpuYzBTVVFZczJlbXlicU5GMXZETHh4Z2k5YnIvV0Fx?=
 =?utf-8?B?SUtDMGFsY3hUMjZpbTRzQW5Ka1BXZzhFb1BsV0dqTnQ2cWtlZWtLNVFWTFJj?=
 =?utf-8?B?RGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f8c10efd-c2e9-4c7d-2b4c-08dc706ca26e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 21:11:46.4916
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uWVbNrmrXrfrcA4ykPFii//sntgWkcUnad2MJOueocjbTJn7XkPszGbr2iEuALICte20chdTLOtzUKSwC59IGkzUbIIqLZTeax9UUCpJdNY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8008
X-OriginatorOrg: intel.com

Hi Babu,

On 4/25/2024 1:17 PM, Babu Moger wrote:
> Add support to read UMC (Unified Memory Controller) perf events to compare
> the numbers with QoS monitor for AMD.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  tools/testing/selftests/resctrl/resctrl_val.c | 67 ++++++++++++++++---
>  1 file changed, 59 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
> index e3b09128ec3d..d90d3196d7b5 100644
> --- a/tools/testing/selftests/resctrl/resctrl_val.c
> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
> @@ -11,6 +11,7 @@
>  #include "resctrl.h"
>  
>  #define UNCORE_IMC		"uncore_imc"
> +#define AMD_UMC			"amd_umc"
>  #define READ_FILE_NAME		"events/cas_count_read"
>  #define WRITE_FILE_NAME		"events/cas_count_write"
>  #define DYN_PMU_PATH		"/sys/bus/event_source/devices"
> @@ -146,6 +147,47 @@ static int open_perf_event(int i, int cpu_no, int j)
>  	return 0;
>  }
>  
> +/* Get type and config (read and write) of an UMC counter */
> +static int read_from_umc_dir(char *umc_dir, int count)
> +{
> +	char umc_counter_type[PATH_MAX];
> +	FILE *fp;
> +
> +	/* Get type of iMC counter */

iMC counter?

> +	sprintf(umc_counter_type, "%s%s", umc_dir, "type");
> +	fp = fopen(umc_counter_type, "r");
> +	if (!fp) {
> +		ksft_perror("Failed to open imc counter type file");

Why go through effort of changing to generic names and then follow
by using Intel naming in AMD specific code?

> +		return -1;
> +	}
> +
> +	if (fscanf(fp, "%u", &imc_counters_config[count][READ].type) <= 0) {
> +		ksft_perror("Could not get imc type");

Same here.

> +		fclose(fp);
> +		return -1;
> +	}
> +
> +	fclose(fp);
> +
> +	imc_counters_config[count][WRITE].type =
> +		imc_counters_config[count][READ].type;
> +

Up to here seems to be a copy&paste of read_from_imc_dir(). Could you
instead split read_from_imc_dir() so that AMD and Intel can share the
code to determine type?

Reinette