Received-SPF: pass (google.com: domain of linux-kernel+bounces-174972-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <b5b081a1-9e80-4173-8449-36d5c93185a6@intel.com>
Date: Thu, 9 May 2024 14:11:55 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/4] selftests/resctrl: Enable MBA/MBA tests on AMD
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>, Babu Moger
	<babu.moger@amd.com>
CC: <fenghua.yu@intel.com>, <shuah@kernel.org>, LKML
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	=?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>,
	<peternewman@google.com>, <eranian@google.com>
References: <cover.1708637563.git.babu.moger@amd.com>
 <cover.1714073751.git.babu.moger@amd.com>
 <e3bf1fbbe3ab2d9c2dc1d9669a791de140dea248.1714073751.git.babu.moger@amd.com>
 <911547f7-e952-f771-867a-57c1de738c39@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <911547f7-e952-f771-867a-57c1de738c39@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVJkZEU5UmY5Ulc2KzJKSEpTeWFwSkcva1dsc2lUODcxK2pRZzhmK2MyTG1h?=
 =?utf-8?B?ZXZETEgvTzFRbFhjN0tyV1VWZHllcFMxMGp2YmVsVk04R0tva0FDbElkbUxF?=
 =?utf-8?B?RFhDRThRVzB2b1RXdjFMT3R0VVFvWEJIRi8wNENsYnB5N3p3VnRRS2pjVStp?=
 =?utf-8?B?Q2cxYklkZ2trS3VUM3RXeGlrdU05SmRvZlFqdUh2TkhOYUpwZzhzNjRUKzN5?=
 =?utf-8?B?RGR6N2wxdzA5RGwxcnJhK1dBcFV6cWJxSzYxa1BHbktIL1dRNTlJVW1HWndE?=
 =?utf-8?B?THE4Tmx5YUFtR1VIa2s3RXJRMlY2ODRTaWQwWDFvNkpqdERFeWNJdTNiQnR5?=
 =?utf-8?B?dk0veDEwZFRFOXk2TE5nR0VSa0tiUnovWTA1enJpZTFRZDVycFVNSDRZaUpS?=
 =?utf-8?B?SVNRMWgyVDNEVVN2cm1ucFRsS0RsK001YlIwZkhLTDNtdnUraHJQS2x3ckpq?=
 =?utf-8?B?ZDhqdHpEUkU4anZTSlJteFpWN0w2ZzMyVVZKai9VMjZMMXI2eFI2cHI1MGsy?=
 =?utf-8?B?V015Zks3VDIyMzE0MHJDRVFyZVJ2SGJYL1RoUFlRbHl6cHBmVnpWSHBuTXF5?=
 =?utf-8?B?cjFiSGo1cW9leXJ6MEh5ZUF5UW1LbDdaRmpKK1pHR2pOcDdEdFY2R1VwZ1ND?=
 =?utf-8?B?ODgxdlhWQzBjRzFLL1NtdzQxeERwc2QxSTBmaFNUeDhhWFpQc1l3MHBnMWF5?=
 =?utf-8?B?azR5R1c3cjdhaSsvRXQwL3hscGVndVY0dlArRnN2MmthN0FnS3ZyWVZwbTgw?=
 =?utf-8?B?SEVmcXJqWTlWRk9MYmt5bCtlcWdYZFgwQm41QjJXdkNGcm0wNFludlBHU1Fa?=
 =?utf-8?B?azc4ZnhkOU44Z1hEd3VQa0Z6bnN1dC9vcmJZdUMvLzhMd0tFYnpqQmFYbGxH?=
 =?utf-8?B?cU4yV1NobzltaTBkWmxBSmhBdEFZdmlTUUFtYTVoZGpSb1REZStGQUpzZ3Vi?=
 =?utf-8?B?ekRvTi95OG1aSjV4VG1ENUxZYnd6dDA4MWhqNWxNR1VSZ2hWbzIxd0NsOVJF?=
 =?utf-8?B?TWREbTgzN055SnJ2Z0lkK2NsMnRIL1NxZjNrVUdaOGhxM1V0THNjc2d6YnZx?=
 =?utf-8?B?cnJXNDRpRjJHSlNDN1VtdGdMRzkybDZGUzh5dnNJQS9MNnBZMHJWVFV5Y0V1?=
 =?utf-8?B?NTRma1R0eEYyb1dCNzBmcS9IVlNOdkRqbm4vV3NiNXdJOEFQM3kzRUpvaHR0?=
 =?utf-8?B?NXErUXlIVWhxN3JubHBkVXR1NVpYbWVGVXZMbTl6eUJWY0NINWtrazlPRmxG?=
 =?utf-8?B?UVkvc0NIdEQ0MkY0SVpOc1Y2VnRLV2NSeDJVc012NklMYjNrbkdVakxncVlN?=
 =?utf-8?B?N0I0UWRhM2QvNGVqaEdlTzVkeVh3TU5ISHNLczEzanduQm5qZUQyQVBUb0Yx?=
 =?utf-8?B?OWpraXpWbnJCK2pBTU56K0dkcnVVUnpKWTV6RnBURVpkRGQwKzA1MjdRamln?=
 =?utf-8?B?Wkh4eWZrb1hqdzdPMEpkNTRsNHBzMmVMS0xSNVlEdUU2RzBXajBtKzAyTk9v?=
 =?utf-8?B?dWh4b0k0bzExNnpkeVlDSWlqamZIbVdDYnJwQzFQR2x0T1ZEa3h1a3FRUkFO?=
 =?utf-8?B?V0VLQ2RWQUVzMjhXb2xwYmd0RkYzR2FMZnJYaENERVFTNDRDUUIwVnRJMTEx?=
 =?utf-8?B?ekJ4RlZlR3FycVlHZnllK05pZ0VlZDQwVUI2ZmN1TmUxakpqOFd0SllHVGw3?=
 =?utf-8?B?SEhPNmt2S2ZaL3AyQXk4NXlGTnJueEZQVDVxRXd2ZFNMcmRRM3RzdU1qWG1K?=
 =?utf-8?B?aVRUbkg4LzBWYkx5RE9oRlpZby9xdk9BWFpxdDMweEkrTW5Tb2NoY1dmN3Z1?=
 =?utf-8?B?bU9ydmVJcDBhRkNUOXZFL1lhR2lBNENuVndYVCszMVZZY1RBcFlUWWtkTHF1?=
 =?utf-8?B?WTdlMGlxeExHUlMyVTk1NTRGemt4ZVBJQlhYWjVXc1FoRlhLTkVuWnFXMVpG?=
 =?utf-8?B?QmltZlhDR3B0YjNhdmg4TGVKVlhpQmc0SmtwUjRzMytGclp4eitmWGdGUmRI?=
 =?utf-8?B?bG40M2NPMXQ4eWlXTkpQa3hheU1LZWM5NW9XNGF6cUJPRy92a2RuUXJ1emJS?=
 =?utf-8?B?cnlSRlRMR0RNYnFjYk5lQ3lZaWxDbUxQQmNoUDM5UDVkYjlMcTM0SjY2Q3lD?=
 =?utf-8?B?b3MyZUhwck9EUUJuZUw5UkFwc2FMMENLYlRsZzlQcEgyUU5VdTlYbHZqT1I3?=
 =?utf-8?B?c0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 484bd863-eb3b-40a3-79e4-08dc706ca8f6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 21:11:57.4459
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C3nOJ36cawdrCdbYtGqGol8rB17efhT70V/hQLgflm0jH79E7ouRNs6T47SiYIKqbj8g0ch9+Fi/taShs3N/Z1WmKdxeL38vaxiYYICil3U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR11MB8008
X-OriginatorOrg: intel.com


On 4/26/2024 12:06 AM, Ilpo Järvinen wrote:
> On Thu, 25 Apr 2024, Babu Moger wrote:
> 
>> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
>> available on the system. Tests will be skipped otherwise.
>>
>> Update noncont_cat_run_test to check for vendor. AMD supports
>> non contiguous CBM masks but does not report it via CPUID.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>>  tools/testing/selftests/resctrl/cat_test.c | 2 +-
>>  tools/testing/selftests/resctrl/mba_test.c | 1 -
>>  tools/testing/selftests/resctrl/mbm_test.c | 1 -
>>  3 files changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
>> index 4cb991be8e31..b682eaf65bfd 100644
>> --- a/tools/testing/selftests/resctrl/cat_test.c
>> +++ b/tools/testing/selftests/resctrl/cat_test.c
>> @@ -314,7 +314,7 @@ static int noncont_cat_run_test(const struct resctrl_test *test,
>>  	else
>>  		return -EINVAL;
>>  
>> -	if (sparse_masks != ((ecx >> 3) & 1)) {
>> +	if ((get_vendor() == ARCH_INTEL) && sparse_masks != ((ecx >> 3) & 1)) {
> 
> This looks independent change to me which should be put into own patch.
> 

Own patch that is separate from this series. This should go in
as a fix with
Fixes: ae638551ab64 ("selftests/resctrl: Add non-contiguous CBMs CAT test")

Reinette