Received-SPF: pass (google.com: domain of linux-kernel+bounces-174991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <0e196143-c0bf-4d70-9735-7e6d9a69ea8f@nvidia.com>
Date: Thu, 9 May 2024 14:25:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 03/68] selftests: Compile with -D_GNU_SOURCE when
 including lib.mk
To: Edward Liaw <edliaw@google.com>, shuah@kernel.org,
 =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>,
 =?UTF-8?Q?G=C3=BCnther_Noack?= <gnoack@google.com>,
 Christian Brauner <brauner@kernel.org>,
 Richard Cochran <richardcochran@gmail.com>,
 Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt
 <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>,
 Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>,
 "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>,
 Jesper Dangaard Brouer <hawk@kernel.org>,
 John Fastabend <john.fastabend@gmail.com>,
 Andrew Morton <akpm@linux-foundation.org>,
 Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
 kernel-team@android.com, linux-security-module@vger.kernel.org,
 netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org
References: <20240509200022.253089-1-edliaw@google.com>
 <20240509200022.253089-4-edliaw@google.com>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20240509200022.253089-4-edliaw@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WUt1RDVUS1QxbzJjYTloN0ZCcXFObExTTngzOEE1ajV2M2pLVUU2ZzE2TW51?=
 =?utf-8?B?RkFHVHlSOVRVWlg3NWhWbS8xSDcrbWl5QTdCcWcyZjBzeDVpa1dtRm8yenQ1?=
 =?utf-8?B?TGdhSmwxeS8zY1VJS1h2ZDNIQTBVcTZCUzVVZERVZFRtNTh5cVFQWnY2emVy?=
 =?utf-8?B?cXQ1R1BlV2pRTXF2cDFjNmFTRUJHZUxxamJOZ1F0TXZ3L1JoZThNemlaSGtr?=
 =?utf-8?B?MmRRUklIQjl1L1NoTnNtZWZZNzdpYUFiSVV2aDRIQmtJWWJQN25hLytPdTVZ?=
 =?utf-8?B?RjV3dmNIMDdhSUFaRjVJNHJobzViTnBkdDF6TGszM1NhWHNiaXEvUFZSOHFr?=
 =?utf-8?B?UlpERVRNaUJ2NG15WnRESkJ0VEZFMWJVdERLUURRa0lZa1lyek5ySlJkZ0gw?=
 =?utf-8?B?RWZub1I5TjBCWitGdExodGxtYmN3TGMvZXVQczlyZW0wR3BLeDV2QTlyT1Vl?=
 =?utf-8?B?STlSdmprU2d5NVRtVTRjT2d6Ui9MUWlrMGtjOUswdnlrY05oODg4ZGRFdFMx?=
 =?utf-8?B?RHE0YmtmWlhwQVlscmNhVG5laytpZWJscWxVVDRkdzJyWjkxNWRiV1ZYQkZr?=
 =?utf-8?B?bERjejhZbXByMVNCeUpJTzBMQlFvaGVjWUllbnpsMUFzUGo0QWJNNU5kVlJ1?=
 =?utf-8?B?bW9mSEVrUlc4ckttQzhyazZjNzJILzRteXJkVmFrczRYZzIrOFZzZ1NweFp4?=
 =?utf-8?B?VWdTTEpxbnFqU3BFbGE3R3RzL2pXaHlQUTkvMWowN3dmRUFLTWpIUnhjTzlD?=
 =?utf-8?B?UnJyVTdWMXNBNUx6WHV1OU0zbGZJRnFxaVpFNzRmMkxWTGorbjFZL1MxS1F3?=
 =?utf-8?B?eERHRE1XUWdoZ3dlVlNjZkNsK0pHL2dJRmdMZ21iM2lXaTJtMmE4K1F6NG5S?=
 =?utf-8?B?MmlHM21WeUdWdmI1VnVCckpRMjlGV2VHbytkbUl6MmQ0dmo0bjZiZm9BcEIv?=
 =?utf-8?B?VzYxTUNMdWlTc2Zlb1lMUksyNVRGMEZtTmJTc3cyUG12bklDREUyQ0YyVFF4?=
 =?utf-8?B?SFN0eHAvYkp5dXVvNTNLdGZlaEpuZGJoQnVld3hjQzJYaXlDeTlOR3Y0MDFK?=
 =?utf-8?B?a0FBaDU3aGdLbUxuWlVNd0pyZkhjMGZVQ0NTT3ZsdVdLcFhKcTVpR2xZVGtZ?=
 =?utf-8?B?dU0yVUhSejAzNy9lQ2xNdEkzaDdBYjdVQXErSno0aWU4M0VlS21yQWk3L21L?=
 =?utf-8?B?VUxpQ0NnSG94cmE4RGRrdFJYUitOQS84aHgyTXJhZVkvUSt4cjYxaWhIY1Jy?=
 =?utf-8?B?enE2S1NxbnYxSDM2cDUzSU9GZTgyUVlkbjl2K2tzZlhYbjQybjk2cUZ4OXJP?=
 =?utf-8?B?SnpjMnM4dDZwU2NDa1Nud2FLM2NkNFF6ODdpODhpWW42THE3NHM2UURRQW1n?=
 =?utf-8?B?ODMxVTNGQ1lvM094QjRxVlozMGhzWUswSjVHK0Z1QW5GcXdYRWhSaFpoWVYx?=
 =?utf-8?B?SmNobmVYdlVWSHg5cm9kdm04b2pQYkFxditIeGQycHpzL0hPbTJVd0oxK2Fu?=
 =?utf-8?B?TldjUHNiaXFHUlNycUVhZFFkWG9iczFCMFQ2bm55SDlHaEFvd1FOb1AvYzNl?=
 =?utf-8?B?MUluYWZmSy91REZ2ZHU3UVZGdjhHaG0vNHZVU3I0YTZxeENGeVVaek8xN095?=
 =?utf-8?B?MHBiT1ZPZS85cHZ3Z3NqNmFPQjhONDZTcE5xSjZIUWY4eWNhUVZSNGlOQmYr?=
 =?utf-8?B?MVpkTk1adENTaC9abi9kVGF5T0taMXdOTms2czYrWmtmSHdtVVF2b1hVZlpu?=
 =?utf-8?B?S01sVHdvaHo3SHN3dWlPV0NraktzaWlPVjlqRHZZZGVrYXRJaXZOcUZ2bEZE?=
 =?utf-8?B?RVpQbW5aanJOUklTWkVlekN2SnVNeHVwRm8wYkRlN0drSWRFaWZBbzdyTUlJ?=
 =?utf-8?B?Nlh4dHR0MVJNbFh4Mkt5VXBPVHpFYjRwNWVCMGRJZksrVFF6OFFGM0pvbUlH?=
 =?utf-8?B?K0tJS1VsNzlSUUhQY0hwK253WUY5MFhMSTBUTGFCRlFHUVJ6OVhQMzd0Mncy?=
 =?utf-8?B?WXpQVnl3U0Z1dDkrV3JjVjVLWGNwN1U5Y2c2akZuVzVUdnhKclBwd291NCtu?=
 =?utf-8?B?ZENUbXp0MHhlZlhJTmRwVm9BNGZLdG9KbDFqajlQL1dFYllUM0k4Q01Hdmxt?=
 =?utf-8?B?ckdnRVNZenAwb09vU1NPa00vNG5XelFVUWR5UzBFS0plR0w2TnlzZWc0VVlB?=
 =?utf-8?B?d3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0cd2a724-fd9c-4157-621e-08dc706e94b5
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 21:25:42.4607
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vgDaSmE1h3q5zzKBnrYaUAaQAOrG4VG8WmUc5cpgNNqyOH6AdTisL+Yrq8dlXjGXwLjHUWYVbVQjSaKpChoHFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7830

On 5/9/24 12:57 PM, Edward Liaw wrote:
> lib.mk will add -D_GNU_SOURCE to CFLAGS by default.  This will make it
> unnecessary to add #define _GNU_SOURCE in the source code.
> 
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
> Suggested-by: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
>   tools/testing/selftests/Makefile | 4 ++--
>   tools/testing/selftests/lib.mk   | 5 ++++-
>   2 files changed, 6 insertions(+), 3 deletions(-)
>

Hi Edward,

This looks good, with one small refactoring opportunity remaining, though:

> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index f0431e6cb67e..9039f3709aff 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -170,11 +170,11 @@ ifneq ($(KBUILD_OUTPUT),)
>     # $(realpath ...) resolves symlinks
>     abs_objtree := $(realpath $(abs_objtree))
>     BUILD := $(abs_objtree)/kselftest
> -  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include
> +  KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include
>   else
>     BUILD := $(CURDIR)
>     abs_srctree := $(shell cd $(top_srcdir) && pwd)
> -  KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include
> +  KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include

As mentioned in [1] (but there are a lot of patches to manage here, and
I think it got overlooked), you could factor out the duplicated
-D_GNU_SOURCE items into a single place:

[1] 
https://lore.kernel.org/all/ac8c217e-4109-4ca7-a7dd-fc4fc8b0a4de@nvidia.com/

thanks,
-- 
John Hubbard
NVIDIA

>     DEFAULT_INSTALL_HDR_PATH := 1
>   endif
>   
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 3023e0e2f58f..e782f4c96aee 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -67,7 +67,7 @@ MAKEFLAGS += --no-print-directory
>   endif
>   
>   ifeq ($(KHDR_INCLUDES),)
> -KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include
> +KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include
>   endif
>   
>   # In order to use newer items that haven't yet been added to the user's system
> @@ -188,6 +188,9 @@ endef
>   clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir)
>   	$(CLEAN)
>   
> +# Build with _GNU_SOURCE by default
> +CFLAGS += -D_GNU_SOURCE
> +
>   # Enables to extend CFLAGS and LDFLAGS from command line, e.g.
>   # make USERCFLAGS=-Werror USERLDFLAGS=-static
>   CFLAGS += $(USERCFLAGS)