Received-SPF: pass (google.com: domain of linux-kernel+bounces-174992-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: [PATCH] net: smc91x: Fix m68k kernel compilation for ColdFire CPU
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <98259c2f-b44a-467e-8854-48641984e468@lunn.ch>
Date: Thu, 9 May 2024 23:26:46 +0200
Cc: Nicolas Pitre <nico@fluxnic.net>,
 "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>,
 Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>,
 John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
 Arnd Bergmann <arnd@arndb.de>,
 netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <FF387A27-547C-448A-AF52-8E170C05C094@toblux.com>
References: <20240509121713.190076-2-thorsten.blum@toblux.com>
 <98259c2f-b44a-467e-8854-48641984e468@lunn.ch>
To: Andrew Lunn <andrew@lunn.ch>

On 9. May 2024, at 22:36, Andrew Lunn <andrew@lunn.ch> wrote:
> This seems like the wrong fix.
>=20
> commit d97cf70af09721ef416c61faa44543e3b84c9a55
> Author: Greg Ungerer <gerg@linux-m68k.org>
> Date:   Fri Mar 23 23:39:10 2018 +1000
>=20
>    m68k: use asm-generic/io.h for non-MMU io access functions
>=20
>    There is nothing really special about the non-MMU m68k IO access =
functions.
>    So we can easily switch to using the asm-generic/io.h functions.
>=20
> So it rather than put something back which there is an aim to remove,
> please find the generic replacement. This _swapw() swaps a 16 bit
> word. The generic for that is swab16().

Thanks. I will use ioread16be() and iowrite16be() as suggested by Arnd
instead and submit a v2 shortly.

Thorsten=