Received-SPF: pass (google.com: domain of linux-kernel+bounces-174987-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 9 May 2024 14:21:28 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Borislav Petkov <bp@alien8.de>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: Shiju Jose <shiju.jose@huawei.com>, "linux-cxl@vger.kernel.org"
	<linux-cxl@vger.kernel.org>, "linux-acpi@vger.kernel.org"
	<linux-acpi@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"dan.j.williams@intel.com" <dan.j.williams@intel.com>, "dave@stgolabs.net"
	<dave@stgolabs.net>, "dave.jiang@intel.com" <dave.jiang@intel.com>,
	"alison.schofield@intel.com" <alison.schofield@intel.com>,
	"vishal.l.verma@intel.com" <vishal.l.verma@intel.com>, "ira.weiny@intel.com"
	<ira.weiny@intel.com>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "david@redhat.com" <david@redhat.com>,
	"Vilas.Sridharan@amd.com" <Vilas.Sridharan@amd.com>, "leo.duran@amd.com"
	<leo.duran@amd.com>, "Yazen.Ghannam@amd.com" <Yazen.Ghannam@amd.com>,
	"rientjes@google.com" <rientjes@google.com>, "jiaqiyan@google.com"
	<jiaqiyan@google.com>, "tony.luck@intel.com" <tony.luck@intel.com>,
	"Jon.Grimm@amd.com" <Jon.Grimm@amd.com>, "dave.hansen@linux.intel.com"
	<dave.hansen@linux.intel.com>, "rafael@kernel.org" <rafael@kernel.org>,
	"lenb@kernel.org" <lenb@kernel.org>, "naoya.horiguchi@nec.com"
	<naoya.horiguchi@nec.com>, "james.morse@arm.com" <james.morse@arm.com>,
	"jthoughton@google.com" <jthoughton@google.com>, "somasundaram.a@hpe.com"
	<somasundaram.a@hpe.com>, "erdemaktas@google.com" <erdemaktas@google.com>,
	"pgonda@google.com" <pgonda@google.com>, "duenwen@google.com"
	<duenwen@google.com>, "mike.malvestuto@intel.com"
	<mike.malvestuto@intel.com>, "gthelen@google.com" <gthelen@google.com>,
	"wschwartz@amperecomputing.com" <wschwartz@amperecomputing.com>,
	"dferguson@amperecomputing.com" <dferguson@amperecomputing.com>,
	"wbs@os.amperecomputing.com" <wbs@os.amperecomputing.com>,
	"nifan.cxl@gmail.com" <nifan.cxl@gmail.com>, tanxiaofei
	<tanxiaofei@huawei.com>, "Zengtao (B)" <prime.zeng@hisilicon.com>,
	"kangkang.shen@futurewei.com" <kangkang.shen@futurewei.com>, wanghuiqiang
	<wanghuiqiang@huawei.com>, Linuxarm <linuxarm@huawei.com>, Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>, Jean Delvare <jdelvare@suse.com>, Guenter Roeck
	<linux@roeck-us.net>, Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [RFC PATCH v8 01/10] ras: scrub: Add scrub subsystem
Message-ID: <663d3e58a0f73_1c0a1929487@dwillia2-xfh.jf.intel.com.notmuch>
References: <20240425101542.GAZiotThrq7bOE9Ieb@fat_crate.local>
 <63fdbe26b51f4b7c859bfb30287c8673@huawei.com>
 <20240506103014.GHZjixNhhFkgkMhDg_@fat_crate.local>
 <e0ce36eb80054440ab877ccee4e606de@huawei.com>
 <20240508172002.GGZju0QvNfjB7Xm6qL@fat_crate.local>
 <4ceb38897d854cc095fca1220d49a4d2@huawei.com>
 <20240508192546.GHZjvRuvtu0XSJbkmz@fat_crate.local>
 <20240509101939.0000263a@Huawei.com>
 <D9511DC1-1566-473A-A426-111BB1F7F9F0@alien8.de>
 <20240509200306.GAZj0r-h5Tnc0ecIOz@fat_crate.local>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240509200306.GAZj0r-h5Tnc0ecIOz@fat_crate.local>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k8v33joibrc9hplfQsaKUXT/5Sk6twiLHZkfoSUIrBrarKOLwU0O5PHHZcSp?=
 =?us-ascii?Q?MeGvMcIVLZqv2vWNSm3Xc9S/JzeR80G5loKIY3TmcCcV2yoV8XnU3rQc2cc7?=
 =?us-ascii?Q?+koTxS5QAbSn6VY4VYeRdHBgWOjRDEbD5UUOHNQizxZAE4N/tyO0yuFrtRUx?=
 =?us-ascii?Q?LLrwA+7vDVMdaCRP8V4ooLSB3x1UI7TvPgYLSKoBj3Q2TqVt1t55UonsnM7W?=
 =?us-ascii?Q?+U21SRC4l8gNQbfrbM/u6ysoN4eM2cCe8glM1iChxKVYmuv+vQrTdurzaQUz?=
 =?us-ascii?Q?R4iHV5o5q4FApABovQUY+J0xmW/iu5nE9P66fdEiwAecOdL8BPBfFqrtRAyR?=
 =?us-ascii?Q?t7IvgqMSpTnDcag5O5mjlUfCjucKoWPkvsV5pHTEr+p2KooV5MlCftEjnwQs?=
 =?us-ascii?Q?9XRbob+jN+9vBsq+WnpzAl1B7bVfQer+GFpgPPF8E5txZap7rYBl66gLd85z?=
 =?us-ascii?Q?7xUw0isSt5nNdTHdNyZldFZTby+Qu8CAr+FBZif2nAwnpdcnwRuUyI4nXYAg?=
 =?us-ascii?Q?ioLpWKfvipGoG0hodNvwBTvZ3KqtdJptEPR4cYwbEtoGLNr5DFRhmBKDEUMc?=
 =?us-ascii?Q?Pxq3fHgy6UVzbvYBAVNTLwycV8HMjpDOBx/yAlmgZCKs1HSzrMhOnz+xUVcv?=
 =?us-ascii?Q?enhTluTgfeFS0AN8wuLsGatKi3c5amp60OjKBk9cpXpbKPVasOCD6tuRDMsJ?=
 =?us-ascii?Q?IiH4NUWbmE6iH93NdihPyx9cZ2C+QYjkzuEb63qqCmbX+tJj2qmu7th6FbJr?=
 =?us-ascii?Q?GyRyqKy7FoakuQuGeXhOoNuQUqqrNTDfvkCxn1axzZKxHf91Hf5XX/BwOtDK?=
 =?us-ascii?Q?5WMHJCObAJ9CPZk1Q+xiL2yknnKQPCMNlQFLPLRE+2hNgIdmamlMy/cZjcz4?=
 =?us-ascii?Q?IaUkPyVUuIh8IXY8IVk88At9Ipb/Hia1pro24xzevMtxTO5F3vYWFvxoHrmq?=
 =?us-ascii?Q?lbZWPMZonwQzN2amx4ORHhzYcipGxNakT8rne7sZSvG0CiwAuBfUzs1jPprh?=
 =?us-ascii?Q?RaYnDs3x0sr4LBOZOQMEgtgMS8dNXXQxkgD0RFiRuOMJrHiOqtSxHxiZY4Ok?=
 =?us-ascii?Q?VSQtsqnU/w+AACEyCzNr4efBaliDIueQ7OSoL838Xvg6VR9eeH936K7dX7ZB?=
 =?us-ascii?Q?xlaxaSA8YZAgW5iOTq5tmmEy7NPsNYcxve0SeQKSbnU9sVu59ckUNKbFtrrx?=
 =?us-ascii?Q?FfiuDwgRLh7BaDQ/fTdHdCzUsIMsrHUauEdiQcX/124+Y5YkLgF4zku2yrw9?=
 =?us-ascii?Q?ihGZvN43qJtQOLgpnLVpN+WB7FUw7xBH917JBxGaCsSD8iUtSg+V9FI4Jv8R?=
 =?us-ascii?Q?bs0T1QFm7TAV4a9cGx6P1meMz+QCclT4BurrsC6gSlPjG/ksGlBDUhIVUZul?=
 =?us-ascii?Q?txX4mH4K3lfSbRNpghzNoRld2L63fCSFNd1kjEzbqn2pX0zNA/Nnib5VPowp?=
 =?us-ascii?Q?ZGjXwHlMrr5WiwvuEp8QoRseL8f6vZoQbvmckcJwLsDTYGKujluvcGsmFW23?=
 =?us-ascii?Q?pjRuWOp4gIPh2Yb0BKfFdP4B9I8daXvLwxR3lqg2LuUjjdJcVtkXI/YIVLZk?=
 =?us-ascii?Q?YITgiEVQsBJeD0+dtjSEcBRHXtI4LuWnNXRJu7Y+qxmQQtzYejRI9W9Ped8f?=
 =?us-ascii?Q?Jg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c4e4376-556b-48de-2ced-08dc706e005e
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2024 21:21:33.6413
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eexRFzSX7/uMCgWAgiBcIzDjvT5PGn0HlUuV/XOYUF7KnxIh3hpDGtnGYtc2Sb9dTcsKeVZfnnjecSI0q1keOyopLHV2RGpSkqLp9fIVogo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7566
X-OriginatorOrg: intel.com

Borislav Petkov wrote:
> On Thu, May 09, 2024 at 05:52:18PM +0200, Borislav Petkov wrote:
> > Are you arguing for the nonsensical "it should load" case because it
> > is simply easier this way? How hard is that "jump through hoops" thing
> > anyway?
> 
> Let's see: the following patches add something called
> GET_SUPPORTED_FEATURES which is used to detect whether the system has
> patrol scrub functionality etc.
> 
> Then there's ras2_acpi_init() which checks for a RAS2 ACPI table.
> 
> Are you saying that checking for those two things in the init function
> is jumping through hoops?

Wait, this discussion has gone off the rails.

Recall that there are 461 usages of module_pci_driver() in the kernel.
Every one of those arranges for just registering a PCI driver when the
module is loaded regardless of whether any devices that driver cares
about are present.

Consider the case of the PCI subsystem that allows dynamically updating
the device ids that a driver attaches. I.e.

   echo $id > /sys/bus/pci/drivers/$driver/new_id

..the fundamentally does not work if the module unloads itself and the
driver(s) it registers when the PCI bus core finds no devices to attach
at runtime.

The mitigation for keeping unneeded modules unloaded is that udev does
not autoload modules unless a PCI bus udev event matches a module's
published PCI device table.

Don't want to waste module memory? Don't load the module.