Received-SPF: pass (google.com: domain of linux-kernel+bounces-175036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240508060427.417-1-ravi.bangoria@amd.com> <CAM9d7cgFKcHXeTXxax7GRCK__0U3HUnG3Ls09GpnD8FipyJk1A@mail.gmail.com>
 <0689aa59-426e-2f37-dcc4-d79b1e89403c@amd.com>
In-Reply-To: <0689aa59-426e-2f37-dcc4-d79b1e89403c@amd.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 9 May 2024 15:33:29 -0700
Message-ID: <CAM9d7chvDczhMoOJFLz=MW0ojGm=Ex90CgHhfOsZuLre3vSE3g@mail.gmail.com>
Subject: Re: [RFC 0/4] perf sched: Introduce schedstat tool
To: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, 
	irogers@google.com, swapnil.sapkal@amd.com, mark.rutland@arm.com, 
	alexander.shishkin@linux.intel.com, jolsa@kernel.org, rostedt@goodmis.org, 
	vincent.guittot@linaro.org, bristot@redhat.com, adrian.hunter@intel.com, 
	james.clark@arm.com, kan.liang@linux.intel.com, gautham.shenoy@amd.com, 
	kprateek.nayak@amd.com, juri.lelli@redhat.com, yangjihong@bytedance.com, 
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, 
	santosh.shukla@amd.com, ananth.narayan@amd.com, sandipan.das@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, May 8, 2024 at 11:02=E2=80=AFPM Ravi Bangoria <ravi.bangoria@amd.co=
m> wrote:
>
> >> USAGE
> >> -----
> >>
> >>   # perf sched schedstat record
> >>   # perf sched schedstat report
> >
> > Hmm. I think we can remove the duplication in 'sched'. :)
>
> You mean `perf sched stat record/report` ?
>
> > Given you are thinking of taskstat, how about making it
> > 'cpustat' instead?
>
> Sure. How about:
>
>   # perf sched stat --cpu --task record

If you plan to support both cpu and task at the same time,
then I'm ok with this.  But if they're mutually exclusive, then
probably you want to have them as sub-commands.

Thanks,
Namhyung


>   # perf sched stat report
>
> > Also I think it'd be easier if you also provide 'live' mode so that
> > users can skip record + report steps and run the workload
> > directly like uftrace does. :)
> >
> > Something like this
> >
> >   # perf sched cpustat  myworkload
> >   (result here ...)
>
> Sure.
>
> Thanks for the feedback,
> Ravi